Re: [PATCH V4] KVM: selftests: Add a new option to rseq_test

["Chen, Zide" <zide.chen@intel.com>]

On 5/2/2024 10:40 AM, Sean Christopherson wrote:
> On Mon, Apr 29, 2024, Zide Chen wrote:
>> Currently, the migration worker delays 1-10 us, assuming that one
>> KVM_RUN iteration only takes a few microseconds.  But if the CPU low
>> power wakeup latency is large enough, for example, hundreds or even
>> thousands of microseconds deep C-state exit latencies on x86 server
>> CPUs, it may happen that it's not able to wakeup the target CPU before
>> the migration worker starts to migrate the vCPU thread to the next CPU.
>>
>> If the system workload is light, most CPUs could be at a certain low
>> power state, which may result in less successful migrations and fail the
>> migration/KVM_RUN ratio sanity check.  But this is not supposed to be
>> deemed a test failure.
>>
>> This patch adds a command line option to skip the sanity check in
>> this case.
>>
>> Signed-off-by: Zide Chen <zide.chen@intel.com>
>> Co-developed-by: donsheng <dongsheng.x.zhang@intel.com>
> 
> This needs Dongsheng's SoB, and your SoB should come last.  And the attributed
> name for any tag should use the person's full name.  Given that I have emails from
> Dongsheng that show up as "Dongsheng Zhang", I _assume_ "donsheng" is incomplete,
> but that's a big assumption on my part.
> 
> Dongsheng, can you provide your explicit SoB, with how you want your name to show
> up?  Thanks!

My bad, will get it fixed. Confirmed with Dongsheng that going forward,
he will use his full name in all the tags.

> From Documentation/process/submitting-patches.rst:
> 
>   Co-developed-by: states that the patch was co-created by multiple developers;
>   it is used to give attribution to co-authors (in addition to the author
>   attributed by the From: tag) when several people work on a single patch.  Since
>   Co-developed-by: denotes authorship, every Co-developed-by: must be immediately
>   followed by a Signed-off-by: of the associated co-author.  Standard sign-off
>   procedure applies, i.e. the ordering of Signed-off-by: tags should reflect the
>   chronological history of the patch insofar as possible, regardless of whether
>   the author is attributed via From: or Co-developed-by:.  Notably, the last
>   Signed-off-by: must always be that of the developer submitting the patch.
>   
>   Note, the From: tag is optional when the From: author is also the person (and
>   email) listed in the From: line of the email header.
>   
>   Example of a patch submitted by the From: author::
>   
>           <changelog>
>   
>           Co-developed-by: First Co-Author <first@coauthor.example.org>
>           Signed-off-by: First Co-Author <first@coauthor.example.org>
>           Co-developed-by: Second Co-Author <second@coauthor.example.org>
>           Signed-off-by: Second Co-Author <second@coauthor.example.org>
>           Signed-off-by: From Author <from@author.example.org>
>   
>   Example of a patch submitted by a Co-developed-by: author::
>   
>           From: From Author <from@author.example.org>
>   
>           <changelog>
>   
>           Co-developed-by: Random Co-Author <random@coauthor.example.org>
>           Signed-off-by: Random Co-Author <random@coauthor.example.org>
>           Signed-off-by: From Author <from@author.example.org>
>           Co-developed-by: Submitting Co-Author <sub@coauthor.example.org>
>           Signed-off-by: Submitting Co-Author <sub@coauthor.example.org>
>