From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3FF882DE6E8 for ; Thu, 3 Jul 2025 08:33:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751531601; cv=none; b=QD3YRJV2ifqoTpAgb7SGd3rr3P4rGBo6j/8KnhkTNIhQvJsnY7pzNAcc+wmun7FKUErGNVaFh4eZ4fpyLQjLZr/UsYM7aXGKAoPxAN5m47BbkqHo9PSDRnYXtu5DwF5VnuBO9xCco/20zTdJ5z0G6WlJqeuPulgZ/Iy3YqEsDsQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751531601; c=relaxed/simple; bh=jsxGTLvWyE6VOD3rXnTmpho8fSNhzc6+zzXTRo0vtTw=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=IhclprWlQWJgP5Op6m4tnALTbvWqnfn+NTs3oREsw+qk75ZEyVUNNxCNP5GmrKuruc0jSpKTC94F6DgiPS/JMubqLNFJ1BhnPsBbBCcwM5MOhVCKSA804xKSkLP8y/b2FZN6bw79HdAvFLc38Ku+hPzt4QcaP2d2DNpKy/kJYZw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=b0E7zxU8; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="b0E7zxU8" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1751531598; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=7SWfilH1hR4xNtdUxJC34N64AAXVXE4WjW5sXEnmx9I=; b=b0E7zxU8QwAI48tWYc1tj1Z1ilR71ebNnpLWtD8IsHcUTe041dKixaAPZlF8oHzcl+wmiM vK7N+LibYhc0H8hVSeJJD2rSILMBljx4LynZxAnUfGmXucYfU9XG4iMIi7ZXadRgTL14Hq iHGHc/xdX1B12oI8ANoHu2KHQQWcgOA= Received: from mail-ej1-f69.google.com (mail-ej1-f69.google.com [209.85.218.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-664-Y8JxbrVhMsGRtNwmt6MvTw-1; Thu, 03 Jul 2025 04:33:16 -0400 X-MC-Unique: Y8JxbrVhMsGRtNwmt6MvTw-1 X-Mimecast-MFC-AGG-ID: Y8JxbrVhMsGRtNwmt6MvTw_1751531595 Received: by mail-ej1-f69.google.com with SMTP id a640c23a62f3a-ade81d27cddso751601966b.0 for ; Thu, 03 Jul 2025 01:33:16 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1751531595; x=1752136395; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=7SWfilH1hR4xNtdUxJC34N64AAXVXE4WjW5sXEnmx9I=; b=Rik7DD+hDQZ0V4BnWgJMlU2iLc6Eir07uvoScXLSTJDSebunfeQAx12i+TmB+Wx+Dy TpFBusgqH2SOBjbswj0d+SVECjf5Qsub50GJaFvykKoH94tG+UOGgSIV24l7Vq4nbq0w 2igsVj3Tdt9tFIppqc38yz8ASZcjZN/xO6/QZdCBZsO3wMBlKYnxWHKx52R9h7E9n6ZP Yi5LDg2uGOF4TFpxK84gkqe7VU+2CS0nK5rzePNVMYoZJw5vaTDWqEk2UF8lxo3CUumV RMW6AxnNNety40qorO+36nFA5UDjQ1Mo3z/sjsmreJDCJ02CXqcLKaYTEcWu3wR/nl2v WlBw== X-Forwarded-Encrypted: i=1; AJvYcCVR4G6mJzlX1wR5OtdIPgmL1hEVC8xaNkH02PQau0M5/qKKL241e/BqjVClyBTceDleLiptu5m+d16ClgsymNQ=@vger.kernel.org X-Gm-Message-State: AOJu0Yzdd03SP2zKLo/7N9vLI+MIa56LjR1CHOSTke/7jwW2iq9NrsTx 53QkcMksmOdmpRdrzHQdWrV7hPHfLJa/90RR5oFggAwLY/k0JtRfUXjzuBc9YdoKneiqkXd2xIO gzDWvrOlNQN/gCShGB3oFNt2VfKHmmTnHQTRBG5+4SZ6csvUUhDR6m4AHWkHPs5z+fbU2iw== X-Gm-Gg: ASbGncsC3FlCePztR0T8wqzrtQSfkLSW7sSfWXtKIOO62EnfsXP/Kxh4Pumglaaz2AM z8kskLc7JcdcEjiUIrI4JFJOfmqxWJ5LIR2SECalfmqVDiou8jj5by6J1Q76xrum8XeW+xptCBu 2Zt+bbL34pLFyK6xBpBWAluvhpK4uNXEp4NgC0ZXIOQO/hv8oz8mksV7qsKNVyOJdNn06CwujuH +A+P0KvrHRtbZUD4S6n/nEQj/QKrhWS4kACLpLZ2KWOSFEolaKxOHQPd7j+GFs7EzeTIM06hoIX zYMT7tpMB7D/hqvkK8LK/ewaoC/1wRprEcx/S9VCY5Z3 X-Received: by 2002:a17:907:868a:b0:ae3:9ec1:9c03 with SMTP id a640c23a62f3a-ae3d8c9dce1mr207803766b.37.1751531595286; Thu, 03 Jul 2025 01:33:15 -0700 (PDT) X-Google-Smtp-Source: AGHT+IG9NTWM2P0BJWRs37nX9+c0WsdZUAjew6H7gEWAFJ8Lyt+jgvESL94PlTE51IFyVEsNQKSHKA== X-Received: by 2002:a17:907:868a:b0:ae3:9ec1:9c03 with SMTP id a640c23a62f3a-ae3d8c9dce1mr207799666b.37.1751531594790; Thu, 03 Jul 2025 01:33:14 -0700 (PDT) Received: from [10.32.64.156] (nat-pool-muc-t.redhat.com. [149.14.88.26]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-ae3e8f4b264sm35814266b.102.2025.07.03.01.33.13 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 03 Jul 2025 01:33:14 -0700 (PDT) Message-ID: <9586f8ff-3b34-4613-853b-0c808fcbb9d2@redhat.com> Date: Thu, 3 Jul 2025 10:33:13 +0200 Precedence: bulk X-Mailing-List: linux-kselftest@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 5/7] selftests/mm: Fix child process exit codes in ksm_functional_tests To: Aboorva Devarajan , akpm@linux-foundation.org, Liam.Howlett@oracle.com, lorenzo.stoakes@oracle.com, shuah@kernel.org, pfalcato@suse.de, ziy@nvidia.com, baolin.wang@linux.alibaba.com, npache@redhat.com, ryan.roberts@arm.com, dev.jain@arm.com, baohua@kernel.org Cc: linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, donettom@linux.ibm.com, ritesh.list@gmail.com References: <20250703060656.54345-1-aboorvad@linux.ibm.com> <20250703060656.54345-6-aboorvad@linux.ibm.com> From: David Hildenbrand Content-Language: en-US Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20250703060656.54345-6-aboorvad@linux.ibm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 03.07.25 08:06, Aboorva Devarajan wrote: > In ksm_functional_tests, test_child_ksm() returned negative values > to indicate errors. However, when passed to exit(), these were > interpreted as large unsigned values (e.g, -2 became 254), leading to > incorrect handling in the parent process. As a result, some tests > appeared to be skipped or silently failed. > > This patch changes test_child_ksm() to return positive error codes > (1, 2, 3) and updates test_child_ksm_err() to interpret them correctly. > This ensures the parent accurately detects and reports child process > failures. > > -------------- > Before patch: > -------------- > - [RUN] test_unmerge > ok 1 Pages were unmerged > ... > - [RUN] test_prctl_fork > - No pages got merged > - [RUN] test_prctl_fork_exec > ok 7 PR_SET_MEMORY_MERGE value is inherited > ... > Bail out! 1 out of 8 tests failed > - Planned tests != run tests (9 != 8) > - Totals: pass:7 fail:1 xfail:0 xpass:0 skip:0 error:0 > > -------------- > After patch: > -------------- > - [RUN] test_unmerge > ok 1 Pages were unmerged > ... > - [RUN] test_prctl_fork > - No pages got merged > not ok 7 Merge in child failed > - [RUN] test_prctl_fork_exec > ok 8 PR_SET_MEMORY_MERGE value is inherited > ... > Bail out! 2 out of 9 tests failed > - Totals: pass:7 fail:2 xfail:0 xpass:0 skip:0 error:0 > > Fixes: 6c47de3be3a0 ("selftest/mm: ksm_functional_tests: extend test case for ksm fork/exec") > Signed-off-by: Aboorva Devarajan BTW, when I run the test, I get this weird output TAP version 13 1..9 # [RUN] test_unmerge ok 1 Pages were unmerged # [RUN] test_unmerge_zero_pages ok 2 KSM zero pages were unmerged # [RUN] test_unmerge_discarded ok 3 Pages were unmerged # [RUN] test_unmerge_uffd_wp ok 4 Pages were unmerged # [RUN] test_prot_none ok 5 Pages were unmerged # [RUN] test_prctl ok 6 Setting/clearing PR_SET_MEMORY_MERGE works # [RUN] test_prctl_fork ok 7 PR_SET_MEMORY_MERGE value is inherited # [RUN] test_prctl_fork_exec ^ where is the test? # [RUN] test_prctl_unmerge ok 8 Pages were unmerged # Planned tests != run tests (9 != 8) # Totals: pass:8 fail:0 xfail:0 xpass:0 skip:0 error:0 ^ what? ok 8 PR_SET_MEMORY_MERGE value is inherited # [RUN] test_prctl_unmerge ok 9 Pages were unmerged # Totals: pass:9 fail:0 xfail:0 xpass:0 skip:0 error:0 ^ huh, what now? -- Cheers, David / dhildenb