From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9983A2D7DF2 for ; Tue, 7 Oct 2025 10:12:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759831936; cv=none; b=sfDCSSWw+m7XtW+M9lYQYMc7kSLLxnmMTcIDq4uw+u2lzOUoPSg57+KhL3Z4f6TVF1z3qAbZFgaxqAK6hHh4aVHSoAbmRo+FZkXdAr+0yCxemzxuDO6lHLJbUjgePLpMLtGKhS5VHs+p5+/GwV6g/kxpmfmmM3Rf41AlrzHAnXw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759831936; c=relaxed/simple; bh=K5ih1fcLdd7FAp/nTzxWpRzg6pbB2HICCQemr+Ina0Q=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=rUYiOrmlzhGOsWOCBjKUpQhL7THTQWfTa+n56qWGutjOXgpWbixolciOncYRwMDVoVatykK6ui79VIuwwGDyKxzzjGK8D3JbeWxBQH0o3aBkQWXF5dY/bAucBlKnfLO3rj8D5kbCMrT2YHI1aCb3Mxl6jAfFlBz99N3Y4nKgCL8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=gU70vLiO; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="gU70vLiO" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1759831933; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=bQl2T7LiPKb6GyAjuTicXUHe3bGmDDt+v34reyvvw/M=; b=gU70vLiONMnivq9OeY3bOdKwROx+EG0p7aHbQd+i0ypI0K8Epx/3/0YC4DAaksMrqvWTOr WKjrB9SGG86peAjtowwyuh4IZ7oxxI+fZuH7ylPgy59ZmqtyNfljb484AF/54mBxWWOlw6 TSUWMX+laJta5vHomiSO5ax+5SII7M0= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-157-MDa29oBBNUiSqPivlG3OaQ-1; Tue, 07 Oct 2025 06:12:12 -0400 X-MC-Unique: MDa29oBBNUiSqPivlG3OaQ-1 X-Mimecast-MFC-AGG-ID: MDa29oBBNUiSqPivlG3OaQ_1759831931 Received: by mail-wr1-f70.google.com with SMTP id ffacd0b85a97d-3f924ae2a89so4436732f8f.3 for ; Tue, 07 Oct 2025 03:12:12 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1759831931; x=1760436731; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=bQl2T7LiPKb6GyAjuTicXUHe3bGmDDt+v34reyvvw/M=; b=jq8Cyz6D/J3VDqcMjVaPBLIrvqlN8YRFf+dEv+1NN1NPO1Ov49tONazaxCo+xdP9Pz A9u4U2F/Q1moF7mFj4CmYghpMkOOPZHq4l+XR/SBsvD9WfED3RhnWc0eDwxMHjH5JlEb NzgMPfO5PpYKUu+VAnhfdGijzww3UrwLMyjW39t6eSNL0thCHaYb6vPZapakXAwdNY6P LY3s9jIclpbPSF/oUVv90qDh3bxKXt3dD8KnE7WjGa5In7v5KmQrqr6PueN50Fc22W2g U6lXv89WBE0OZH2hMebpgzsBacGBP33c98lrVbeFsirphnXn47SkDp5yPse55NHBIUCZ X6Sg== X-Forwarded-Encrypted: i=1; AJvYcCXID90X3ofa96VDPLTy4fLSCCXMRbeGBqRoi/9p+VFXxUq5IKnMPesR0iAUxIfGzaK9YBaJ8QCClPUdcvvwznk=@vger.kernel.org X-Gm-Message-State: AOJu0Yytk2LQSbPts6H6SrHRwX4yCkDcVD7AzQkwhwkfByi3Ie6u9Vzt HXWR0NO+I5HrBm9W5h8sqMGF5UOhgHA5G8ApBeoYUYHAbp+aoUoafmYqMIr6iZfIVdvuvO/sryK nWRmjWlYyyMQuEsMyYpy0zydG4gRuon050OYM7HT7KgA2qPbodWEAFY61bIAjqBRlGgwA/Q== X-Gm-Gg: ASbGncuM6Fls2iGTMrtRtQaCdpseG2KqhBT3KSkX5Wibg4LATq9YrmR8NDxvdSesrAC cK24na1hG8P0k+UgrUNZM01EL3enB0hwtj/iEd2pmYz6Qr+ZHwoZhnIWPdQzJsbLJ7ZDteTsau7 zLmHgsNJSDFCoUr+9RsE/IoxGR0P6EhswPg41jeejukq3YlLzAaQls1KvhPqV6xai8o10fqtwCD 7anEzMRiIuitwlAIFzXP33lEyI3GUSBtG8RoxE/l8iBfUagqYkANvRVHp9liFSaPYuD5Y4zbGdQ gchJqOqd6JuD3WXaX/raEVe/JLmqtutxajKW0aZVEMTb653wR/zrjM//Ju/EM+L/igvBmkhVDBJ Jhz3RmDVXUiJfYUqJJg== X-Received: by 2002:a05:6000:26c7:b0:3ec:4e41:fd86 with SMTP id ffacd0b85a97d-425671abb56mr8897437f8f.50.1759831930933; Tue, 07 Oct 2025 03:12:10 -0700 (PDT) X-Google-Smtp-Source: AGHT+IElT2zv84PkTMQb+IKMagVR2YqjOOjuYvYqUPHGOQ1mK0lXAffA65VV2mZwTbjFrEfS+7DMjw== X-Received: by 2002:a05:6000:26c7:b0:3ec:4e41:fd86 with SMTP id ffacd0b85a97d-425671abb56mr8897407f8f.50.1759831930499; Tue, 07 Oct 2025 03:12:10 -0700 (PDT) Received: from ?IPV6:2a0d:3344:2712:7e10:4d59:d956:544f:d65c? ([2a0d:3344:2712:7e10:4d59:d956:544f:d65c]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4255d8a6e1bsm25083049f8f.8.2025.10.07.03.12.09 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 07 Oct 2025 03:12:10 -0700 (PDT) Message-ID: <96ab4322-e27b-452a-8408-d36c3e209714@redhat.com> Date: Tue, 7 Oct 2025 12:12:08 +0200 Precedence: bulk X-Mailing-List: linux-kselftest@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net repost] selftests: drv-net: make linters happy with our imports To: Jakub Kicinski , davem@davemloft.net Cc: netdev@vger.kernel.org, edumazet@google.com, andrew+netdev@lunn.ch, horms@kernel.org, petrm@nvidia.com, shuah@kernel.org, daniel.zahka@gmail.com, willemb@google.com, linux-kselftest@vger.kernel.org References: <20251003164748.860042-1-kuba@kernel.org> Content-Language: en-US From: Paolo Abeni In-Reply-To: <20251003164748.860042-1-kuba@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 10/3/25 6:47 PM, Jakub Kicinski wrote: > Linters are still not very happy with our __init__ files, > which was pointed out in recent review (see Link). > > We have previously started importing things one by one to > make linters happy with the test files (which import from __init__). > But __init__ file itself still makes linters unhappy. > > To clean it up I believe we must completely remove the wildcard > imports, and assign the imported modules to __all__. > > hds.py needs to be fixed because it seems to be importing > the Python standard random from lib.net. > > We can't use ksft_pr() / ktap_result() in case importing > from net.lib fails. Linters complain that those helpers > themselves may not have been imported. > > Link: https://lore.kernel.org/9d215979-6c6d-4e9b-9cdd-39cff595866e@redhat.com > Signed-off-by: Jakub Kicinski > --- > - resend after net-next PR was merged > v1: https://lore.kernel.org/20251001234308.2895998-1-kuba@kernel.org > > Sending a fix for the driver's __init__.py first, if this is okay > with everyone I'll convert the rest. I'm not super confident 'cause > my Python isn't properly learned. > > Sending for net, even tho its not a real fix. I think that getting > it applied during the merge window may be okay? No strong prefence. > I'm slightly worried that merging it in net-next after the MW will > leave us with a release cycle full of merge conflicts. AFAICS linters are indeed happy, and I agree this should go via net, to propagate the correct style ASAP on both trees. Thanks, Paolo