From: Shuah Khan <skhan@linuxfoundation.org>
To: Benjamin Tissoires <bentiss@kernel.org>, Yun Lu <luyun@kylinos.cn>
Cc: jikos@kernel.org, shuah@kernel.org,
linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org,
Shuah Khan <skhan@linuxfoundation.org>
Subject: Re: [PATCH v2] selftest: hid: add the missing tests directory
Date: Wed, 16 Oct 2024 09:08:33 -0600 [thread overview]
Message-ID: <96ac2fd6-a885-4455-b0c9-91c514c8f3f5@linuxfoundation.org> (raw)
In-Reply-To: <4ioshjncgxafin7jcm7kne5fahp4l5nhk5664mnrdo7fgutgyn@jac5gopdyjty>
On 10/16/24 02:27, Benjamin Tissoires wrote:
> On Oct 15 2024, Yun Lu wrote:
>> Commit 160c826b4dd0 ("selftest: hid: add missing run-hid-tools-tests.sh")
>> has added the run-hid-tools-tests.sh script for it to be installed, but
>> I forgot to add the tests directory together.
>>
>> If running the test case without the tests directory, will results in
>> the following error message:
>>
>> make -C tools/testing/selftests/ TARGETS=hid install \
>> INSTALL_PATH=$KSFT_INSTALL_PATH
>> cd $KSFT_INSTALL_PATH
>> ./run_kselftest.sh -t hid:hid-core.sh
>>
>> /usr/lib/python3.11/site-packages/_pytest/config/__init__.py:331: PluggyTeardownRaisedWarning: A plugin raised an exception during an old-style hookwrapper teardown.
>> Plugin: helpconfig, Hook: pytest_cmdline_parse
>> UsageError: usage: __main__.py [options] [file_or_dir] [file_or_dir] [...]
>> __main__.py: error: unrecognized arguments: --udevd
>> inifile: None
>> rootdir: /root/linux/kselftest_install/hid
>>
>> In fact, the run-hid-tools-tests.sh script uses the scripts in the tests
>> directory to run tests. The tests directory also needs to be added to be
>> installed.
>>
>> v2: add the error message
>>
>> Fixes: ffb85d5c9e80 ("selftests: hid: import hid-tools hid-core tests")
>> Cc: stable@vger.kernel.org
>> Signed-off-by: Yun Lu <luyun@kylinos.cn>
>
> Acked-by: Benjamin Tissoires <bentiss@kernel.org>
>
> Shuah, I guess you'll want to take this one through your tree given that
> you already took the run-hid-tools-tests.sh one?
>
Yes. I will take this one. Thanks.
thanks,
-- Shuah
next prev parent reply other threads:[~2024-10-16 15:08 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-15 9:15 [PATCH v2] selftest: hid: add the missing tests directory Yun Lu
2024-10-16 8:27 ` Benjamin Tissoires
2024-10-16 15:08 ` Shuah Khan [this message]
2024-10-16 21:59 ` Shuah Khan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=96ac2fd6-a885-4455-b0c9-91c514c8f3f5@linuxfoundation.org \
--to=skhan@linuxfoundation.org \
--cc=bentiss@kernel.org \
--cc=jikos@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=luyun@kylinos.cn \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox