From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.20]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 763D153E0B; Tue, 23 Jun 2026 04:56:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.20 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782190568; cv=none; b=NSLbMEoklIQjAeWY/+arYUeuun54TJ98wGVLCnKQIBF2S1v/BChVr4TGJOWNzAjBwh/ZWKOw0SQ/48AVJaLf09kjvzjvkVVOuUBL4wWB6U+UZHBERdGYTc/prYZdiz26dUYek55Qtw0SWZCGThFgpEY9hTZLFPHDjf2h8yU6yUk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782190568; c=relaxed/simple; bh=TLs0cQbV4zQ3otfUmbOc+g0UN+QoGh4qUf1p9MrAKU0=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Cpp/DyQUcJx0OHNdyKonb2TIt9/eOu7Xbw4/8eUu0vIxaDCVQ3Yn8AXQ7wUWNQKhE1f5G28IejWLmPRniuiDVxK5C6uReA8wSplIqf4QE0xQlB76p/QJd2wJdOxnCalTuGmnsgPDBO5Hu8utOCXYjdhmUpO9vtRr3PSURag+swg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=pass smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=nRx1Vcd5; arc=none smtp.client-ip=198.175.65.20 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="nRx1Vcd5" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1782190567; x=1813726567; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=TLs0cQbV4zQ3otfUmbOc+g0UN+QoGh4qUf1p9MrAKU0=; b=nRx1Vcd5EHkx11DaM63lpi38QvmCKT/Q7C0qjoyG1y8BRx9sxHLsqrLI NXEAa25tJic8giKi9ijw+mTTQywiCAvXutdf2kmNe2G2U/l+xyRttkW1B fieYLssVmBVDkWt80sKU4PqVEG4xNreAQlBb9B3ORWt5rTEiQf5uYgzBj Av1IflftMwpgVzCjlVUJrE5q9DEsFxdBS6yxvSnUhbCiZuZJW0zv2H/Ur uJRK4NLRz6CKyLmDE33Qjzs3KRWexXJldZ7+Gdx3xLlGUTSZh9uvr1gE5 mUGbjSZ1unRuNZ1QYEpzbL3U1wlhCTYZsbb18DLr8dFvQxjYR517N0/g5 g==; X-CSE-ConnectionGUID: XXTW7DstQRqtL/pRusoevQ== X-CSE-MsgGUID: 5Iv15DEqR/+HU+HMViG0zw== X-IronPort-AV: E=McAfee;i="6800,10657,11825"; a="82696353" X-IronPort-AV: E=Sophos;i="6.24,220,1774335600"; d="scan'208";a="82696353" Received: from orviesa010.jf.intel.com ([10.64.159.150]) by orvoesa112.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Jun 2026 21:56:06 -0700 X-CSE-ConnectionGUID: 4Bxv4k3BSX6J0pVhhllv2Q== X-CSE-MsgGUID: yXIM0ueyQAGYNRhCF5FN7g== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.24,220,1774335600"; d="scan'208";a="248527637" Received: from unknown (HELO [10.238.2.81]) ([10.238.2.81]) by orviesa010-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Jun 2026 21:55:52 -0700 Message-ID: <96fb369d-dbff-4ed6-b1f9-0ce63d7d4ed0@linux.intel.com> Date: Tue, 23 Jun 2026 12:55:50 +0800 Precedence: bulk X-Mailing-List: linux-kselftest@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v8 07/46] KVM: Rename memory attribute APIs to prepare for in-place gmem conversion To: ackerleytng@google.com Cc: aik@amd.com, andrew.jones@linux.dev, brauner@kernel.org, chao.p.peng@linux.intel.com, david@kernel.org, jmattson@google.com, jthoughton@google.com, michael.roth@amd.com, oupton@kernel.org, pankaj.gupta@amd.com, qperret@google.com, rick.p.edgecombe@intel.com, rientjes@google.com, shivankg@amd.com, steven.price@arm.com, tabba@google.com, willy@infradead.org, wyihan@google.com, yan.y.zhao@intel.com, forkloop@google.com, pratyush@kernel.org, suzuki.poulose@arm.com, aneesh.kumar@kernel.org, liam@infradead.org, Paolo Bonzini , Sean Christopherson , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Steven Rostedt , Masami Hiramatsu , Mathieu Desnoyers , Jonathan Corbet , Shuah Khan , Shuah Khan , Vishal Annapurve , Andrew Morton , Chris Li , Kairui Song , Kemeng Shi , Nhat Pham , Barry Song , Axel Rasmussen , Yuanchu Xie , Wei Xu , Youngjun Park , Qi Zheng , Shakeel Butt , Kiryl Shutsemau , Baoquan He , Jason Gunthorpe , Vlastimil Babka , kvm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org, linux-doc@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-mm@kvack.org, linux-coco@lists.linux.dev References: <20260618-gmem-inplace-conversion-v8-0-9d2959357853@google.com> <20260618-gmem-inplace-conversion-v8-7-9d2959357853@google.com> Content-Language: en-US From: Binbin Wu In-Reply-To: <20260618-gmem-inplace-conversion-v8-7-9d2959357853@google.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 6/19/2026 8:31 AM, Ackerley Tng via B4 Relay wrote: > diff --git a/include/linux/kvm_host.h b/include/linux/kvm_host.h > index d370e834d619e..eb26d4ea8945a 100644 > --- a/include/linux/kvm_host.h > +++ b/include/linux/kvm_host.h > @@ -2534,13 +2534,13 @@ static inline bool kvm_memslot_is_gmem_only(const struct kvm_memory_slot *slot) > } > > #ifdef CONFIG_KVM_VM_MEMORY_ATTRIBUTES > -static inline unsigned long kvm_get_memory_attributes(struct kvm *kvm, gfn_t gfn) > +static inline unsigned long kvm_get_vm_memory_attributes(struct kvm *kvm, gfn_t gfn) > { > return xa_to_value(xa_load(&kvm->mem_attr_array, gfn)); > } > > -bool kvm_range_has_memory_attributes(struct kvm *kvm, gfn_t start, gfn_t end, > - unsigned long mask, unsigned long attrs); > +bool kvm_range_has_vm_memory_attributes(struct kvm *kvm, gfn_t start, gfn_t end, > + unsigned long mask, unsigned long attrs); > bool kvm_arch_pre_set_memory_attributes(struct kvm *kvm, > struct kvm_gfn_range *range); > bool kvm_arch_post_set_memory_attributes(struct kvm *kvm, > @@ -2548,7 +2548,14 @@ bool kvm_arch_post_set_memory_attributes(struct kvm *kvm, > > static inline bool kvm_mem_is_private(struct kvm *kvm, gfn_t gfn) > { > - return kvm_get_memory_attributes(kvm, gfn) & KVM_MEMORY_ATTRIBUTE_PRIVATE; > + return kvm_get_vm_memory_attributes(kvm, gfn) & KVM_MEMORY_ATTRIBUTE_PRIVATE; > +} > +static inline bool kvm_mem_range_is_private(struct kvm *kvm, gfn_t start, > + gfn_t end) > +{ > + return kvm_range_has_vm_memory_attributes(kvm, start, end, > + KVM_MEMORY_ATTRIBUTE_PRIVATE, > + KVM_MEMORY_ATTRIBUTE_PRIVATE); > } This function is added, but never used in this patch series. Is it intended to be called only when CONFIG_KVM_VM_MEMORY_ATTRIBUTES is enabled? > #else > static inline bool kvm_mem_is_private(struct kvm *kvm, gfn_t gfn)