From: Reinette Chatre <reinette.chatre@intel.com>
To: Shaopeng Tan <tan.shaopeng@jp.fujitsu.com>,
Fenghua Yu <fenghua.yu@intel.com>, Shuah Khan <shuah@kernel.org>
Cc: <linux-kernel@vger.kernel.org>, <linux-kselftest@vger.kernel.org>
Subject: Re: [PATCH] selftests/resctrl: Return MBA check result and make it to output message
Date: Thu, 22 Sep 2022 10:51:03 -0700 [thread overview]
Message-ID: <97522844-0b19-fcfa-dd39-c2c2c9ca37ca@intel.com> (raw)
In-Reply-To: <20220914015147.3071025-3-tan.shaopeng@jp.fujitsu.com>
Hi Shaopeng,
On my side this patch arrived as an unnumbered sixth patch forming
part of a five patch series.
On 9/13/2022 6:51 PM, Shaopeng Tan wrote:
> Since MBA check result is not returned, the MBA test result message
> is always output as OK regardless of whether the MBA check result is
> true or fail.
fail -> false?
I think it should be either succeed/fail or true/false.
>
> Make output message to be "not ok" if MBA check result is failed.
>
> This patch is based on Linux v6.0-rc5
This should not be part of the changelog but instead be below the "---".
>
> Signed-off-by: Shaopeng Tan <tan.shaopeng@jp.fujitsu.com>
> ---
Thank you very much for catching this. The fix looks good,
I only have nitpicks about the changelog.
Reviewed-by: Reinette Chatre <reinette.chatre@intel.com>
Reinette
next prev parent reply other threads:[~2022-09-22 17:51 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-14 1:51 [PATCH 0/5] selftests/resctrl: Some improvements of resctrl selftest Shaopeng Tan
2022-09-14 1:51 ` [PATCH 1/5] selftests/resctrl: Clear unused initalization code in MBM tests Shaopeng Tan
2022-09-22 17:44 ` Reinette Chatre
2022-09-27 9:01 ` tan.shaopeng
2022-09-28 15:48 ` Reinette Chatre
2022-09-29 5:28 ` tan.shaopeng
2022-09-29 15:27 ` Reinette Chatre
2022-09-14 1:51 ` [PATCH] selftests/resctrl: Return MBA check result and make it to output message Shaopeng Tan
2022-09-22 17:51 ` Reinette Chatre [this message]
2022-09-27 8:55 ` tan.shaopeng
2022-09-14 1:51 ` [PATCH 2/5] selftests/resctrl: Clear unused common codes called by CAT/MBA tests Shaopeng Tan
2022-09-22 17:44 ` Reinette Chatre
2022-09-27 9:01 ` tan.shaopeng
2022-09-14 1:51 ` [PATCH 3/5] selftests/resctrl: Remove duplicate codes that clear each test result file Shaopeng Tan
2022-09-22 17:46 ` Reinette Chatre
2022-09-27 9:01 ` tan.shaopeng
2022-09-28 15:48 ` Reinette Chatre
2022-09-29 5:28 ` tan.shaopeng
2022-09-29 15:28 ` Reinette Chatre
2022-09-14 1:51 ` [PATCH 4/5] selftests/resctrl: Kill the child process before exiting the parent process if an exception occurs Shaopeng Tan
2022-09-22 17:47 ` Reinette Chatre
2022-09-27 9:02 ` tan.shaopeng
2022-09-14 1:51 ` [PATCH 5/5] selftests/resctrl: Flush stdout file buffer before executing fork() Shaopeng Tan
2022-09-22 17:52 ` Reinette Chatre
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=97522844-0b19-fcfa-dd39-c2c2c9ca37ca@intel.com \
--to=reinette.chatre@intel.com \
--cc=fenghua.yu@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=shuah@kernel.org \
--cc=tan.shaopeng@jp.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox