From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 51AF6C04E69 for ; Thu, 3 Aug 2023 08:16:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232799AbjHCIQJ (ORCPT ); Thu, 3 Aug 2023 04:16:09 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41540 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231343AbjHCIPv (ORCPT ); Thu, 3 Aug 2023 04:15:51 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1D6825B9D for ; Thu, 3 Aug 2023 01:07:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1691050040; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=jthayd5ui56Fpxqb9t3oQzEYmi7UMCMbE1ASe7GtkgY=; b=LMe/BuKCSYiuwFscQ8KkvFfptCLN8CpE5q8mj/kq6wro8u8v9bbBCzTfw4S4VTTe+PaTHf 2mkrmuQtHInwM8D0wod7j+POP/007BA3wwpt+hXCBd/DYHZg+ynxHDodMZz5B+jaUiw5T5 NXc8i7T6dxiwmpTqVw1lUX+MI8CDIEc= Received: from mail-qk1-f200.google.com (mail-qk1-f200.google.com [209.85.222.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-580-CMlPuktwPsuY8-D7H6rkNQ-1; Thu, 03 Aug 2023 04:07:18 -0400 X-MC-Unique: CMlPuktwPsuY8-D7H6rkNQ-1 Received: by mail-qk1-f200.google.com with SMTP id af79cd13be357-76cd4e1628eso14792085a.0 for ; Thu, 03 Aug 2023 01:07:18 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691050038; x=1691654838; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=jthayd5ui56Fpxqb9t3oQzEYmi7UMCMbE1ASe7GtkgY=; b=hFA0BEiUmX45Gkp8kFmpmugzf+8YhP7ATvDU0MiLbiFojVGtF3WP/7EpOg7cJTvVCU ut6y8KfgER5t/D+DKAnxMwjuweLIuDnSVu3aroczQSBGuyTTAN5KPRJTpaZ3jSXPBQuf IkSS0Rs3gyGAcVBskzIjHm4ehX0zkWMS/jgE+A4tcbFPQPiOejDu+b98T7qUcUrLrDRW /XRogdDlwi8f1XfKALdjqkC3mGMUJ4UwRNl+rkXbxV6UEXCc0+u/b1MTDVHZun5C8f2m 5Jyse2XCqGHxG8bM/J2MdezJeu1Gim8EGSORySxHbfk6LL1TFG9rdMdA7pSHIID5I/Dp fnbw== X-Gm-Message-State: ABy/qLbqvi1Q58sC1tr756nFtRt4Ybqenz5mSWXyZvf9PevHk5RpELY+ Kl8/OplXTMoYu46AloOAPHE2pYFWO3l/GL10JzWMxYcPx0q0wuZ57tE38K4OiaA8w6TKoMYVjUQ O3Vj1H2xprqE4IPM2U9SegAIUOxIh X-Received: by 2002:a05:620a:4402:b0:767:e5ae:85cf with SMTP id v2-20020a05620a440200b00767e5ae85cfmr20789787qkp.5.1691050038476; Thu, 03 Aug 2023 01:07:18 -0700 (PDT) X-Google-Smtp-Source: APBJJlFViPhNhnNp9SBe9EOo0iTO871MZ55RotErSLZwYTVfkCRo/1er0GobsFumxfa1ZKbpiUUQug== X-Received: by 2002:a05:620a:4402:b0:767:e5ae:85cf with SMTP id v2-20020a05620a440200b00767e5ae85cfmr20789778qkp.5.1691050038153; Thu, 03 Aug 2023 01:07:18 -0700 (PDT) Received: from gerbillo.redhat.com (146-241-226-226.dyn.eolo.it. [146.241.226.226]) by smtp.gmail.com with ESMTPSA id d8-20020a37c408000000b00767b4fa5d96sm5645884qki.27.2023.08.03.01.07.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 03 Aug 2023 01:07:17 -0700 (PDT) Message-ID: <9916825da00d375a33abdcb0aa773c5520a307e1.camel@redhat.com> Subject: Re: [net-next 2/2] selftests: seg6: add selftest for NEXT-C-SID flavor in SRv6 End.X behavior From: Paolo Abeni To: Andrea Mayer , "David S. Miller" , Eric Dumazet , Jakub Kicinski , David Ahern , Shuah Khan , linux-kernel@vger.kernel.org, netdev@vger.kernel.org, linux-kselftest@vger.kernel.org Cc: Stefano Salsano , Paolo Lungaroni , Ahmed Abdelsalam , Hangbin Liu Date: Thu, 03 Aug 2023 10:07:14 +0200 In-Reply-To: <20230731175117.17376-3-andrea.mayer@uniroma2.it> References: <20230731175117.17376-1-andrea.mayer@uniroma2.it> <20230731175117.17376-3-andrea.mayer@uniroma2.it> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.46.4 (3.46.4-1.fc37) MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-kselftest@vger.kernel.org On Mon, 2023-07-31 at 19:51 +0200, Andrea Mayer wrote: > From: Paolo Lungaroni >=20 > This selftest is designed for testing the support of NEXT-C-SID flavor > for SRv6 End.X behavior. It instantiates a virtual network composed of > several nodes: hosts and SRv6 routers. Each node is realized using a > network namespace that is properly interconnected to others through veth > pairs, according to the topology depicted in the selftest script file. > The test considers SRv6 routers implementing IPv4/IPv6 L3 VPNs leveraged > by hosts for communicating with each other. Such routers i) apply > different SRv6 Policies to the traffic received from connected hosts, > considering the IPv4 or IPv6 protocols; ii) use the NEXT-C-SID > compression mechanism for encoding several SRv6 segments within a single > 128-bit SID address, referred to as a Compressed SID (C-SID) container. >=20 > The NEXT-C-SID is provided as a "flavor" of the SRv6 End.X behavior, > enabling it to properly process the C-SID containers. The correct > execution of the enabled NEXT-C-SID SRv6 End.X behavior is verified > through reachability tests carried out between hosts belonging to the > same VPN. >=20 > Signed-off-by: Andrea Mayer > Signed-off-by: Paolo Lungaroni The patches LGTM, but there is a minor issues WRT the tag area. Since this patch contains a From: Paolo Lungaroni tag, Paolo's sob should come first. According to the the newly created shell script comments, it looks like the patch as been co developed by both Paolo abd Andrea. In that case the correct tag sequence would be: SoB Paolo Co-devel Andrea SoB Andrea Since the above is relevant for correct patch authorship attribution I suggest to address that in a new revision. BTW, I a really appreciate the descriptive-but-not-too-verbose commit message! Thanks, Paolo