From: Matthieu Baerts <matttbe@kernel.org>
To: Minxi Hou <houminxi@gmail.com>
Cc: netdev@vger.kernel.org, Aaron Conole <aconole@redhat.com>,
Eelco Chaudron <echaudro@redhat.com>,
Ilya Maximets <i.maximets@ovn.org>,
Eric Dumazet <edumazet@kernel.org>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Simon Horman <horms@kernel.org>, Shuah Khan <shuah@kernel.org>,
linux-kselftest@vger.kernel.org
Subject: Re: [PATCH net v4 0/2] net: openvswitch: fix a feature leak on a failed change
Date: Mon, 16 Nov 2026 12:58:01 +0100 [thread overview]
Message-ID: <998d522f-e61d-420f-9834-6bdcbaab1361@kernel.org> (raw)
In-Reply-To: <20261115163134.3202677-1-houminxi@gmail.com>
Hi Minxi,
On 15/11/2026 17:31, Minxi Hou wrote:
> The datapath records the user features before it applies the change, so
> a request that fails leaves it claiming a bit whose reference count was
> never taken. The first patch records the features last. The second adds a
> selftest that drives the failing request and reads back what the datapath
> reports.
>
> v4:
> - Rebased onto current main.
> - The skip message is one printf again. Splitting it made shellcheck
> report SC2182 and dropped a word and the newline from the output.
> - The new tests say why they failed on stdout. info() writes debug.log
> and a failing run deletes that file, so CI showed a FAIL with no reason.
> - A datapath that cannot be read is reported as that instead of as a
> feature mismatch.
> - The outdated add-dp request is checked instead of discarded.
> - The errno numbers come from python rather than from a literal, and a
> lookup that cannot answer says so rather than comparing against an
> empty string.
Thank you for the new version, but I suspect this series caused troubles
on the CI side: it looks like openvswitch.sh hangs/times out after all
subtests pass.
# TEST: psample [START]
# TEST: psample: Sampling packets with psample [ OK ]
=> then nothing for 10 minutes, instead of:
ok 1 selftests: net/openvswitch: openvswitch.sh
How did you validate this series? Note that the Netdev CI, for this
specific case, combines 'config' files from net, net/af_unix
net/openvswitch:
tools/testing/selftests/net/config
tools/testing/selftests/net/af_unix/config
tools/testing/selftests/net/openvswitch/config
Cheers,
Matt
next prev parent reply other threads:[~2026-11-16 11:58 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-15 16:31 [PATCH net v4 0/2] net: openvswitch: fix a feature leak on a failed change Minxi Hou
2026-11-15 16:31 ` [PATCH net v4 1/2] net: openvswitch: do not record user features when the change fails Minxi Hou
2026-11-16 16:33 ` netdev-bot+sashiko
2026-11-15 16:31 ` [PATCH net v4 2/2] selftests/net/openvswitch: check that a failed set keeps the features Minxi Hou
2026-11-16 16:33 ` netdev-bot+sashiko
2026-11-15 20:12 ` [PATCH net v4 0/2] net: openvswitch: fix a feature leak on a failed change netdev-bot+sinfo
2026-11-16 1:32 ` Minxi Hou
2026-11-16 11:58 ` Matthieu Baerts [this message]
2026-11-16 12:32 ` Minxi Hou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=998d522f-e61d-420f-9834-6bdcbaab1361@kernel.org \
--to=matttbe@kernel.org \
--cc=aconole@redhat.com \
--cc=echaudro@redhat.com \
--cc=edumazet@kernel.org \
--cc=horms@kernel.org \
--cc=houminxi@gmail.com \
--cc=i.maximets@ovn.org \
--cc=kuba@kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox