From: Yi Liu <yi.l.liu@intel.com>
To: "Tian, Kevin" <kevin.tian@intel.com>,
"joro@8bytes.org" <joro@8bytes.org>,
"alex.williamson@redhat.com" <alex.williamson@redhat.com>,
"jgg@nvidia.com" <jgg@nvidia.com>,
"robin.murphy@arm.com" <robin.murphy@arm.com>,
"baolu.lu@linux.intel.com" <baolu.lu@linux.intel.com>
Cc: "cohuck@redhat.com" <cohuck@redhat.com>,
"eric.auger@redhat.com" <eric.auger@redhat.com>,
"nicolinc@nvidia.com" <nicolinc@nvidia.com>,
"kvm@vger.kernel.org" <kvm@vger.kernel.org>,
"mjrosato@linux.ibm.com" <mjrosato@linux.ibm.com>,
"chao.p.peng@linux.intel.com" <chao.p.peng@linux.intel.com>,
"yi.y.sun@linux.intel.com" <yi.y.sun@linux.intel.com>,
"peterx@redhat.com" <peterx@redhat.com>,
"jasowang@redhat.com" <jasowang@redhat.com>,
"shameerali.kolothum.thodi@huawei.com"
<shameerali.kolothum.thodi@huawei.com>,
"lulu@redhat.com" <lulu@redhat.com>,
"suravee.suthikulpanit@amd.com" <suravee.suthikulpanit@amd.com>,
"iommu@lists.linux.dev" <iommu@lists.linux.dev>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-kselftest@vger.kernel.org"
<linux-kselftest@vger.kernel.org>,
"Duan, Zhenzhong" <zhenzhong.duan@intel.com>,
"Martins, Joao" <joao.m.martins@oracle.com>
Subject: Re: [PATCH v5 09/11] iommu/vt-d: Add iotlb flush for nested domain
Date: Fri, 13 Oct 2023 20:56:52 +0800 [thread overview]
Message-ID: <9a482d0b-e2f3-116a-1feb-d0b49bc21554@intel.com> (raw)
In-Reply-To: <BN9PR11MB52769D0ED40EB2D3D8FB56658CC2A@BN9PR11MB5276.namprd11.prod.outlook.com>
On 2023/9/27 14:53, Tian, Kevin wrote:
>> From: Liu, Yi L <yi.l.liu@intel.com>
>> Sent: Thursday, September 21, 2023 3:54 PM
>> +
>> + /* REVISIT:
>> + * VT-d has defined ITE, ICE, IQE for invalidation failure per hardware,
>> + * but no error code yet, so just set the error code to be 0.
>> + */
>> + *cerror_idx = 0;
>> +
>
> Is it "hardware doesn't provide error code now though it's defined in
> spec" or "intel-iommu driver doesn't retrieve the error code though
> it's provided by the hardware"?
I didn't see vtd spec defines error code for cache invalidation. :(
>
> Is there guarantee that '0' isn't used for an existing error code or
> won't be used for any new error code later?
may need to check it.
--
Regards,
Yi Liu
next prev parent reply other threads:[~2023-10-13 12:55 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-21 7:54 [PATCH v5 00/11] Add Intel VT-d nested translation Yi Liu
2023-09-21 7:54 ` [PATCH v5 01/11] iommufd: Add data structure for Intel VT-d stage-1 domain allocation Yi Liu
2023-09-27 6:18 ` Tian, Kevin
2023-09-21 7:54 ` [PATCH v5 02/11] iommu/vt-d: Extend dmar_domain to support nested domain Yi Liu
2023-09-21 7:54 ` [PATCH v5 03/11] iommu/vt-d: Add helper for nested domain allocation Yi Liu
2023-09-21 7:54 ` [PATCH v5 04/11] iommu/vt-d: Add helper to setup pasid nested translation Yi Liu
2023-09-27 6:37 ` Tian, Kevin
2023-10-13 12:40 ` Yi Liu
2023-10-13 12:48 ` Baolu Lu
2023-10-16 8:30 ` Tian, Kevin
2023-09-21 7:54 ` [PATCH v5 05/11] iommu/vt-d: Make domain attach helpers to be extern Yi Liu
2023-09-21 7:54 ` [PATCH v5 06/11] iommu/vt-d: Set the nested domain to a device Yi Liu
2023-09-27 6:40 ` Tian, Kevin
2023-09-21 7:54 ` [PATCH v5 07/11] iommufd: Add data structure for Intel VT-d stage-1 cache invalidation Yi Liu
2023-09-21 13:33 ` Baolu Lu
2023-09-25 6:56 ` Yi Liu
2023-09-27 6:46 ` Tian, Kevin
2023-09-21 7:54 ` [PATCH v5 08/11] iommu/vt-d: Make iotlb flush helpers to be extern Yi Liu
2023-09-21 7:54 ` [PATCH v5 09/11] iommu/vt-d: Add iotlb flush for nested domain Yi Liu
2023-09-27 6:53 ` Tian, Kevin
2023-10-13 12:56 ` Yi Liu [this message]
2023-09-21 7:54 ` [PATCH v5 10/11] iommu/vt-d: Add nested domain allocation Yi Liu
2023-09-27 6:56 ` Tian, Kevin
2023-10-13 13:41 ` Yi Liu
2023-09-21 7:54 ` [PATCH v5 11/11] iommu/vt-d: Disallow read-only mappings to nest parent domain Yi Liu
2023-09-27 7:04 ` Tian, Kevin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9a482d0b-e2f3-116a-1feb-d0b49bc21554@intel.com \
--to=yi.l.liu@intel.com \
--cc=alex.williamson@redhat.com \
--cc=baolu.lu@linux.intel.com \
--cc=chao.p.peng@linux.intel.com \
--cc=cohuck@redhat.com \
--cc=eric.auger@redhat.com \
--cc=iommu@lists.linux.dev \
--cc=jasowang@redhat.com \
--cc=jgg@nvidia.com \
--cc=joao.m.martins@oracle.com \
--cc=joro@8bytes.org \
--cc=kevin.tian@intel.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=lulu@redhat.com \
--cc=mjrosato@linux.ibm.com \
--cc=nicolinc@nvidia.com \
--cc=peterx@redhat.com \
--cc=robin.murphy@arm.com \
--cc=shameerali.kolothum.thodi@huawei.com \
--cc=suravee.suthikulpanit@amd.com \
--cc=yi.y.sun@linux.intel.com \
--cc=zhenzhong.duan@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox