Linux Kernel Selftest development
 help / color / mirror / Atom feed
From: Gerd Bayer <gbayer@linux.ibm.com>
To: Shuah Khan <skhan@linuxfoundation.org>,
	Xiang Chen <chenxiang66@hisilicon.com>,
	Shuah Khan <shuah@kernel.org>
Cc: Joerg Roedel <joro@8bytes.org>,
	iommu@lists.linux.dev, linux-kselftest@vger.kernel.org,
	Niklas Schnelle <schnelle@linux.ibm.com>
Subject: Re: [PATCH] selftests:dma: Fix compile error in user-space tool
Date: Fri, 13 Jan 2023 17:52:38 +0100	[thread overview]
Message-ID: <9d824f0b3642d3b3e8e92fe7a34522f334b003f7.camel@linux.ibm.com> (raw)
In-Reply-To: <a01b5643-3373-d5a0-a3d7-4fa845725dbd@linuxfoundation.org>

On Thu, 2023-01-12 at 13:36 -0700, Shuah Khan wrote:
> On 1/9/23 11:07, Gerd Bayer wrote:
> > With this change dma_map_benchmark compiles with just the obvious
> > warning
> > about uapi usage on ARCH=x86, arm64, and s390 and runs on
> > ARCH=s390.
> 
> On Linux 6.2-rc3, dma_map_benchmark compiles just fine. You do
> have to do "make headers_install" first as kselftest depends
> on headers being installed in the repo.
> 
> Please let me know if you are seeing compile problems even after
> installing headers.
> 
> thanks,
> -- Shuah

Hi Shuah,

thank you for this clarification. Once I run "make headers_install"
before attempting to build the dma_benchmark_test executable with
  make -C tools/testing/selftests/ TARGETS="dma"
everything works out nicely - even w/o my patch.

I have to apologize for creating this fuzz. I was not aware that one of
the dependencies for "make kselftest" was "make headers_install", since
I was going straight for the interactive "dma_benchmark_test" control
tool of the test that is implemented in kernel/dma/benchmark_test.c.
I didn't intend to run the full "make kselftest" suite, primarily since
I have distinct test and build systems - most often building cross-
arch, even.

So please, disregard the PATCH.

Thank you,
Gerd



  reply	other threads:[~2023-01-13 16:55 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-09 18:07 [PATCH] selftests:dma: Fix compile error in user-space tool Gerd Bayer
2023-01-12 20:36 ` Shuah Khan
2023-01-13 16:52   ` Gerd Bayer [this message]
2023-01-13 18:15     ` Shuah Khan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9d824f0b3642d3b3e8e92fe7a34522f334b003f7.camel@linux.ibm.com \
    --to=gbayer@linux.ibm.com \
    --cc=chenxiang66@hisilicon.com \
    --cc=iommu@lists.linux.dev \
    --cc=joro@8bytes.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=schnelle@linux.ibm.com \
    --cc=shuah@kernel.org \
    --cc=skhan@linuxfoundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox