From: Shuah Khan <skhan@linuxfoundation.org>
To: Karan Sanghavi <karansanghvi98@gmail.com>,
Jamal Hadi Salim <jhs@mojatatu.com>,
Cong Wang <xiyou.wangcong@gmail.com>,
Jiri Pirko <jiri@resnulli.us>, Shuah Khan <shuah@kernel.org>
Cc: netdev@vger.kernel.org, linux-kselftest@vger.kernel.org,
linux-kernel@vger.kernel.org, Anup <anupnewsmail@gmail.com>,
Simon Horman <horms@kernel.org>,
Shuah Khan <skhan@linuxfoundation.org>
Subject: Re: [PATCH] selftests: tc-testing: Fixed typo error
Date: Mon, 21 Oct 2024 14:20:32 -0600 [thread overview]
Message-ID: <9e7df8d1-b7d9-41be-a65d-cfcd81e7e24a@linuxfoundation.org> (raw)
In-Reply-To: <20241019-multiple_spell_error-v1-1-facff43b5610@gmail.com>
On 10/19/24 05:52, Karan Sanghavi wrote:
> Corrected the multiple and different typo errors in json files
>
It should say "Correct or Fix" - Same comment in short log
"Fix" instead of "Fixed"
Do refer to commit for the subsystems and file to get an idea
on the convention.
> - "diffferent" is corrected to "different".
> - "muliple" and "miltiple" is corrected to "multiple".
>
> Signed-off-by: Karan Sanghavi <karansanghvi98@gmail.com>
> ---
> tools/testing/selftests/tc-testing/tc-tests/filters/basic.json | 6 +++---
> tools/testing/selftests/tc-testing/tc-tests/filters/cgroup.json | 6 +++---
> tools/testing/selftests/tc-testing/tc-tests/filters/flow.json | 2 +-
> tools/testing/selftests/tc-testing/tc-tests/filters/route.json | 2 +-
> 4 files changed, 8 insertions(+), 8 deletions(-)
>
Otherwise the changes look good to me. With the above change
to short and commit logs:
Reviewed-by: Shuah Khan <skhan@linuxfoundation.org>
thanks,
-- Shuah
next prev parent reply other threads:[~2024-10-21 20:20 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-19 11:52 [PATCH] selftests: tc-testing: Fixed typo error Karan Sanghavi
2024-10-19 18:17 ` Simon Horman
2024-10-21 20:20 ` Shuah Khan [this message]
-- strict thread matches above, loose matches on Subject: below --
2024-07-31 22:07 [PATCH] selftests: tc-testing: Fixed Typo error Victor Nogueira
2024-07-31 18:09 Karan Sanghavi
2024-07-31 18:07 Karan Sanghavi
2024-08-01 18:24 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9e7df8d1-b7d9-41be-a65d-cfcd81e7e24a@linuxfoundation.org \
--to=skhan@linuxfoundation.org \
--cc=anupnewsmail@gmail.com \
--cc=horms@kernel.org \
--cc=jhs@mojatatu.com \
--cc=jiri@resnulli.us \
--cc=karansanghvi98@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=shuah@kernel.org \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox