Re: [PATCH 5/9] drm/xe: Update parameter generator to new signature

[David Gow <davidgow@google.com>]

[-- Attachment #1: Type: text/plain, Size: 1362 bytes --]

On Wed, 30 Jul 2025 at 03:37, Marie Zhussupova <marievic@google.com> wrote:
>
> This patch modifies `xe_pci_live_device_gen_param`
> in xe_pci.c to accept an additional `struct kunit *test`
> argument.
>
> Signed-off-by: Marie Zhussupova <marievic@google.com>
> ---


This is a pretty straightforward fix after patch 3. xe folks, would
you prefer this kept as a separate patch, or squashed into patch 3
(which changed the function signature)?

Either way,
Reviewed-by: David Gow <davidgow@google.com>


-- David


>  drivers/gpu/drm/xe/tests/xe_pci.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/xe/tests/xe_pci.c b/drivers/gpu/drm/xe/tests/xe_pci.c
> index 1d3e2e50c355..62c016e84227 100644
> --- a/drivers/gpu/drm/xe/tests/xe_pci.c
> +++ b/drivers/gpu/drm/xe/tests/xe_pci.c
> @@ -129,7 +129,7 @@ EXPORT_SYMBOL_IF_KUNIT(xe_pci_fake_device_init);
>   * Return: pointer to the next &struct xe_device ready to be used as a parameter
>   *         or NULL if there are no more Xe devices on the system.
>   */
> -const void *xe_pci_live_device_gen_param(const void *prev, char *desc)
> +const void *xe_pci_live_device_gen_param(struct kunit *test, const void *prev, char *desc)
>  {
>         const struct xe_device *xe = prev;
>         struct device *dev = xe ? xe->drm.dev : NULL;
> --
> 2.50.1.552.g942d659e1b-goog
>

[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 5281 bytes --]