From: David Gow <davidgow@google.com>
To: Arthur Grillo <arthurgrillo@riseup.net>
Cc: Brendan Higgins <brendan.higgins@linux.dev>,
Jonathan Corbet <corbet@lwn.net>,
linux-kselftest@vger.kernel.org, kunit-dev@googlegroups.com,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] Documentation: KUnit: Update the instructions on how to test static functions
Date: Fri, 12 Jan 2024 12:34:25 +0800 [thread overview]
Message-ID: <CABVgOSnxTwZgkJeAdpyVAt5RFtH0DEmtVsUiBLdPFGBeQAUj6A@mail.gmail.com> (raw)
In-Reply-To: <20240110-kunit-doc-export-v3-1-9b4221763401@riseup.net>
[-- Attachment #1: Type: text/plain, Size: 822 bytes --]
On Thu, 11 Jan 2024 at 01:39, Arthur Grillo <arthurgrillo@riseup.net> wrote:
>
> Now that we have the VISIBLE_IF_KUNIT and EXPORT_SYMBOL_IF_KUNIT macros,
> update the instructions to recommend this way of testing static
> functions.
>
> Signed-off-by: Arthur Grillo <arthurgrillo@riseup.net>
> ---
> Changes in v3:
> - Maintain the old '#include' way
> - Link to v2: https://lore.kernel.org/r/20240108-kunit-doc-export-v2-1-8f2dd3395fed@riseup.net
>
> Changes in v2:
> - Fix #if condition
> - Link to v1: https://lore.kernel.org/r/20240108-kunit-doc-export-v1-1-119368df0d96@riseup.net
> ---
This looks good, thanks!
Reviewed-by: David Gow <davidgow@google.com>
We may try to add some more reference documentation for the
visibility.h header later on, but this example is probably more useful
anyway.
Cheers,
-- David
[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4014 bytes --]
prev parent reply other threads:[~2024-01-12 4:34 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-10 17:39 [PATCH v3] Documentation: KUnit: Update the instructions on how to test static functions Arthur Grillo
2024-01-12 4:34 ` David Gow [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CABVgOSnxTwZgkJeAdpyVAt5RFtH0DEmtVsUiBLdPFGBeQAUj6A@mail.gmail.com \
--to=davidgow@google.com \
--cc=arthurgrillo@riseup.net \
--cc=brendan.higgins@linux.dev \
--cc=corbet@lwn.net \
--cc=kunit-dev@googlegroups.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).