From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f48.google.com (mail-wm1-f48.google.com [209.85.128.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EA4192D94AA for ; Fri, 12 Dec 2025 22:42:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=pass smtp.client-ip=209.85.128.48 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765579372; cv=pass; b=K3NEgnOwEaZyyNB0RLhPRaffknQaQC/1jdV5CcCAk2UN8/x9vueDsqZVX6H0+AMWut6q6VOyTl7+PJnsAhgonAN5x34DdIkyMBJoQT3bvgstlY3ChQQ4mLX53oyCiV2sU4e2Bj5ezXhLjkYn71cVfzO0O/bAi6Yt8JYUtZYGVpM= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765579372; c=relaxed/simple; bh=YOqs0y1dcE5aW9PtDdEhj4UaUFEQubxbJwDSGVsK6mc=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=J4BjM46X0GkKQ45jbyzTYeSIl0icZYFsHRWUm3lsB17I/neWKlRMDLz+EL2DBEX4oUUJNiUKwbto44cTn0CM1MYqIQgRV8wXwmYVR/+6ySfPyVvnE/8lz4zoSaAhtJPl2UYfqjMGsrBlQdi8OKE1Ih+n96HeZq87nnjSTCg2YC8= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=jkFOBrfa; arc=pass smtp.client-ip=209.85.128.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="jkFOBrfa" Received: by mail-wm1-f48.google.com with SMTP id 5b1f17b1804b1-4779e2ac121so198345e9.1 for ; Fri, 12 Dec 2025 14:42:50 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1765579369; cv=none; d=google.com; s=arc-20240605; b=gQurwLttN/GPzbT5WXN319qqNXqS3RiPHFZLuZr8snbslW0toBA7hJV2toj0wGZxIH wRGpCwsW+B5t1u5Gca2M58cbXTPopb2IwoKi2rRsUPv9Q311qP/H4GTDhg9Rg32Q+K3D IvNsUE9q5dlKuSFqUgxlRTpmbQECti0GAVjrv0+126o+L6xyVVW6uTMHtD38XXCFgWuw TeqBmVjnf7s/f7VZZSVg3SSbFDqvqQs5bvlggoEKegoMFJU5UcHCYp45NO5Yrq0s2Lck iL+v6lNDTJof6TbLMyTvTD+53/e+LubSt7nhl6vOCwLj0TjMyqcUc2ca2lJNU2/K0j+q PmhA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=GCLPUx88ZdHJmS22/LgzBzk06kvYjDGU5Iph4HFcUyk=; fh=RcD4Ne8YTNW23v1er3cYUrjKMMT5zvX68Yoav7piqHQ=; b=NR+9cVNWW3PtPDJ2l+0kodGXGPfg5d1jnN1fxF4y5Jsiak+YED36R+m7AmOpUy9Asq xKQfqxUjvtbmQD6nqw8+GxUmAkFpBpjTy8wQzwvaTQcFdc4a3Ck+NdzU5o9BBeSfOZps fGOVWN6SLRlfiG5OUXu39+dMbj9ZNDX0crlQFzIg0DGwclzrJn2U0eYSrxJGbOjz9xEQ hDWnMpjLVUmjsMHD2KFw8gjZyge9A1gQjbO3lSU94dkivnfnOErUjDrCmKledhvY06H1 X8nkx+1kqp8TBpaCMWzAhBmUJQkLyX62vUqeBlIC4Q6ZhOMxf0D1udrcinWyIFN16pTo Im5A==; darn=vger.kernel.org ARC-Authentication-Results: i=1; mx.google.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1765579369; x=1766184169; darn=vger.kernel.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=GCLPUx88ZdHJmS22/LgzBzk06kvYjDGU5Iph4HFcUyk=; b=jkFOBrfaWg1+RgIZ0WUBN0/QPp9sk4JmqkjaQxaMY/ejTCHZEqksiF2kzdhI4g2VJo z0RCtjTBmj4DX/DhHF43Aty4wnaJ+pWXgLfKjU9wd8Wv/rMcbRkhWdP6E8cJQJ8VDpa3 PtfasN95ZbEnv0thT4osg8XBfFMLttGdd+E9E9g1ecFwha6FXiOcW8pc+Yvx4vyCNu+I Qegw3dmwQZe7p/Z/+GoXgN9N+FOSzJgfdq8Gaq/XTsiPWVsv+D2/xU5TRXYAwr8dT2fl L0eQ7updJuBkfrtM+0aArNNpJG88nuZ4QG2iKCXhXcT9zcF275IG1KRofKyRkcoKB8Zb BCVw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1765579369; x=1766184169; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=GCLPUx88ZdHJmS22/LgzBzk06kvYjDGU5Iph4HFcUyk=; b=S3kXxfwGL8kNOc6vO+/nrZm1wpLlm6B/cRuupDusnH0w5lHOYaCTQ84sC+cyj8p+pa JnmIeMkhH2sHcByueA9rvyoT3wqV5BFYJGxahQdedT9q8+/xvcU1Ug/04j7b1LrRK4un tFLhxFqK5txywm8AMQTwAL7XtmeiU+MwweXfsxGJzDBnDe/cwQ1tCUuwefFoL2BqV1Cq wJo7gIdgy4xpRL19IXe9Wy9Ys9smWNp019maPJMTGwJsF6CTJOmN/t7jWr8fMSR5L5Ef 01tP77dpvc4uS4w30GvLG8UFMRlvMXLjMTSaAiiweeKlxg54ug6qZ0xp0ja3sVIty80u M/yw== X-Forwarded-Encrypted: i=1; AJvYcCVYFVRSE9RALoqRAYiWCPahBeEGUAIwieCilaH9X08b32TA12acMi4fHszIeVJL1vO6vLF37twgFXcI6zIWS5M=@vger.kernel.org X-Gm-Message-State: AOJu0YyIDax0yQu9D+Vpm0B1jUKW/81g5UYx82fjd4VfoxfCqsDTcfhv XZ3EP9aNfP2iw81A0ypAUnvFX3BdIVWCRV4jz+fxNssCZbP1wq7YgzgBpk1SZzZH3OrwcUmxh9u C9N3VfWI75mcoTQ1gM2D9uqdS591E0mHnKti6SGrX X-Gm-Gg: AY/fxX6LmQGPxwzDTUy6Nk3SSERxCliAIKoEPQx06Tgmlr4dgau6PBeEI/OXo6e8zYA 1FY8OYqflmmYxqNwQGa8DttlwwDoqzIssdsb2P1L0duqwbcoFQMeL64lnXSq544oXYaYjep9Deg yFta9qS8/LXKAygk3tTiGzV87pocl3mYnv7kScaQ6bqGRpRZwzBRuzmRrTCgJmPrgmZVVWG+xSH Yg/Qgl6uXxkhVxt91uVv+ap8Ek4gtP5qDMuzehiMMJ5XweH7yOirIctb71qHIrG31KAE8SJLg1W REFJcaeNDLeMetA6nv8K/zOGh22w X-Google-Smtp-Source: AGHT+IGycUDLgfiYo6g1zTqU/jgYJfkyvEbX43ygSbXNWZeJGMb236iTpZ88xPMSD0uFM0/wQUo7NV0Ahf4F4PzTuS8= X-Received: by 2002:a05:600c:83c4:b0:477:86fd:fb18 with SMTP id 5b1f17b1804b1-47a94869ebbmr337505e9.8.1765579369059; Fri, 12 Dec 2025 14:42:49 -0800 (PST) Precedence: bulk X-Mailing-List: linux-kselftest@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20251013185903.1372553-1-jiaqiyan@google.com> <20251013185903.1372553-3-jiaqiyan@google.com> <3061f5f8-cef0-b7b1-c4de-f2ceea29af9a@huawei.com> In-Reply-To: From: Jiaqi Yan Date: Fri, 12 Dec 2025 14:42:37 -0800 X-Gm-Features: AQt7F2rl2f5bneq6f6crNhZuIfA-M_NY1_crL-5oW0NtvHoqkZtXMaIozb_07o8 Message-ID: Subject: Re: [PATCH v4 2/3] KVM: selftests: Test for KVM_EXIT_ARM_SEA To: Zenghui Yu Cc: maz@kernel.org, oliver.upton@linux.dev, duenwen@google.com, rananta@google.com, jthoughton@google.com, vsethi@nvidia.com, jgg@nvidia.com, joey.gouly@arm.com, suzuki.poulose@arm.com, catalin.marinas@arm.com, will@kernel.org, pbonzini@redhat.com, corbet@lwn.net, shuah@kernel.org, kvm@vger.kernel.org, kvmarm@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, linux-kselftest@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Fri, Dec 12, 2025 at 1:22=E2=80=AFAM Zenghui Yu w= rote: > > On 2025/12/12 9:53, Jiaqi Yan wrote: > > On Thu, Dec 11, 2025 at 5:02=E2=80=AFAM Zenghui Yu wrote: > > > > > > I can also hit this ASSERT with: > > > > > > Random seed: 0x6b8b4567 > > > # Mapped 0x40000 pages: gva=3D0x80000000 to gpa=3D0xff80000000 > > > # Before EINJect: data=3D0xbaadcafe > > > # EINJ_GVA=3D0x81234bad, einj_gpa=3D0xff81234bad, einj_hva=3D0xffff41= 234bad, > > > einj_hpa=3D0x2841234bad > > > # echo 0x10 > /sys/kernel/debug/apei/einj/error_type - done > > > # echo 0x2 > /sys/kernel/debug/apei/einj/flags - done > > > # echo 0x2841234bad > /sys/kernel/debug/apei/einj/param1 - done > > > # echo 0xffffffffffffffff > /sys/kernel/debug/apei/einj/param2 - done > > > # echo 0x1 > /sys/kernel/debug/apei/einj/notrigger - done > > > # echo 0x1 > /sys/kernel/debug/apei/einj/error_inject - done > > > # Memory UER EINJected > > > # Dump kvm_run info about KVM_EXIT_MMIO > > > # kvm_run.arm_sea: esr=3D0xffff90ba0040, flags=3D0x691000 > > > # kvm_run.arm_sea: gva=3D0x100000008, gpa=3D0 > > > =3D=3D=3D=3D Test Assertion Failure =3D=3D=3D=3D > > > arm64/sea_to_user.c:207: exit_reason =3D=3D (41) > > > pid=3D38023 tid=3D38023 errno=3D4 - Interrupted system call > > > 1 0x0000000000402d1b: run_vm at sea_to_user.c:207 > > > 2 0x0000000000402467: main at sea_to_user.c:330 > > > 3 0x0000ffff9122b03f: ?? ??:0 > > > 4 0x0000ffff9122b117: ?? ??:0 > > > 5 0x00000000004026ef: _start at ??:? > > > Wanted KVM exit reason: 41 (ARM_SEA), got: 6 (MMIO) > > > > > > Not sure what's wrong it.. > > > > Does your test machine have SDEI or SCI enabled for host APEI? Do you > > see any kernel log from "Memory failure:" saying hugetlb page > > recovered, and recovered significant earlier than the KVM exit here. > > It maybe the kernel has already unmapped hugepage in response to SDEI > > or SCI before this test actually consumes memory error, so no SEA is > > actually triggered. > > No kernel log was printed when I saw this failure. Hmm, and even no CPER logged by APEI/GHES? That makes me suspect the error wasn't injected successfully. In that case, I found a bug in sea_to_user.c: GUEST_FAIL is not handled by run_vm and results in unhandled MMIO. Here is a fix I tested on my side, with some other minor fixes. Do you mind trying it? commit b96a92d1006fbe2752ba133eb76b0c45c9c54265 Author: Jiaqi Yan Date: Fri Dec 12 22:27:53 2025 +0000 KVM: selftests: Improve sea_to_user test Several improvments to the test for KVM_EXIT_ARM_SEA: - refactor run_vm to catch GUEST_FAIL, instead of causing confusing kvm exit with unhandled MMIO - sync far_invalid to guest - exit with KSFT_SKIP or KSFT_FAIL when should Change-Id: I8b735de3b669297f0638bea2d32a0b36211f7f5c diff --git a/tools/testing/selftests/kvm/arm64/sea_to_user.c b/tools/testing/selftests/kvm/arm64/sea_to_user.c index 573dd790aeb8e..6fd3cd881b415 100644 --- a/tools/testing/selftests/kvm/arm64/sea_to_user.c +++ b/tools/testing/selftests/kvm/arm64/sea_to_user.c @@ -98,11 +98,15 @@ static void write_einj_entry(const char *einj_path, uint64_t val) static void inject_uer(uint64_t paddr) { - if (access("/sys/firmware/acpi/tables/EINJ", R_OK) =3D=3D -1) - ksft_test_result_skip("EINJ table no available in firmware"= ); + if (access("/sys/firmware/acpi/tables/EINJ", R_OK) =3D=3D -1) { + ksft_test_result_skip("EINJ table not available in firmware= \n"); + exit(KSFT_SKIP); + } - if (access(EINJ_ETYPE, R_OK | W_OK) =3D=3D -1) + if (access(EINJ_ETYPE, R_OK | W_OK) =3D=3D -1) { ksft_test_result_skip("EINJ module probably not loaded?\n")= ; + exit(KSFT_SKIP); + } write_einj_entry(EINJ_ETYPE, ERROR_TYPE_MEMORY_UER); write_einj_entry(EINJ_FLAGS, MASK_MEMORY_UER); @@ -123,12 +127,13 @@ static void sigbus_signal_handler(int sig, siginfo_t *si, void *v) ksft_print_msg("SIGBUS (%d) received, dumping siginfo...\n", sig); ksft_print_msg("si_signo=3D%d, si_errno=3D%d, si_code=3D%d, si_addr= =3D%p\n", si->si_signo, si->si_errno, si->si_code, si->si_addr= ); - if (si->si_code =3D=3D BUS_MCEERR_AR) + if (si->si_code =3D=3D BUS_MCEERR_AR) { ksft_test_result_skip("SEA is claimed by host APEI\n"); - else + exit(KSFT_SKIP); + } else { ksft_test_result_fail("Exit with signal unhandled\n"); - - exit(0); + exit(KSFT_FAIL); + } } static void setup_sigbus_handler(void) @@ -158,7 +163,6 @@ static void expect_sea_handler(struct ex_regs *regs) { u64 esr =3D read_sysreg(esr_el1); u64 far =3D read_sysreg(far_el1); - bool expect_far_invalid =3D far_invalid; GUEST_PRINTF("Handling Guest SEA\n"); GUEST_PRINTF("ESR_EL1=3D%#lx, FAR_EL1=3D%#lx\n", esr, far); @@ -166,7 +170,7 @@ static void expect_sea_handler(struct ex_regs *regs) GUEST_ASSERT_EQ(ESR_ELx_EC(esr), ESR_ELx_EC_DABT_CUR); GUEST_ASSERT_EQ(esr & ESR_ELx_FSC_TYPE, ESR_ELx_FSC_EXTABT); - if (expect_far_invalid) { + if (far_invalid) { GUEST_ASSERT_EQ(esr & ESR_ELx_FnV, ESR_ELx_FnV); GUEST_PRINTF("Guest observed garbage value in FAR\n"); } else { @@ -185,25 +189,19 @@ static void vcpu_inject_sea(struct kvm_vcpu *vcpu) vcpu_events_set(vcpu, &events); } -static void run_vm(struct kvm_vm *vm, struct kvm_vcpu *vcpu) +static void validate_kvm_exit_arm_sea(struct kvm_vm *vm, struct kvm_vcpu *= vcpu) { - struct ucall uc; - bool guest_done =3D false; struct kvm_run *run =3D vcpu->run; u64 esr; - /* Resume the vCPU after error injection to consume the error. */ - vcpu_run(vcpu); + TEST_ASSERT_KVM_EXIT_REASON(vcpu, KVM_EXIT_ARM_SEA); - ksft_print_msg("Dump kvm_run info about KVM_EXIT_%s\n", - exit_reason_str(run->exit_reason)); + ksft_print_msg("Dumping kvm_run as arm_sea:\n"); ksft_print_msg("kvm_run.arm_sea: esr=3D%#llx, flags=3D%#llx\n", run->arm_sea.esr, run->arm_sea.flags); ksft_print_msg("kvm_run.arm_sea: gva=3D%#llx, gpa=3D%#llx\n", run->arm_sea.gva, run->arm_sea.gpa); - TEST_ASSERT_KVM_EXIT_REASON(vcpu, KVM_EXIT_ARM_SEA); - esr =3D run->arm_sea.esr; TEST_ASSERT_EQ(ESR_ELx_EC(esr), ESR_ELx_EC_DABT_LOW); TEST_ASSERT_EQ(esr & ESR_ELx_FSC_TYPE, ESR_ELx_FSC_EXTABT); @@ -211,39 +209,48 @@ static void run_vm(struct kvm_vm *vm, struct kvm_vcpu *vcpu) TEST_ASSERT_EQ((esr & ESR_ELx_INST_SYNDROME), 0); TEST_ASSERT_EQ(esr & ESR_ELx_VNCR, 0); - if (!(esr & ESR_ELx_FnV)) { - ksft_print_msg("Expect gva to match given FnV bit is 0\n"); + far_invalid =3D esr & ESR_ELx_FnV; + sync_global_to_guest(vm, far_invalid); + + if (!far_invalid) { + ksft_print_msg("Expect gva to match\n"); TEST_ASSERT_EQ(run->arm_sea.gva, EINJ_GVA); } if (run->arm_sea.flags & KVM_EXIT_ARM_SEA_FLAG_GPA_VALID) { - ksft_print_msg("Expect gpa to match given KVM_EXIT_ARM_SEA_FLAG_GPA_VALID is set\n"); + ksft_print_msg("Expect gpa to match\n"); TEST_ASSERT_EQ(run->arm_sea.gpa, einj_gpa & PAGE_ADDR_MASK)= ; } +} - far_invalid =3D esr & ESR_ELx_FnV; - - /* Inject a SEA into guest and expect handled in SEA handler. */ - vcpu_inject_sea(vcpu); +static void run_vm(struct kvm_vm *vm, struct kvm_vcpu *vcpu) +{ + struct ucall uc; + bool guest_done =3D false; /* Expect the guest to reach GUEST_DONE gracefully. */ do { vcpu_run(vcpu); - switch (get_ucall(vcpu, &uc)) { - case UCALL_PRINTF: - ksft_print_msg("From guest: %s", uc.buffer); - break; - case UCALL_DONE: - ksft_print_msg("Guest done gracefully!\n"); - guest_done =3D 1; - break; - case UCALL_ABORT: - ksft_print_msg("Guest aborted!\n"); - guest_done =3D 1; - REPORT_GUEST_ASSERT(uc); - break; - default: - TEST_FAIL("Unexpected ucall: %lu\n", uc.cmd); + if (vcpu->run->exit_reason =3D=3D KVM_EXIT_ARM_SEA) { + validate_kvm_exit_arm_sea(vm, vcpu); + vcpu_inject_sea(vcpu); + } else { + switch (get_ucall(vcpu, &uc)) { + case UCALL_PRINTF: + ksft_print_msg("From guest: %s", uc.buffer)= ; + break; + case UCALL_DONE: + ksft_print_msg("Guest done gracefully!\n"); + guest_done =3D 1; + break; + case UCALL_ABORT: + ksft_print_msg("Guest aborted!\n"); + guest_done =3D 1; + REPORT_GUEST_ASSERT(uc); + break; + default: + TEST_FAIL("Unexpected ucall: %lu\n", uc.cmd= ); + } } } while (!guest_done); } > > Thanks, > Zenghui