From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-io1-f52.google.com (mail-io1-f52.google.com [209.85.166.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E55A217C211 for ; Fri, 14 Mar 2025 08:30:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.166.52 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741941049; cv=none; b=iOLMC6QptmQFKD2G+m060AfrCyMYtgC3JiQ+S2rMnZysAfdtMLPAfT9lU6q9lOUF+O2ZlTRkDV7CWcAmHvvKBcn4HQijNi5ek0krFmVgq/xU2rZfwYDl7pcyGjSlLRpDKdW7bMqFxEPsTYkn/4TaJd2K5sAmP1t5PHpEJxLR5k4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741941049; c=relaxed/simple; bh=QEE9AtIrkbix+ZMthuGvxPmRXCfxafMZhXp2Rg+Rq5M=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=dHmHAzQOXyO5dpwP+9Uo32J7iGnnxl9l4uyK/AvR1r5SoPDF5Pa+t2Cv+Ng8wOvTum2x1z6QTxuxUv2kzgs17HTGbp6oZ7UKoF7w2wBv8fSY3qbyokGruBKHcmtmsSxHwJy99EXFnFUvZ82ZUH2gaXKjTr7P/Ip+70RO6LXoucA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=sifive.com; spf=pass smtp.mailfrom=sifive.com; dkim=pass (2048-bit key) header.d=sifive.com header.i=@sifive.com header.b=F/p+60mL; arc=none smtp.client-ip=209.85.166.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=sifive.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=sifive.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=sifive.com header.i=@sifive.com header.b="F/p+60mL" Received: by mail-io1-f52.google.com with SMTP id ca18e2360f4ac-85b40a5120eso53823839f.1 for ; Fri, 14 Mar 2025 01:30:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sifive.com; s=google; t=1741941047; x=1742545847; darn=vger.kernel.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=pVkgjLCnCUI9ioEXp+7869JJX5vgmb7aKbpLKYY91VM=; b=F/p+60mLxUDkKAsEjICKDPs0AyBQ5siTDrZ5nQJIb92JvCk9zOKxNm9TTKAim5Uhb+ yyNjGoDjgefcBBk8KvvQtvEQXrDSftMpy/7zoYBn/Ov+FK1+CGADY5GarYWZ/wpLf0k0 EdZJ1Ma57h+2HKaZvUJdc94eAeuwi8l7Br9k69PvSi8qid4aUe0dhZ5P7d+EkRULOEJD Bvrk8/xxg32228VCbdiD08W/IAka0g4biuaeOZe3PmD2heyVPjoi6TRODs589SlCrurW T537RBI5EIIOtBhTdVGhXr28GdGlhL+DNWu78T4Eq2Vw2B5lL7aqnVc6Me57++xb/CXL b48A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741941047; x=1742545847; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=pVkgjLCnCUI9ioEXp+7869JJX5vgmb7aKbpLKYY91VM=; b=sG9txFfN3TDZrMOS1Oz9DUGkRgrbhnRkNR6CvOgNgQP5BiCostF8OGo8HkmiH4luSH GhArq4v0GCSdFZS7RwWPXeUziUfxqq8cZO8PLD39tbyI5rWlGVndbndaXi755M1jQdxg ctl0WpDUGB5TVKsxPXrVRM8DHl7mHeEZKVS/WMzLHrSrXVCS9xZzRS8PGlDAzfAKGyme LZ/vgUhRugIfN5QEizxwBNXFMxYxULud5gHR16ZpfULC5WfPLiehltAAe+/Ferl41+5A FDaF7soCCUIbnVsI+SpEc+d14MwtgsK25feQ3b1U7/JV2ss4grWeSgiOcJ75akLnHJX2 g0cg== X-Forwarded-Encrypted: i=1; AJvYcCUc7JiL6iXEYLke4aXH+jbiVhC8INc2J3TV0XvTyKfrBUUx54mqdE5zbiIUFJuPNiyV4BwPl7HAMHQQnwNZeV4=@vger.kernel.org X-Gm-Message-State: AOJu0YyG3vkknOZIzBYhLdVpf9gJ1NqWRMM6mVt3l8MNTEIiOioCSS7p Q2b7aND60S45Xtrd0Eqy939Fkl0Mi1J/cTUXKHiFmdh+/m1sxYgMsMu9SI7+YCY5a5/9EYqovvF U+76JuLA5PKLLtaDM+SmABAXRoHBbuqeIfPU43w== X-Gm-Gg: ASbGncsg96dFBN8wF3GWx23Sj9gufKpFVfexnFnKhxl26djI8SsAt//ZrVxUsxxOFzd 1ALi+cKXJ3b4AOm2HdgdKrDpLaDpE3gD4cIjWcaO7/9DBYEsLJWPixYQWmsOwOYw/qV7nfdkNqH 7qh3YtI/Euqp9d27dzMhnRh86wF9U= X-Google-Smtp-Source: AGHT+IFWp0so50j/pj0q80+N5pNVDDJV0PKTkFCKEUgPJqbURfJzftDPMl2yQe8jE+KIcC0bOMvyNNoalps1kuAhEuc= X-Received: by 2002:a05:6602:4c0b:b0:85b:6118:db67 with SMTP id ca18e2360f4ac-85dc47c5578mr150925139f.2.1741941047135; Fri, 14 Mar 2025 01:30:47 -0700 (PDT) Precedence: bulk X-Mailing-List: linux-kselftest@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20250310-v5_user_cfi_series-v11-0-86b36cbfb910@rivosinc.com> <20250310-v5_user_cfi_series-v11-11-86b36cbfb910@rivosinc.com> In-Reply-To: <20250310-v5_user_cfi_series-v11-11-86b36cbfb910@rivosinc.com> From: Zong Li Date: Fri, 14 Mar 2025 16:30:35 +0800 X-Gm-Features: AQ5f1Jru716EmtibEWxuiBHJ0hbbelGrNS70UuKCfZm5CBH2LXMI4b2SkG1AS6M Message-ID: Subject: Re: [PATCH v11 11/27] riscv/shstk: If needed allocate a new shadow stack on clone To: Deepak Gupta Cc: Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Andrew Morton , "Liam R. Howlett" , Vlastimil Babka , Lorenzo Stoakes , Paul Walmsley , Palmer Dabbelt , Albert Ou , Conor Dooley , Rob Herring , Krzysztof Kozlowski , Arnd Bergmann , Christian Brauner , Peter Zijlstra , Oleg Nesterov , Eric Biederman , Kees Cook , Jonathan Corbet , Shuah Khan , Jann Horn , Conor Dooley , linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-riscv@lists.infradead.org, devicetree@vger.kernel.org, linux-arch@vger.kernel.org, linux-doc@vger.kernel.org, linux-kselftest@vger.kernel.org, alistair.francis@wdc.com, richard.henderson@linaro.org, jim.shu@sifive.com, andybnac@gmail.com, kito.cheng@sifive.com, charlie@rivosinc.com, atishp@rivosinc.com, evan@rivosinc.com, cleger@rivosinc.com, alexghiti@rivosinc.com, samitolvanen@google.com, broonie@kernel.org, rick.p.edgecombe@intel.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Mon, Mar 10, 2025 at 11:42=E2=80=AFPM Deepak Gupta = wrote: > > Userspace specifies CLONE_VM to share address space and spawn new thread. > `clone` allow userspace to specify a new stack for new thread. However > there is no way to specify new shadow stack base address without changing > API. This patch allocates a new shadow stack whenever CLONE_VM is given. > > In case of CLONE_VFORK, parent is suspended until child finishes and thus > can child use parent shadow stack. In case of !CLONE_VM, COW kicks in > because entire address space is copied from parent to child. > > `clone3` is extensible and can provide mechanisms using which shadow stac= k > as an input parameter can be provided. This is not settled yet and being > extensively discussed on mailing list. Once that's settled, this commit > will adapt to that. > > Signed-off-by: Deepak Gupta > --- > arch/riscv/include/asm/mmu_context.h | 7 ++ > arch/riscv/include/asm/usercfi.h | 25 ++++++++ > arch/riscv/kernel/process.c | 9 +++ > arch/riscv/kernel/usercfi.c | 120 +++++++++++++++++++++++++++++= ++++++ > 4 files changed, 161 insertions(+) > > diff --git a/arch/riscv/include/asm/mmu_context.h b/arch/riscv/include/as= m/mmu_context.h > index 8c4bc49a3a0f..dbf27a78df6c 100644 > --- a/arch/riscv/include/asm/mmu_context.h > +++ b/arch/riscv/include/asm/mmu_context.h > @@ -48,6 +48,13 @@ static inline unsigned long mm_untag_mask(struct mm_st= ruct *mm) > } > #endif > > +#define deactivate_mm deactivate_mm > +static inline void deactivate_mm(struct task_struct *tsk, > + struct mm_struct *mm) > +{ > + shstk_release(tsk); > +} > + > #include > > #endif /* _ASM_RISCV_MMU_CONTEXT_H */ > diff --git a/arch/riscv/include/asm/usercfi.h b/arch/riscv/include/asm/us= ercfi.h > index 5f2027c51917..82d28ac98d76 100644 > --- a/arch/riscv/include/asm/usercfi.h > +++ b/arch/riscv/include/asm/usercfi.h > @@ -8,6 +8,9 @@ > #ifndef __ASSEMBLY__ > #include > > +struct task_struct; > +struct kernel_clone_args; > + > #ifdef CONFIG_RISCV_USER_CFI > struct cfi_status { > unsigned long ubcfi_en : 1; /* Enable for backward cfi. */ > @@ -17,6 +20,28 @@ struct cfi_status { > unsigned long shdw_stk_size; /* size of shadow stack */ > }; > > +unsigned long shstk_alloc_thread_stack(struct task_struct *tsk, > + const struct kernel_clone_args *ar= gs); > +void shstk_release(struct task_struct *tsk); > +void set_shstk_base(struct task_struct *task, unsigned long shstk_addr, = unsigned long size); > +unsigned long get_shstk_base(struct task_struct *task, unsigned long *si= ze); > +void set_active_shstk(struct task_struct *task, unsigned long shstk_addr= ); > +bool is_shstk_enabled(struct task_struct *task); > + > +#else > + > +#define shstk_alloc_thread_stack(tsk, args) 0 > + > +#define shstk_release(tsk) > + > +#define get_shstk_base(task, size) 0UL > + > +#define set_shstk_base(task, shstk_addr, size) > + > +#define set_active_shstk(task, shstk_addr) > + > +#define is_shstk_enabled(task) false > + > #endif /* CONFIG_RISCV_USER_CFI */ > > #endif /* __ASSEMBLY__ */ > diff --git a/arch/riscv/kernel/process.c b/arch/riscv/kernel/process.c > index 7c244de77180..99acb6342a37 100644 > --- a/arch/riscv/kernel/process.c > +++ b/arch/riscv/kernel/process.c > @@ -29,6 +29,7 @@ > #include > #include > #include > +#include > > #if defined(CONFIG_STACKPROTECTOR) && !defined(CONFIG_STACKPROTECTOR_PER= _TASK) > #include > @@ -211,6 +212,7 @@ int copy_thread(struct task_struct *p, const struct k= ernel_clone_args *args) > unsigned long clone_flags =3D args->flags; > unsigned long usp =3D args->stack; > unsigned long tls =3D args->tls; > + unsigned long ssp =3D 0; > struct pt_regs *childregs =3D task_pt_regs(p); > > /* Ensure all threads in this mm have the same pointer masking mo= de. */ > @@ -229,11 +231,18 @@ int copy_thread(struct task_struct *p, const struct= kernel_clone_args *args) > p->thread.s[0] =3D (unsigned long)args->fn; > p->thread.s[1] =3D (unsigned long)args->fn_arg; > } else { > + /* allocate new shadow stack if needed. In case of CLONE_= VM we have to */ > + ssp =3D shstk_alloc_thread_stack(p, args); > + if (IS_ERR_VALUE(ssp)) > + return PTR_ERR((void *)ssp); > + > *childregs =3D *(current_pt_regs()); > /* Turn off status.VS */ > riscv_v_vstate_off(childregs); > if (usp) /* User fork */ > childregs->sp =3D usp; > + /* if needed, set new ssp */ > + ssp ? set_active_shstk(p, ssp) : 0; > if (clone_flags & CLONE_SETTLS) > childregs->tp =3D tls; > childregs->a0 =3D 0; /* Return value of fork() */ > diff --git a/arch/riscv/kernel/usercfi.c b/arch/riscv/kernel/usercfi.c > index 24022809a7b5..73cf87dab186 100644 > --- a/arch/riscv/kernel/usercfi.c > +++ b/arch/riscv/kernel/usercfi.c > @@ -19,6 +19,41 @@ > > #define SHSTK_ENTRY_SIZE sizeof(void *) > > +bool is_shstk_enabled(struct task_struct *task) > +{ > + return task->thread_info.user_cfi_state.ubcfi_en ? true : false; > +} > + > +void set_shstk_base(struct task_struct *task, unsigned long shstk_addr, = unsigned long size) > +{ > + task->thread_info.user_cfi_state.shdw_stk_base =3D shstk_addr; > + task->thread_info.user_cfi_state.shdw_stk_size =3D size; > +} > + > +unsigned long get_shstk_base(struct task_struct *task, unsigned long *si= ze) > +{ > + if (size) > + *size =3D task->thread_info.user_cfi_state.shdw_stk_size; > + return task->thread_info.user_cfi_state.shdw_stk_base; > +} > + > +void set_active_shstk(struct task_struct *task, unsigned long shstk_addr= ) > +{ > + task->thread_info.user_cfi_state.user_shdw_stk =3D shstk_addr; > +} > + > +/* > + * If size is 0, then to be compatible with regular stack we want it to = be as big as > + * regular stack. Else PAGE_ALIGN it and return back > + */ > +static unsigned long calc_shstk_size(unsigned long size) > +{ > + if (size) > + return PAGE_ALIGN(size); > + > + return PAGE_ALIGN(min_t(unsigned long long, rlimit(RLIMIT_STACK),= SZ_4G)); > +} > + > /* > * Writes on shadow stack can either be `sspush` or `ssamoswap`. `sspush= ` can happen > * implicitly on current shadow stack pointed to by CSR_SSP. `ssamoswap`= takes pointer to > @@ -142,3 +177,88 @@ SYSCALL_DEFINE3(map_shadow_stack, unsigned long, add= r, unsigned long, size, unsi > > return allocate_shadow_stack(addr, aligned_size, size, set_tok); > } > + > +/* > + * This gets called during clone/clone3/fork. And is needed to allocate = a shadow stack for > + * cases where CLONE_VM is specified and thus a different stack is speci= fied by user. We > + * thus need a separate shadow stack too. How does separate shadow stack= is specified by > + * user is still being debated. Once that's settled, remove this part of= the comment. > + * This function simply returns 0 if shadow stack are not supported or i= f separate shadow > + * stack allocation is not needed (like in case of !CLONE_VM) > + */ > +unsigned long shstk_alloc_thread_stack(struct task_struct *tsk, > + const struct kernel_clone_args *ar= gs) > +{ > + unsigned long addr, size; > + > + /* If shadow stack is not supported, return 0 */ > + if (!cpu_supports_shadow_stack()) > + return 0; > + > + /* > + * If shadow stack is not enabled on the new thread, skip any > + * switch to a new shadow stack. > + */ > + if (!is_shstk_enabled(tsk)) > + return 0; > + > + /* > + * For CLONE_VFORK the child will share the parents shadow stack. > + * Set base =3D 0 and size =3D 0, this is special means to track = this state > + * so the freeing logic run for child knows to leave it alone. > + */ > + if (args->flags & CLONE_VFORK) { > + set_shstk_base(tsk, 0, 0); > + return 0; > + } > + > + /* > + * For !CLONE_VM the child will use a copy of the parents shadow > + * stack. > + */ > + if (!(args->flags & CLONE_VM)) > + return 0; > + > + /* > + * reaching here means, CLONE_VM was specified and thus a separat= e shadow > + * stack is needed for new cloned thread. Note: below allocation = is happening > + * using current mm. > + */ > + size =3D calc_shstk_size(args->stack_size); > + addr =3D allocate_shadow_stack(0, size, 0, false); > + if (IS_ERR_VALUE(addr)) > + return addr; > + > + set_shstk_base(tsk, addr, size); > + > + return addr + size; > +} > + > +void shstk_release(struct task_struct *tsk) > +{ > + unsigned long base =3D 0, size =3D 0; > + /* If shadow stack is not supported or not enabled, nothing to re= lease */ > + if (!cpu_supports_shadow_stack() || !is_shstk_enabled(tsk)) > + return; > + > + /* > + * When fork() with CLONE_VM fails, the child (tsk) already has a > + * shadow stack allocated, and exit_thread() calls this function = to > + * free it. In this case the parent (current) and the child shar= e > + * the same mm struct. Move forward only when they're same. > + */ > + if (!tsk->mm || tsk->mm !=3D current->mm) > + return; > + > + /* > + * We know shadow stack is enabled but if base is NULL, then > + * this task is not managing its own shadow stack (CLONE_VFORK). = So > + * skip freeing it. > + */ > + base =3D get_shstk_base(tsk, &size); > + if (!base) > + return; > + > + vm_munmap(base, size); > + set_shstk_base(tsk, 0, 0); > +} > LGTM. Reviewed-by: Zong Li > -- > 2.34.1 > > > _______________________________________________ > linux-riscv mailing list > linux-riscv@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-riscv