From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qt1-f182.google.com (mail-qt1-f182.google.com [209.85.160.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8F4141632DF for ; Sun, 22 Jun 2025 17:40:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.182 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750614016; cv=none; b=irmDFploLUGxdnZLhniPMRjwniX+mFGcdHkY0gqq3/UEeJb1GVnXlUS+GfAxzQdRasWO/fx8iHEQSeVZF4jCta8av29JVBaaNovPPeSK2E1HsdEAwUNDk+qkLmopia/hot8lZYC8+fUSaaaNRMng6j5f2wNZbRj41VAXNXy4ehk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750614016; c=relaxed/simple; bh=JBS6katIuy9abXAwM/EgfQ0vNXuWJoKtGDCgsMvppwk=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=Y29TKvgOW9pgvJnQsG/rgwOQBwPr6OcEapfAU6YUw3Udmh7F1fMhuytEn45o2VLcm9coNrVJ/NQvtTjQ/H/3OxlrQ2L0TSb5OSmS2VrvRnzFzMYVPbzCVVnzzPtoe0MImW5iygXM9ZBLtcnKnjaQgi1FI0xyyeUh5uCIzo1Hsng= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=daynix.com; spf=pass smtp.mailfrom=daynix.com; dkim=pass (2048-bit key) header.d=daynix-com.20230601.gappssmtp.com header.i=@daynix-com.20230601.gappssmtp.com header.b=qkUd7OyY; arc=none smtp.client-ip=209.85.160.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=daynix.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=daynix.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=daynix-com.20230601.gappssmtp.com header.i=@daynix-com.20230601.gappssmtp.com header.b="qkUd7OyY" Received: by mail-qt1-f182.google.com with SMTP id d75a77b69052e-4a58c2430edso38608671cf.1 for ; Sun, 22 Jun 2025 10:40:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=daynix-com.20230601.gappssmtp.com; s=20230601; t=1750614013; x=1751218813; darn=vger.kernel.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=JBS6katIuy9abXAwM/EgfQ0vNXuWJoKtGDCgsMvppwk=; b=qkUd7OyYEjZA3lCPXBJ2EiCNjnegCHE58l9b9rp5DFzG3W534etSXmVuSkC8fyOX4c 2yXHCPoFE9XUeoh2ixdyCTqX7bI9GOse/fsmLV6qJoRGE96GFREHnOSrl+e4eNkhdO/e czNg7xL88rWOvVdDmnkcZTQZYyKdCzp/YSWikP66SQS0kZ9xReRjfOGgQZo1rgXHZX4D mJ/syG00Vo7x1P8mvuc3go99/o9iGFJ5Vu0DgzaT6F+YbQX9l79sDDxhucVD+ydqscaa GNPKD6NQHuoo2Q2R9qwfIH+XxEBc29Snrqnx5KKh3LB9JOBRq/BFyRUoKcQxK5o37gs2 v3Hg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1750614013; x=1751218813; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=JBS6katIuy9abXAwM/EgfQ0vNXuWJoKtGDCgsMvppwk=; b=XSkVnh7dz+lDRYPUcH/c36lK5CUvEvhAmvpNVIfyjZgYFnfzKX4y7YGlMrKins7Q1T 3mWU4j1TJnCB0EFtMenrlYsBORmU6ok1p3QaFDZM7NLNTYswd4uMYd5EsygjT3hFgl4f SfOmtVSI0UAvf9cTlOvhEKAST3wvk2REQ2K4YJbp8VQZyLX228PIGsVEGnv5UkVud+O6 eo0lx946nx+Ov5e6yMeDPijD/ZBOF5NtRwhod/1dANr8mjbnDvvgGeD0wfuwJOxerIAt ZY+vf0cQrKug6IPENSHz9xOTqLKizNOiUesf3Pojj0m/oMxPoga9eEFlmrJHciFM727r cj2g== X-Forwarded-Encrypted: i=1; AJvYcCXZiKg4rSRDFVKKNhzuHxFQhAZtzjLjFKSKKFgKmCjkCgnmCHEZ2kW/qG12jOGwwraFQniX/V1i++PLFYl3vTo=@vger.kernel.org X-Gm-Message-State: AOJu0Yw/zOeqztU57k5Po9QXJzIzpC4HSctLupo5HMNhOd9sWwYIKcQ2 Sj/UEi3NvRPKJNbPmrbOdsupsbzuU/BG0v3/2UR3zrhD1Uy0vs4KEx1oBUSbE0Eyw4VnLorLLur O+kzlIMSsz8SaqjyelmQtCUyT7BeMRnBcEP2Gdjcs/g== X-Gm-Gg: ASbGncstlQaqkLJxHLX/2wZFNycB5wDfHgCmpYIo5VNp7o5sw4ILVNnuq+k8+XyhZpJ 6DRQYijpJGZGTf13ipX1/i9zUUS0rbTsItVaiuaSsMLqw2l+QXe5u5UnrYplrei3e/wWvnLmivX KR6cNSDUVamnwXOCPQLasEW9aVehsMKwk0jAeYXmZxsppxNpVfVRwN3PC0awuw5k6ourVqivLYE dJtFcbKHo6N9eHf X-Google-Smtp-Source: AGHT+IGAQVA4j9B6bOXEQavSPQk4pUsTIQfktiOkSDRcEtYWtj2nMKnJm6GAf6TwLLKYEA7597CW46OoVjUcTVc0rKg= X-Received: by 2002:ac8:5707:0:b0:494:b247:4ddb with SMTP id d75a77b69052e-4a77c2d6173mr135279261cf.4.1750614013493; Sun, 22 Jun 2025 10:40:13 -0700 (PDT) Precedence: bulk X-Mailing-List: linux-kselftest@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20250530-rss-v12-0-95d8b348de91@daynix.com> <20250530-rss-v12-1-95d8b348de91@daynix.com> <95cb2640-570d-4f51-8775-af5248c6bc5a@daynix.com> <4eaa7aaa-f677-4a31-bcc2-badcb5e2b9f6@daynix.com> <75ef190e-49fc-48aa-abf2-579ea31e4d15@daynix.com> <760e9154-3440-464f-9b82-5a0c66f482ee@daynix.com> In-Reply-To: From: Yuri Benditovich Date: Sun, 22 Jun 2025 20:40:02 +0300 X-Gm-Features: AX0GCFu7f7UEMKygSwaRuFS-QXgCw4dhQ6kVLLsvANPI-_VjCLQSaQpxwUYjwO8 Message-ID: Subject: Re: [PATCH net-next v12 01/10] virtio_net: Add functions for hashing To: Jason Wang Cc: Akihiko Odaki , "Michael S. Tsirkin" , Jonathan Corbet , Willem de Bruijn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Xuan Zhuo , Shuah Khan , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, kvm@vger.kernel.org, virtualization@lists.linux-foundation.org, linux-kselftest@vger.kernel.org, Andrew Melnychenko , Stephen Hemminger , gur.stavi@huawei.com, Lei Yang , Simon Horman Content-Type: text/plain; charset="UTF-8" > Yuri, can you help to clarify this? I see here several questions: 1. Whether it is ok for the device not to indicate support for XXX_EX hash type? - I think, yes (strictly speaking, it was better to test that before submitting the patches ) 2. Is it possible that the guest will enable some XXX_EX hash type if the device does not indicate that it is supported? - No (I think this is part of the spec) 3. What to do if we migrate between systems with different capabilities of hash support/reporting/whatever - IMO, at this moment such case should be excluded and only mechanism we have for that is the compatible machine version - in some future the change of device capabilities can be communicated to the driver and _probably_ the driver might be able to communicate the change of device capabilities to the OS 4. Does it make sense to have fine configuration of hash types mask via command-line? - IMO, no. This would require the user to have too much knowledge about RSS internals Please let me know if I missed something.