From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from relay2-d.mail.gandi.net (relay2-d.mail.gandi.net [217.70.183.194]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A46421C84BD; Mon, 14 Apr 2025 20:27:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.70.183.194 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744662465; cv=none; b=CJIenwSt7kIIAIfHhPxmA7nSDleG1lfsNDQ7alVW13NiklvUpDhmvOk3437+Za1L6fQJsZs4YbgnrXoIY+D17MCz6tiSwqL3uYO58LPBJRiN7edBoCMIl2ReDlKMEsN7DEWtL5eaQArZZg9rQzo/nx5FcmkYIR3+B+GMYG2zQ3k= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744662465; c=relaxed/simple; bh=Kj0GFY4mY/pF3mxC/mn94rfZB0k4NTpMZv19Q8W3Tgk=; h=Mime-Version:Content-Type:Date:Message-Id:To:Cc:Subject:From: References:In-Reply-To; b=cUfjapHPppIIdyks3CzKx2sIwGwPuJRljAEIN/wGMwuwwqqFjE9DA7uw4f97rc2pWXHmfl87HhkekPaSoLAdY2fjJaOQNpa3X9HMkbHPz5pNAcEyq7qOMLBTdzK6cAyHaBaMjcR8HXYJX7d2N+9hSf+UhLX+ZksGyHCe2fEWRIY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b=N4Hnxsbe; arc=none smtp.client-ip=217.70.183.194 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="N4Hnxsbe" Received: by mail.gandi.net (Postfix) with ESMTPSA id C4EB94384E; Mon, 14 Apr 2025 20:27:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1744662460; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=qjMFJPpRCPOvsPjgp/zlZf5TXQQY8q9e/fZxYLwtj0c=; b=N4HnxsbeyxlL0cI2fjrgbDYOY26mtPrjrWBL3s4rpcNcFbKrZ5oML+muF9dSwIf+R31jOO KNd1PzJKTjjfbLK6hep9vPg39UlV0zZF1BKJF267ZKn2J1xoru9QbkUvAEvvzknyjloLJP whWw08ja2cuoNe2+omAHJq+d4WWMJz7eKipWxuppjlyBY8Jo9C/UgNEqJDTHPvWP/vWHdm 5/xJrI+nUBg1sp6a6dvPhPruhokRRYG2wFB5FSR7rUVrXYzQ/nSXIftSCXTb8e6TiR1Qh1 dpKt+psmNo3zzf34HIghYQmvKiizqjkVg33fTgTDXfhAAH/Cfhn3QN9AUiqQCA== Precedence: bulk X-Mailing-List: linux-kselftest@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Mon, 14 Apr 2025 22:27:38 +0200 Message-Id: To: "Jiri Olsa" Cc: "Alexei Starovoitov" , "Daniel Borkmann" , "John Fastabend" , "Andrii Nakryiko" , "Martin KaFai Lau" , "Eduard Zingerman" , "Song Liu" , "Yonghong Song" , "KP Singh" , "Stanislav Fomichev" , "Hao Luo" , "Puranjay Mohan" , "Xu Kuohai" , "Catalin Marinas" , "Will Deacon" , "Mykola Lysenko" , "Shuah Khan" , "Maxime Coquelin" , "Alexandre Torgue" , "Florent Revest" , "Bastien Curutchet" , , "Thomas Petazzoni" , , , , , Subject: Re: [PATCH RFC bpf-next 1/4] bpf: add struct largest member size in func model From: =?utf-8?q?Alexis_Lothor=C3=A9?= X-Mailer: aerc 0.20.1-0-g2ecb8770224a References: <20250411-many_args_arm64-v1-0-0a32fe72339e@bootlin.com> <20250411-many_args_arm64-v1-1-0a32fe72339e@bootlin.com> In-Reply-To: X-GND-State: clean X-GND-Score: -100 X-GND-Cause: gggruggvucftvghtrhhoucdtuddrgeefvddrtddtgddvvdduheduucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuifetpfffkfdpucggtfgfnhhsuhgsshgtrhhisggvnecuuegrihhlohhuthemuceftddunecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenucfjughrpegggfgtfffkvfevuffhofhfjgesthhqredtredtjeenucfhrhhomheptehlvgigihhsucfnohhthhhorhoruceorghlvgigihhsrdhlohhthhhorhgvsegsohhothhlihhnrdgtohhmqeenucggtffrrghtthgvrhhnpeekgfffhfehhfefgeekhfffudfhheekveffleeuhfelgfefueevhedvkeduhfehveenucffohhmrghinhepsghoohhtlhhinhdrtghomhenucfkphepvdgrtddvmeekgedvkeemfhelgegtmegvtddtmeemfhekheenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepihhnvghtpedvrgdtvdemkeegvdekmehfleegtgemvgdttdemmehfkeehpdhhvghloheplhhotggrlhhhohhsthdpmhgrihhlfhhrohhmpegrlhgvgihishdrlhhothhhohhrvgessghoohhtlhhinhdrtghomhdpnhgspghrtghpthhtohepvdelpdhrtghpthhtohepohhlshgrjhhirhhisehgmhgrihhlrdgtohhmpdhrtghpthhtoheprghstheskhgvrhhnvghlrdhorhhgpdhrtghpthhtohepuggrnhhivghlsehiohhgvggrrhgsohigrdhnvghtpdhrtghpthhtohepjhhohhhnrdhfrghsthgrsggvnhgusehgmhgrihhlrdgto hhmpdhrtghpthhtoheprghnughrihhisehkvghrnhgvlhdrohhrghdprhgtphhtthhopehmrghrthhinhdrlhgruheslhhinhhugidruggvvhdprhgtphhtthhopegvugguhiiikeejsehgmhgrihhlrdgtohhmpdhrtghpthhtohepshhonhhgsehkvghrnhgvlhdrohhrgh X-GND-Sasl: alexis.lothore@bootlin.com Hello Jiri, On Mon Apr 14, 2025 at 1:04 PM CEST, Jiri Olsa wrote: > On Fri, Apr 11, 2025 at 10:32:10PM +0200, Alexis Lothor=C3=A9 (eBPF Found= ation) wrote: [...] >> + for_each_member(i, t, member) { >> + mtype =3D btf_type_by_id(btf, member->type); >> + while (mtype && btf_type_is_modifier(mtype)) >> + mtype =3D btf_type_by_id(btf, mtype->type); >> + if (!mtype) >> + return -EINVAL; > > should we use __get_type_size for member->type instead ? Ah, yes, thanks for the hint, that will allow to get rid of the manual modifiers skip. Alexis > jirka --=20 Alexis Lothor=C3=A9, Bootlin Embedded Linux and Kernel engineering https://bootlin.com