From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-oo1-f52.google.com (mail-oo1-f52.google.com [209.85.161.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0E14D3B47E6 for ; Thu, 25 Jun 2026 16:44:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.161.52 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782405866; cv=none; b=gRmLiWGfmjG4229YeZve8LZhLXw9JMpiV8SUGuChQlb/oQIQJkHX1Ibpa8vDS8lnG/aqowTprkKmAvZi//UqspxcvJLkYOsscx49X5MugYEYJTb1IdlGP/qWCgoLhsBKQmOoClG6CmVSROCZTq1+KP/k2pOpZKF7W2Ae5+S9UOc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782405866; c=relaxed/simple; bh=P2+ReacPCeqU/fKo9jBbrql6rfmKkcgJUzlpxwAN/o8=; h=Mime-Version:Content-Type:Date:Message-Id:From:To:Cc:Subject: References:In-Reply-To; b=a7rHnm0z+KNI+3qhWaxBKAzSuH6V3cQzoz5ZljNtGfqk67qS+EwqUUUfrgpT5ODNIScn8GKhBSsfqt/L4Rd94cvYe6jY7g576wN9p5kCdwQ79aZoofaoh0VUkvmsNgAVzk/FOajWyxaMDJQ/MTsUJMZVCJncRGhutRBpPB2f5q0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=EMJMIzE6; arc=none smtp.client-ip=209.85.161.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="EMJMIzE6" Received: by mail-oo1-f52.google.com with SMTP id 006d021491bc7-6a11ee16bafso32149eaf.0 for ; Thu, 25 Jun 2026 09:44:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1782405863; x=1783010663; darn=vger.kernel.org; h=in-reply-to:references:subject:cc:to:from:message-id:date :content-transfer-encoding:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=t7W/ggTwnqmzWBnV2WV1SHqoLx9vAqZSkSoEPfkHk5g=; b=EMJMIzE6YZ9QJzbgGckgqJ4BcvpUQQv61rNrBh7KyGzS+927hCTboE4mKXsWuZpPwv yZs2FP+wZpxxmf7LMIduAZXhhj9SezF4VF4DXQPFZg369DINm2bK74N1FgmCHQq+ULkl qp+wXlYwzLgNlfO4TssOI9PbeSTqds5WFxxx9WBkrpPF/xw6HaFabsm10Lmu2hQ3jp72 NlueDYdo9Czm17ifriUAc+FqLgdiUxI+tQQRyZkDodGl9JDKHbLmcrOBeB5fO2LHRGAQ iIKtd8/u4CD1NEKyRAX61Jd2d7mYv6egWzzHD9qDe53TPjClS13YhGUJQncRLmXp+a6N SfhQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782405863; x=1783010663; h=in-reply-to:references:subject:cc:to:from:message-id:date :content-transfer-encoding:mime-version:x-gm-gg:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=t7W/ggTwnqmzWBnV2WV1SHqoLx9vAqZSkSoEPfkHk5g=; b=TP5dMfT4neWOMPaWk7n9cfg9Ue8nVkaWDu1b61RaY6Ke5qRxf3yiFfeX0Ots1IUalb CBuYJ/v3secc86hGtOOO6Q38zxPFCpscU083IR7JQEW+kZ+vj/x7Bj/Ix1bwjeRb4cnn /A/ksMKq0e8eue1HBAGVL7+N6MaA8WqW3toYqmbazAYV3ep7Q4iJ1Xhti7QtHxFTJxki 1raWlZKE+R4sZQunu3aGn8SHyOrozlKpjG2RJAYI2W9p1E1K6xghVEj+oFWAaWsB95TS CGsyztX0FVqMmdKZiW28Yus0/gQ/KJ6J01cD2dJeyS8SDUmpE+U3hfA7jVPi8LU0ZbiX SINA== X-Forwarded-Encrypted: i=1; AFNElJ/J2z44koMS9RixSxSvfUw8Q961zOEYz3JKhdfGVCsUd41OyHpVm7TgikcW4WXIHzh91j3WYWVPFs+n9ShbTdw=@vger.kernel.org X-Gm-Message-State: AOJu0YyUre3WzJATI6nKTGmwAoZBuzf6t5wvlKzY3SM1exo8E7Ik/01F QJgwWImRTefootB88blUnERIU7TPD+GuJK5vEtx4mhaRg1omiBZSUbCT X-Gm-Gg: AfdE7cltm52s/BlTTUHqvfqgbeB3aEBacIco3K7igryTeA85q/6Zfw+vZ23FYBO2LeT 7q8tqHDslVZUE60XLkcStnKF4xEW8eulh7YhDdlZazicejBroAnQ4qGcw5yGW22rJncotBbykh+ gmtA0lhaRcSwHQBnhVGaWu7sjs6Q5fAUPlhZnczQwI+DYD+OSartcbtabkCsCwnX+LdYC3tQuhG UNAzw4NDGYKnGfZlevfXB1Eu4Gyyt2gdCRy6QY0dMbSV5URNsrgC/th+mZwcdu/es7bimS188M/ atONCS2rFCTr5mEOQyXiNoPtAucHq19QbhX65HU5CVHIq+F9yQ6YdCRmueKLxoc7KuZu9FSl81z 8YgVNgorYYLpCxwXeOwwow6um0hyM4vWF2ar6uCWDTlgJm0jjv9B9Umqn+od5ES+WpYebcG/CM6 2EgVVvld/XW/gJmF7y3PxlHKGgER2qEGxzoH8p5DTEDHcx0A2yfU15FxpK0K3M7JAL062Qq8hy2 X+zG3jCgbXYfY0gfw== X-Received: by 2002:a05:6820:814:b0:69e:ab0:3f4e with SMTP id 006d021491bc7-6a13522493amr2720037eaf.46.1782405863009; Thu, 25 Jun 2026 09:44:23 -0700 (PDT) Received: from localhost ([2a03:2880:10ff:10::]) by smtp.gmail.com with ESMTPSA id 006d021491bc7-6a0ea0c378csm10370966eaf.10.2026.06.25.09.44.22 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 25 Jun 2026 09:44:22 -0700 (PDT) Precedence: bulk X-Mailing-List: linux-kselftest@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Thu, 25 Jun 2026 09:44:21 -0700 Message-Id: From: "Alexei Starovoitov" To: "Jakub Kicinski" , "Siddharth C" Cc: , , , , , , Subject: Re: [PATCH 1/2] bpf: preserve rx_queue_index across XDP redirects X-Mailer: aerc References: <20260620121321.45227-1-siddharthcibi@icloud.com> <20260620121321.45227-2-siddharthcibi@icloud.com> <20260624185432.32d90aa8@kernel.org> In-Reply-To: <20260624185432.32d90aa8@kernel.org> On Wed Jun 24, 2026 at 6:54 PM PDT, Jakub Kicinski wrote: > On Sat, 20 Jun 2026 12:13:13 +0000 Siddharth C wrote: >> diff --git a/kernel/bpf/cpumap.c b/kernel/bpf/cpumap.c >> index 5e59ab896f05..8f2d7013620f 100644 >> --- a/kernel/bpf/cpumap.c >> +++ b/kernel/bpf/cpumap.c >> @@ -197,7 +197,7 @@ static int cpu_map_bpf_prog_run_xdp(struct bpf_cpu_m= ap_entry *rcpu, >> =20 >> rxq.dev =3D xdpf->dev_rx; >> rxq.mem.type =3D xdpf->mem_type; >> - /* TODO: report queue_index to xdp_rxq_info */ >> + rxq.queue_index =3D xdpf->rx_queue_index; > > Do you actually need this or you're just trying to address the TODO? It's a 3rd if not 4th attempt from various "people" to address this TODO. We should just remove this line instead.