From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr2-f2.google.com (mail-wr2-f2.google.com [74.125.225.66]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A00E5442120 for ; Fri, 31 Jul 2026 15:44:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.225.66 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785512680; cv=none; b=nsS01GQcmTFlgda7tDm4zi+m2/6fO3542xaOjRJL77QxeI1HIuj5p8k0ck0zSFvY4zCpSN0mg9EsH44tVRSVVgvWC0+nBN+vVI6rbGUsIXogS/2Xp93yVQcSB1Gu9HDnAB7a1upyhmFrPQyWdDPxqVggnI7uVlICaIxS6VKsGME= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785512680; c=relaxed/simple; bh=3TMU74QWZoDLOURmJXG/MdRKhkJLQUmMeQBO4XyQ9QI=; h=Mime-Version:Content-Type:Date:Message-Id:Cc:Subject:From:To: References:In-Reply-To; b=Ir0A6oRaUtPaz0OpMGaTwI+r64eXFyLD+arQ7AkJoP9R/6YZVo6kEwNWs9vtzOr+2NNyOAh8KBUxo9+TmdD/WJpvryoMsfwIhniIUDI878nCwBaJ9YOI2rp9DlZzOWnJEcg4ZhJHx613DoRGDOwcePNcmn3SvQnRfZHrqKv8238= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=BUAjuzik; arc=none smtp.client-ip=74.125.225.66 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="BUAjuzik" Received: by mail-wr2-f2.google.com with SMTP id ffacd0b85a97d-47f7f93b3d4so338927f8f.1 for ; Fri, 31 Jul 2026 08:44:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1785512677; x=1786117477; darn=vger.kernel.org; h=in-reply-to:references:to:from:subject:cc:message-id:date :content-type:content-transfer-encoding:mime-version:from:to:cc :subject:date:message-id:reply-to:content-type; bh=3TMU74QWZoDLOURmJXG/MdRKhkJLQUmMeQBO4XyQ9QI=; b=BUAjuziks1o6IcLjjnCNTj5ZPOZq1/j9neEAYN+xFL8YvZJ0GabVQuFG+cbmrX1GkQ /HD7ej+ToDjie5K4/X3LT7FTVDTBUetjvyHN2PELc2rOSvdxHOFR7oGdotXmCpZI5SVt NJiNy4ozrOkKt28Ma8f+6NI11frL1BRQMPC63a9yclHwLR8PnVA/tQrLAp89RWTGAi/X dfXdGUA57Rq+lVKKu7SLl4hvArDlAsmwa5AVfNSzepQFd/0fJp1mrELZSKJ6M8U0A3FM iSPSp8HSZ6MYbAkuQejlwnvCUKRRk9c0wG5kEXDwR/h0fAfnPe271m5pmCOQ/p9kqsV+ JtwQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785512677; x=1786117477; h=in-reply-to:references:to:from:subject:cc:message-id:date :content-type:content-transfer-encoding:mime-version:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=3TMU74QWZoDLOURmJXG/MdRKhkJLQUmMeQBO4XyQ9QI=; b=ejmbBBTaX5x1Lt9Ck6Lz7Gr868JOX98h0RwIqpfd7rIQk1RlVe/yb26C15XerjsfxF kwp88rzH1RR67qCLZ/n2kexx/ciVt6Yn5MTSHeojNIfcy/rTTukO54PviL9VrYw0Ya17 72pfSaP7F91VMTPmnwuPppSR2TDwh+uR6RfCM65J/8h/auxFE6sfas77K5f3oy45TPUw YYQqav5DDcEqNJJg7QMYp6jewmsDxnmnLNtmuIgoEqJCyJMmFfgMfJWkDPK6DxWWPziT OEkLrHDjwdiqGjkKcqxSrYqu79fDVR+94cFdsS0j382W/okl2txX3TVedCRnKMDigYi1 yFNA== X-Forwarded-Encrypted: i=1; AHgh+RqMgkNr6yh9t134fdOcP/ACM1R8HSuXaLXBE90WZDq/IwHlKBClwjeh4pU88ID/UnDRPN/bDLO20e5W4/PYa/c=@vger.kernel.org X-Gm-Message-State: AOJu0Yyq06rYQopdpIQM+7RqUZN3zd0eZsBOMWQdzdcTHRFXoz1p2KfW QDdDhbLgtLrtXGOIHcowz9ggIakr29zUVbYfJCCHeFKYGR2A+/EPqqJe X-Gm-Gg: AR+sD10qQui2H6s/aikcJAdkkuwU+HkzJvigdDScAh2gbj1XgVcNbBxQlo7cApeqOiT N2NANJG7C27b8p4HagmVt2pq9dnJEuhT2vrWww73t/dn1AM/hD27ge3lEjWPIL7IiNtAkFTdivW 49J6Ws9Uk5/3roGVSNNj1vsQhi8Vu2J+1kBRUOS/KSXBKyrkiOvivNqqB0fol81oWZczMGiY9Ng PWMujG5i0rjxa+xuvdvTHr7tmDH33d67wyYGbqIOxL1IcRAa0Z9aTr+x/0s/k6jFjstlz8pMiEZ 0uLkoSz7LFu5GJRt42h/qzwSQYWD5I7daKshf1WPdP941/KK+5SM7Pr8cL7JsrWnPGkv5OBiUjd qi/4YQ6X2ZA6FkZwPaQiCv0WVGGi/V0e29LUxRIXj50wISytyWRDmC776e4HhDEyjym46armORu sZ3lDUzc/kNUkZwzmkL8unSqKy/nwTXe+86qybt+xF4/s2X0F9nC/pRqxx0ify2cySX9HLoO0M5 0pE+PqtbaLt9bUHU27ubhRJRqRmPVIndF86+dwtm8CRKTVlzzUno6QD6cla7ugnCa8Lq6SmaL85 JBHseht8Gi+tZp+rU6129M4ufsA= X-Received: by 2002:a05:6000:4615:b0:47f:918b:fa07 with SMTP id ffacd0b85a97d-47fd72d4500mr253409f8f.22.1785512676702; Fri, 31 Jul 2026 08:44:36 -0700 (PDT) Received: from localhost (nat-icclus-192-26-29-3.epfl.ch. [192.26.29.3]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-47fd456a5a4sm6264702f8f.20.2026.07.31.08.44.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 31 Jul 2026 08:44:36 -0700 (PDT) Precedence: bulk X-Mailing-List: linux-kselftest@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Fri, 31 Jul 2026 17:44:35 +0200 Message-Id: Cc: "Alexei Starovoitov" , "Daniel Borkmann" , "Andrii Nakryiko" , "Martin KaFai Lau" , "Eduard Zingerman" , "Song Liu" , "Yonghong Song" , "John Fastabend" , "KP Singh" , "Jiri Olsa" , "Emil Tsalapatis" , "Matt Bobrowski" , "James Morris" , "Serge E . Hallyn" , "Casey Schaufler" , "Stephen Smalley" , "Ondrej Mosnacek" , "Mimi Zohar" , "Roberto Sassu" , "Dmitry Kasatkin" , "Eric Snowberg" , "Alexander Viro" , "Christian Brauner" , "Jan Kara" , "Shuah Khan" , , , , , , , Subject: Re: [PATCH v6 bpf-next 3/4] bpf: add bpf_init_inode_xattr kfunc for atomic inode labeling From: "Kumar Kartikeya Dwivedi" To: "David Windsor" , "Paul Moore" X-Mailer: aerc 0.21.0 References: <20260730234533.1912709-1-dwindsor@gmail.com> <20260730234533.1912709-4-dwindsor@gmail.com> In-Reply-To: On Fri Jul 31, 2026 at 5:30 PM CEST, David Windsor wrote: > On Fri, Jul 31, 2026 at 11:17=E2=80=AFAM Paul Moore = wrote: >> >> >> Okay, it looks like there was some confusion/misunderstanding. >> >> My understanding of Kumar's comments was that he was referring to the >> exisiting LSM related kfuncs that are located in fs/bpf_fs_kfuncs.c, >> not necessarily the new kfunc you are proposing in this patchset. >> Kumar is welcome to correct either one or both of us, if we read that >> wrong :) >> > > Yes, after another reading, that does appear to be the case =3D). > > We'll need v7 anyway to fix the ocfs-related UAF the bot found. > Since there is confusion, let me clear it up. I meant it for all of them. I don't think it makes sense to keep this one i= n security/ when others are in fs/bpf_fs_kfuncs.c. That confusing limbo state= is worse than just placing it where others already are. As I already said, the discussion around whether all of them they should go= in security/ is orthogonal and should be done separately; it isn't productive = to repeatedly bring it up in the context of this patch set. I honestly don't get the urgency; it will be a mechanical change if we need= to make such changes. The worst outcome would be stalling David's work over it= . As for landing this stuff, we can let Paul take the patches touching securi= ty/ and route the rest (3-4) through bpf-next after the merge window. We need t= hem to go through BPF CI anyway to ensure nothing breaks. >> However, regardless of Kumar's intent, speaking as the LSM maintainer, >> my stance on this is that the kfunc you are proposing must live in >> security/bpf_lsm_kfuncs.c to be acceptable. >> > > Ack, will do this in v7. > > The Landlock series currently up for discussion [1] is proposing > placing its kfuncs in a new kernel/bpf/bpf_lsm.c. Should these maybe > go there? > > [1] https://lore.kernel.org/bpf/20260731022047.189137-1-utilityemal77@gma= il.com/ > >> -- >> paul-moore.com