From: "Daniel Zahka" <daniel.zahka@gmail.com>
To: "Todd Freed" <toddfreed@meta.com>, <netdev@vger.kernel.org>
Cc: "Daniel Zahka" <daniel.zahka@gmail.com>,
"Jakub Kicinski" <kuba@kernel.org>,
"Willem de Bruijn" <willemdebruijn.kernel@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
"Eric Dumazet" <edumazet@kernel.org>,
"Paolo Abeni" <pabeni@redhat.com>,
"Simon Horman" <horms@kernel.org>,
"Andrew Lunn" <andrew+netdev@lunn.ch>,
"Shuah Khan" <shuah@kernel.org>,
"Rahul Rameshbabu" <rrameshbabu@nvidia.com>,
"Raed Salem" <raeds@nvidia.com>,
"Cosmin Ratiu" <cratiu@nvidia.com>,
<linux-kselftest@vger.kernel.org>
Subject: Re: [PATCH net 0/2] psp: drop packets with extension headers in transport mode
Date: Wed, 21 Oct 2026 18:07:14 -0400 [thread overview]
Message-ID: <DMAUWQVPIVKP.1QAK1YSA76EHJ@gmail.com> (raw)
In-Reply-To: <20261021210200.788191-1-toddfreed@meta.com>
On Wed Oct 21, 2026 at 5:01 PM EDT, Todd Freed wrote:
> While working on adding support for socket-less psp associations, I
> noticed that this case was not being handled correctly. It will be more
> relevant with that series, because it adds udp support, for which the
> psp nexthdr will be taken from the inner packet.
>
> Since the tx association encodes intent to send encrypted packets, but
> because of other configuration (socket options, routes) the packets are
> sent unencrypted, sending this change as a fix.
>
> The first patch drops the packets, the second patch adds selftests for
> that case.
>
Why not just fix psp_dev_encapsulate() to put the psp headers in the
right position? With the self test we are going to make PSP + ipv6 ext
header == drop part of the uapi?
> Todd Freed (2):
> psp: drop transport mode packets with extension headers
> selftests: drv-net: psp: test ipv6 tcp socket with extension headers
>
> net/psp/psp_main.c | 7 +-
> tools/testing/selftests/drivers/net/config | 1 +
> tools/testing/selftests/drivers/net/psp.py | 120 ++++++++++++++++++++-
> 3 files changed, 125 insertions(+), 3 deletions(-)
next prev parent reply other threads:[~2026-10-21 22:07 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-21 21:01 [PATCH net 0/2] psp: drop packets with extension headers in transport mode Todd Freed
2026-10-21 21:01 ` [PATCH net 1/2] psp: drop transport mode packets with extension headers Todd Freed
2026-10-25 21:30 ` netdev-bot+sashiko
2026-10-21 21:02 ` [PATCH net 2/2] selftests: drv-net: psp: test ipv6 tcp socket " Todd Freed
2026-10-25 21:30 ` netdev-bot+sashiko
2026-10-21 22:07 ` Daniel Zahka [this message]
2026-10-21 23:16 ` [PATCH net 0/2] psp: drop packets with extension headers in transport mode Todd Bert Freed
2026-10-22 11:59 ` Björn Töpel
2026-10-22 12:06 ` Daniel Zahka
2026-10-22 22:43 ` Todd Bert Freed
2026-10-22 15:19 ` Willem de Bruijn
2026-10-22 16:58 ` Todd Bert Freed
2026-10-22 20:35 ` Willem de Bruijn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DMAUWQVPIVKP.1QAK1YSA76EHJ@gmail.com \
--to=daniel.zahka@gmail.com \
--cc=andrew+netdev@lunn.ch \
--cc=cratiu@nvidia.com \
--cc=davem@davemloft.net \
--cc=edumazet@kernel.org \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=raeds@nvidia.com \
--cc=rrameshbabu@nvidia.com \
--cc=shuah@kernel.org \
--cc=toddfreed@meta.com \
--cc=willemdebruijn.kernel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox