From: Chao Gao <chao.gao@intel.com>
To: Mingwei Zhang <mizhang@google.com>
Cc: Sean Christopherson <seanjc@google.com>,
Paolo Bonzini <pbonzini@redhat.com>, <kvm@vger.kernel.org>,
<linux-kselftest@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
"Jim Mattson" <jmattson@google.com>,
Venkatesh Srinivas <venkateshs@google.com>,
Aaron Lewis <aaronlewis@google.com>,
"Chang S. Bae" <chang.seok.bae@intel.com>
Subject: Re: [PATCH v2 1/7] KVM: selftests: x86: Add a working xstate data structure
Date: Sun, 19 Feb 2023 16:33:25 +0800 [thread overview]
Message-ID: <Y/He1Sro3hb7Hn0h@gao-cwp> (raw)
In-Reply-To: <20230214184606.510551-2-mizhang@google.com>
On Tue, Feb 14, 2023 at 06:46:00PM +0000, Mingwei Zhang wrote:
>- /* xsave data for guest_code */
>- xsavedata = vm_vaddr_alloc_pages(vm, 3);
>- memset(addr_gva2hva(vm, xsavedata), 0, 3 * getpagesize());
>- vcpu_args_set(vcpu, 3, amx_cfg, tiledata, xsavedata);
>+ /* XSAVE state for guest_code */
>+ xstate = vm_vaddr_alloc_pages(vm, DIV_ROUND_UP(XSAVE_SIZE, PAGE_SIZE));
>+ memset(addr_gva2hva(vm, xstate), 0, DIV_ROUND_UP(XSAVE_SIZE, PAGE_SIZE));
^ this should be the size in bytes instead of in pages. Right?
next prev parent reply other threads:[~2023-02-19 8:33 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-14 18:45 [PATCH v2 0/7] Overhauling amx_test Mingwei Zhang
2023-02-14 18:46 ` [PATCH v2 1/7] KVM: selftests: x86: Add a working xstate data structure Mingwei Zhang
2023-02-19 8:33 ` Chao Gao [this message]
2023-02-19 17:56 ` Mingwei Zhang
2023-02-14 18:46 ` [PATCH v2 2/7] KVM: selftests: x86: Fix an error in comment of amx_test Mingwei Zhang
2023-02-19 8:46 ` Chao Gao
2023-02-19 17:58 ` Mingwei Zhang
2023-02-14 18:46 ` [PATCH v2 3/7] KVM: selftests: x86: Add check of CR0.TS in the #NM handler in amx_test Mingwei Zhang
2023-02-17 22:01 ` Aaron Lewis
2023-02-18 0:57 ` Mingwei Zhang
2023-02-14 18:46 ` [PATCH v2 4/7] KVM: selftests: Add the XFD check to IA32_XFD in #NM handler Mingwei Zhang
2023-02-14 18:46 ` [PATCH v2 5/7] KVM: selftests: Fix the checks to XFD_ERR using and operation Mingwei Zhang
2023-02-14 18:46 ` [PATCH v2 6/7] KVM: selftests: x86: Enable checking on xcomp_bv in amx_test Mingwei Zhang
2023-02-14 18:46 ` [PATCH v2 7/7] KVM: selftests: x86: Repeat the checking of xheader when IA32_XFD[XTILEDATA] is set " Mingwei Zhang
2023-02-17 22:04 ` [PATCH v2 0/7] Overhauling amx_test Aaron Lewis
2023-02-18 0:58 ` Mingwei Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y/He1Sro3hb7Hn0h@gao-cwp \
--to=chao.gao@intel.com \
--cc=aaronlewis@google.com \
--cc=chang.seok.bae@intel.com \
--cc=jmattson@google.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=mizhang@google.com \
--cc=pbonzini@redhat.com \
--cc=seanjc@google.com \
--cc=venkateshs@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox