From: Petr Mladek <pmladek@suse.com>
To: Richard Fitzgerald <rf@opensource.cirrus.com>
Cc: rostedt@goodmis.org, sergey.senozhatsky@gmail.com,
andriy.shevchenko@linux.intel.com, linux@rasmusvillemoes.dk,
shuah@kernel.org, linux-kernel@vger.kernel.org,
linux-kselftest@vger.kernel.org, patches@opensource.cirrus.com
Subject: Re: [PATCH v8 RESEND 1/4] lib: vsprintf: scanf: Negative number must have field width > 1
Date: Thu, 20 May 2021 10:35:43 +0200 [thread overview]
Message-ID: <YKYfX5Vp+4onbIFj@alley> (raw)
In-Reply-To: <20210514161206.30821-1-rf@opensource.cirrus.com>
On Fri 2021-05-14 17:12:03, Richard Fitzgerald wrote:
> If a signed number field starts with a '-' the field width must be > 1,
> or unlimited, to allow at least one digit after the '-'.
>
> This patch adds a check for this. If a signed field starts with '-'
> and field_width == 1 the scanf will quit.
>
> It is ok for a signed number field to have a field width of 1 if it
> starts with a digit. In that case the single digit can be converted.
>
> Signed-off-by: Richard Fitzgerald <rf@opensource.cirrus.com>
> Reviewed-by: Petr Mladek <pmladek@suse.com>
> Acked-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
The entrire patchset has been committed into print/linux.git,
branch for-5.14-vsprintf-scanf.
Thanks for reminder. I am sorry. It somehow fallen from my radar.
Best Regards,
Petr
prev parent reply other threads:[~2021-05-20 8:35 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-14 16:12 [PATCH v8 RESEND 1/4] lib: vsprintf: scanf: Negative number must have field width > 1 Richard Fitzgerald
2021-05-14 16:12 ` [PATCH v8 RESEND 2/4] lib: vsprintf: Fix handling of number field widths in vsscanf Richard Fitzgerald
2021-05-14 16:12 ` [PATCH v8 RESEND 3/4] lib: test_scanf: Add tests for sscanf number conversion Richard Fitzgerald
2021-05-14 16:12 ` [PATCH v8 RESEND 4/4] selftests: lib: Add wrapper script for test_scanf Richard Fitzgerald
2021-05-20 8:35 ` Petr Mladek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YKYfX5Vp+4onbIFj@alley \
--to=pmladek@suse.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux@rasmusvillemoes.dk \
--cc=patches@opensource.cirrus.com \
--cc=rf@opensource.cirrus.com \
--cc=rostedt@goodmis.org \
--cc=sergey.senozhatsky@gmail.com \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox