Re: [V2 2/6] driver core: auxiliary bus: Add driver data helpers

Leon Romanovsky
2021-12-08T08:32:21Z

On Wed, Dec 08, 2021 at 08:07:39AM +0100, Greg KH wrote:
> On Wed, Dec 08, 2021 at 09:03:16AM +0200, Leon Romanovsky wrote:
> > On Tue, Dec 07, 2021 at 09:14:44AM -0800, David E. Box wrote:
> > > Adds get/set driver data helpers for auxiliary devices.
> > >
> > > Signed-off-by: David E. Box <david.e.box@linux.intel.com>
> > > Reviewed-by: Mark Gross <markgross@kernel.org>
> > > ---
> > > V2
> > > - No changes
> > >
> > > include/linux/auxiliary_bus.h | 10 ++++++++++
> > > 1 file changed, 10 insertions(+)
> >
> > I would really like to see an explanation why such obfuscation is really
> > needed. dev_*_drvdata() is a standard way to access driver data.
>
> Lots of busses have this helper. This is nothing new at all, and is
> nice to have. Look at all of the calls to dev_get_drvdata() in
> include/linux/ for the examples.

I looked and this is why I asked. From the point of person who does
reviews and refactoring, such obfuscations are evil.

If I understand your correctly, the explanation is just copy/paste, right?

Thanks

>
> thanks,
>
> greg k-h