From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Brendan Higgins <brendanhiggins@google.com>
Cc: linux-kselftest@vger.kernel.org, kunit-dev@googlegroups.com,
linux-kernel@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH v2 1/1] kunit: Replace kernel.h with the necessary inclusions
Date: Wed, 15 Dec 2021 15:56:24 +0200 [thread overview]
Message-ID: <Ybn0CMscKc/jBSSC@smile.fi.intel.com> (raw)
In-Reply-To: <CAFd5g47FXzwtnxOH_Qc3VsWnS2RBNEreVAepWPizboZTo4KRfw@mail.gmail.com>
On Tue, Dec 14, 2021 at 04:56:21PM -0500, Brendan Higgins wrote:
> On Mon, Dec 13, 2021 at 3:44 PM Andy Shevchenko
> <andriy.shevchenko@linux.intel.com> wrote:
> >
> > When kernel.h is used in the headers it adds a lot into dependency hell,
> > especially when there are circular dependencies are involved.
> >
> > Replace kernel.h inclusion with the list of what is really being used.
> >
> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
>
> Reviewed-by: Brendan Higgins <brendanhiggins@google.com>
> Tested-by: Brendan Higgins <brendanhiggins@google.com>
Thanks!
> > Andrew, please take it through your tree since KUnit maintainer is non-responsive
> > by unknown (to me) reasons.
>
> Sorry, I did not see the previous version of this patch.
Maybe you need to check your email settings and your domain MTA?
https://lore.kernel.org/linux-kselftest/20211110103552.60181-1-andriy.shevchenko@linux.intel.com/T/#u
> But this
> looks fine, and does not appear to break any tests.
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2021-12-15 13:57 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-13 20:44 [PATCH v2 1/1] kunit: Replace kernel.h with the necessary inclusions Andy Shevchenko
2021-12-14 21:56 ` Brendan Higgins
2021-12-15 13:56 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Ybn0CMscKc/jBSSC@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=akpm@linux-foundation.org \
--cc=brendanhiggins@google.com \
--cc=kunit-dev@googlegroups.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox