From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id DD033C433F5 for ; Thu, 10 Feb 2022 11:36:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240117AbiBJLgy (ORCPT ); Thu, 10 Feb 2022 06:36:54 -0500 Received: from mxb-00190b01.gslb.pphosted.com ([23.128.96.19]:39986 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235635AbiBJLgy (ORCPT ); Thu, 10 Feb 2022 06:36:54 -0500 Received: from sin.source.kernel.org (sin.source.kernel.org [IPv6:2604:1380:40e1:4800::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 83AE91001 for ; Thu, 10 Feb 2022 03:36:55 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sin.source.kernel.org (Postfix) with ESMTPS id E85F0CE22F9 for ; Thu, 10 Feb 2022 11:36:53 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7B049C004E1; Thu, 10 Feb 2022 11:36:49 +0000 (UTC) Date: Thu, 10 Feb 2022 11:36:46 +0000 From: Catalin Marinas To: Mark Brown Cc: Will Deacon , Marc Zyngier , Shuah Khan , Shuah Khan , Alan Hayward , Luis Machado , Salil Akerkar , Basant Kumar Dwivedi , Szabolcs Nagy , James Morse , Alexandru Elisei , Suzuki K Poulose , linux-arm-kernel@lists.infradead.org, linux-kselftest@vger.kernel.org, kvmarm@lists.cs.columbia.edu Subject: Re: [PATCH v11 02/40] arm64: Always use individual bits in CPACR floating point enables Message-ID: References: <20220207152109.197566-1-broonie@kernel.org> <20220207152109.197566-3-broonie@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220207152109.197566-3-broonie@kernel.org> Precedence: bulk List-ID: X-Mailing-List: linux-kselftest@vger.kernel.org On Mon, Feb 07, 2022 at 03:20:31PM +0000, Mark Brown wrote: > CPACR_EL1 has several bitfields for controlling traps for floating point > features to EL1, each of which has a separate bits for EL0 and EL1. Marc > Zyngier noted that we are not consistent in our use of defines to > manipulate these, sometimes using a define covering the whole field and > sometimes using defines for the individual bits. Make this consistent by > expanding the whole field defines where they are used (currently only in > the KVM code) and deleting them so that no further uses can be > introduced. > > Suggested-by: Marc Zyngier > Signed-off-by: Mark Brown Acked-by: Catalin Marinas