From: Hangbin Liu <liuhangbin@gmail.com>
To: Yun Lu <luyun_611@163.com>
Cc: willemb@google.com, davem@davemloft.net, edumazet@google.com,
willemdebruijn.kernel@gmail.com, liuyun01@kylinos.cn,
netdev@vger.kernel.org, linux-kselftest@vger.kernel.org
Subject: Re: [PATCH v2] selftests/net: enable lo.accept_local in psock_snd test
Date: Wed, 25 May 2022 15:20:01 +0800 [thread overview]
Message-ID: <Yo3YoZWRkygFyqUc@Laptop-X1> (raw)
In-Reply-To: <20220525031819.866684-1-luyun_611@163.com>
On Wed, May 25, 2022 at 11:18:19AM +0800, Yun Lu wrote:
> From: luyun <luyun@kylinos.cn>
>
> The psock_snd test sends and recieves packets over loopback, and
> the test results depend on parameter settings:
> Set rp_filter=0,
> or set rp_filter=1 and accept_local=1
> so that the test will pass. Otherwise, this test will fail with
> Resource temporarily unavailable:
> sudo ./psock_snd.sh
> dgram
> tx: 128
> rx: 142
> ./psock_snd: recv: Resource temporarily unavailable
>
> For most distro kernel releases(like Ubuntu or Centos), the parameter
> rp_filter is enabled by default, so it's necessary to enable the
> parameter lo.accept_local in psock_snd test. And this test runs
> inside a netns, changing a sysctl is fine.
>
> v2: add detailed description.
>
> Suggested-by: Willem de Bruijn <willemdebruijn.kernel@gmail.com>
> Signed-off-by: luyun <luyun@kylinos.cn>
> Reviewed-by: Jackie Liu <liuyun01@kylinos.cn>
> ---
> tools/testing/selftests/net/psock_snd.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/tools/testing/selftests/net/psock_snd.c b/tools/testing/selftests/net/psock_snd.c
> index 7d15e10a9fb6..edf1e6f80d41 100644
> --- a/tools/testing/selftests/net/psock_snd.c
> +++ b/tools/testing/selftests/net/psock_snd.c
> @@ -389,6 +389,8 @@ int main(int argc, char **argv)
> error(1, errno, "ip link set mtu");
> if (system("ip addr add dev lo 172.17.0.1/24"))
> error(1, errno, "ip addr add");
> + if (system("sysctl -w net.ipv4.conf.lo.accept_local=1"))
> + error(1, errno, "sysctl lo.accept_local");
>
> run_test();
>
> --
> 2.25.1
Great, this also fixed my problem. Please feel free to add my
Tested-by: Hangbin Liu <liuhangbin@gmail.com>
next prev parent reply other threads:[~2022-05-25 7:20 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-25 3:18 [PATCH v2] selftests/net: enable lo.accept_local in psock_snd test Yun Lu
2022-05-25 7:20 ` Hangbin Liu [this message]
2022-05-25 12:34 ` Willem de Bruijn
2022-05-26 5:10 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yo3YoZWRkygFyqUc@Laptop-X1 \
--to=liuhangbin@gmail.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=linux-kselftest@vger.kernel.org \
--cc=liuyun01@kylinos.cn \
--cc=luyun_611@163.com \
--cc=netdev@vger.kernel.org \
--cc=willemb@google.com \
--cc=willemdebruijn.kernel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox