From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 03B7FC43334 for ; Thu, 7 Jul 2022 23:10:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236815AbiGGXK5 (ORCPT ); Thu, 7 Jul 2022 19:10:57 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54558 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230076AbiGGXK4 (ORCPT ); Thu, 7 Jul 2022 19:10:56 -0400 Received: from mail-pl1-x629.google.com (mail-pl1-x629.google.com [IPv6:2607:f8b0:4864:20::629]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8CB2360510 for ; Thu, 7 Jul 2022 16:10:55 -0700 (PDT) Received: by mail-pl1-x629.google.com with SMTP id d5so14897178plo.12 for ; Thu, 07 Jul 2022 16:10:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=TqoITV2pKW32A4dt41SN4K/+XbRSwwvZNic7w5oXhBA=; b=aYs3bZQ1BCJjjPgBnSRGEbYaFkv+Iv8EEgeOrHKNmoqqEiSsZ0LdFntkloSGbcUeUU fiJGTQ28PCl7Xn2j8DwMdxNYmLnKoroRrcA27UO9bNBKSStsrGG1cKHfJBBHW3jm1xyx URvyw5cWZ+5kBh1emLqGyhQXGVptCWZhAQrt2DFw8ufP1eA598eMG4zaF6Qo2IXjV+ze Kz11jUYpa5gt+XubsghdEqVLuTNSF16rESYQO6Hd+b3KwkcwlEZ3UCmSEls3dxXmWOLv sDrLZudS/HntODg5hMKDeCp9zlcxNcvN01iz1xzuXct6/WYslFmfOaJUmR7j5Q3R4NO7 h7fg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=TqoITV2pKW32A4dt41SN4K/+XbRSwwvZNic7w5oXhBA=; b=heJYHFOkkEv6Kbxba3H50VooN/ITmrZ4wExt6H6ladBI1GVBP9GGN1Jr4hCum6H4I+ CBMMuPxbT/GKCW4PNxoue6VYQEVzQLf6Lg5uuzmsofIVpxH41y+bKB1DIIEBx/askqxw Zr6k0ugu+zFdmbWDTjCH/lJ9ekT1DtvDYjeUPNwIZi3BVEJb4azUgIr4rD4GBWjKrBtq PhTVp4k3MugvRvkDYmKym8MzttOS5ZAR0bKg81Cdazm1uSrWMzKVwmKTG064243hhGRT EAd/LRHiD8c1UsMjT3O0oKhjaOOqgTsqx5HI9zUT1+Fcwj6AZ47yPj7ovZ7ZgRDRxuh7 rVDA== X-Gm-Message-State: AJIora/KqmV4fWXrh93lwCDZpzvZ7zi1KbojH8AWOLP9eLcE/3WmUrL3 rZE8vuHHACmXjleVD/P2xvdDFA== X-Google-Smtp-Source: AGRyM1uZIJNZXUsYe+zR0XtBe4h3Xn2PoOIdAia3O5yVwvGe6Wp2msoXjkxftcPAEWGr9UWTwdot4Q== X-Received: by 2002:a17:90b:1c02:b0:1ed:4bfb:7772 with SMTP id oc2-20020a17090b1c0200b001ed4bfb7772mr8300513pjb.139.1657235455012; Thu, 07 Jul 2022 16:10:55 -0700 (PDT) Received: from google.com (123.65.230.35.bc.googleusercontent.com. [35.230.65.123]) by smtp.gmail.com with ESMTPSA id l189-20020a6225c6000000b005255263a864sm27556291pfl.169.2022.07.07.16.10.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 07 Jul 2022 16:10:54 -0700 (PDT) Date: Thu, 7 Jul 2022 23:10:50 +0000 From: Sean Christopherson To: Gautam Menghani Cc: pbonzini@redhat.com, shuah@kernel.org, yang.zhong@intel.com, jmattson@google.com, peterx@redhat.com, guang.zeng@intel.com, wei.w.wang@intel.com, dmatlack@google.com, vkuznets@redhat.com, kvm@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-kernel-mentees@lists.linuxfoundation.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] selftests/kvm: Add error messages before skipping tests in vm_xsave_req_perm() Message-ID: References: <20220704163538.31165-1-gautammenghani201@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220704163538.31165-1-gautammenghani201@gmail.com> Precedence: bulk List-ID: X-Mailing-List: linux-kselftest@vger.kernel.org On Mon, Jul 04, 2022, Gautam Menghani wrote: > Add messages in the checks that are performed before making a request > with ARCH_REQ_XCOMP_GUEST_PERM. > > Signed-off-by: Gautam Menghani > --- > tools/testing/selftests/kvm/lib/x86_64/processor.c | 8 ++++++-- > 1 file changed, 6 insertions(+), 2 deletions(-) > > diff --git a/tools/testing/selftests/kvm/lib/x86_64/processor.c b/tools/testing/selftests/kvm/lib/x86_64/processor.c > index ead7011ee8f6..c74e846661b7 100644 > --- a/tools/testing/selftests/kvm/lib/x86_64/processor.c > +++ b/tools/testing/selftests/kvm/lib/x86_64/processor.c > @@ -643,11 +643,15 @@ void vm_xsave_req_perm(int bit) > if (rc == -1 && (errno == ENXIO || errno == EINVAL)) > exit(KSFT_SKIP); > TEST_ASSERT(rc == 0, "KVM_GET_DEVICE_ATTR(0, KVM_X86_XCOMP_GUEST_SUPP) error: %ld", rc); > - if (!(bitmask & (1ULL << bit))) > + if (!(bitmask & (1ULL << bit))) { > + print_skip("Userspace address of attr data is blank"); > exit(KSFT_SKIP); > + } > > - if (!is_xfd_supported()) > + if (!is_xfd_supported()) { > + print_skip("XFD is not supported"); > exit(KSFT_SKIP); > + } This is no longer necessary as of commit 7ed397d107d4 ("KVM: selftests: Add TEST_REQUIRE macros to reduce skipping copy+paste"), which will automagically print the missing requirement before calling exit(). Thanks much for the patch though!