Linux Kernel Selftest development
 help / color / mirror / Atom feed
From: Dan Carpenter <dan.carpenter@oracle.com>
To: amit.kachhap@arm.com
Cc: linux-kselftest@vger.kernel.org
Subject: [bug report] kselftest/arm64: Add utilities and a test to validate mte memory
Date: Mon, 18 Jul 2022 17:47:44 +0300	[thread overview]
Message-ID: <YtVykH0CIFM9bw2E@kili> (raw)

Hello Amit Daniel Kachhap,

The patch e9b60476bea0: "kselftest/arm64: Add utilities and a test to
validate mte memory" from Oct 2, 2020, leads to the following Smatch
static checker warning:

	./tools/testing/selftests/arm64/mte/mte_common_util.c:336 mte_default_setup()
	warn: bitwise AND condition is false here

./tools/testing/selftests/arm64/mte/mte_common_util.c
    316 int mte_default_setup(void)
    317 {
    318         unsigned long hwcaps2 = getauxval(AT_HWCAP2);
    319         unsigned long en = 0;
    320         int ret;
    321 
    322         if (!(hwcaps2 & HWCAP2_MTE)) {
    323                 ksft_print_msg("SKIP: MTE features unavailable\n");
    324                 return KSFT_SKIP;
    325         }
    326         /* Get current mte mode */
    327         ret = prctl(PR_GET_TAGGED_ADDR_CTRL, en, 0, 0, 0);
    328         if (ret < 0) {
    329                 ksft_print_msg("FAIL:prctl PR_GET_TAGGED_ADDR_CTRL with error =%d\n", ret);
    330                 return KSFT_FAIL;
    331         }
    332         if (ret & PR_MTE_TCF_SYNC)
    333                 mte_cur_mode = MTE_SYNC_ERR;
    334         else if (ret & PR_MTE_TCF_ASYNC)
    335                 mte_cur_mode = MTE_ASYNC_ERR;
--> 336         else if (ret & PR_MTE_TCF_NONE)

It looks like the intent was to make PR_MTE_TCF_NONE into an ifdef
configurable thing but that never happened?

    337                 mte_cur_mode = MTE_NONE_ERR;
    338 
    339         mte_cur_pstate_tco = mte_get_pstate_tco();
    340         /* Disable PSTATE.TCO */
    341         mte_disable_pstate_tco();
    342         return 0;
    343 }

regards,
dan carpenter

             reply	other threads:[~2022-07-18 14:48 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-18 14:47 Dan Carpenter [this message]
2022-07-19 12:44 ` [bug report] kselftest/arm64: Add utilities and a test to validate mte memory Amit Kachhap

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YtVykH0CIFM9bw2E@kili \
    --to=dan.carpenter@oracle.com \
    --cc=amit.kachhap@arm.com \
    --cc=linux-kselftest@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox