From: Peter Xu <peterx@redhat.com>
To: Gavin Shan <gshan@redhat.com>
Cc: Marc Zyngier <maz@kernel.org>,
kvmarm@lists.cs.columbia.edu, kvm@vger.kernel.org,
linux-doc@vger.kernel.org, catalin.marinas@arm.com,
linux-kselftest@vger.kernel.org, bgardon@google.com,
shuah@kernel.org, corbet@lwn.net, drjones@redhat.com,
will@kernel.org, zhenyzha@redhat.com, dmatlack@google.com,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, pbonzini@redhat.com,
oliver.upton@linux.dev, shan.gavin@gmail.com
Subject: Re: [PATCH v2 1/5] KVM: x86: Introduce KVM_REQ_RING_SOFT_FULL
Date: Mon, 19 Sep 2022 12:17:02 -0400 [thread overview]
Message-ID: <YyiV/l7O23aw5aaO@xz-m1.local> (raw)
In-Reply-To: <a2e0b9bc-2c67-8683-d722-7298bd65058c@redhat.com>
On Mon, Sep 19, 2022 at 09:58:10AM +1000, Gavin Shan wrote:
> I think Marc's explanation makes sense. It won't make difference in terms
> of performance. We need to explicitly handle barrier when kvm_test_request()
> is used. So I prefer to keep the code if Peter agrees.
No strong opinion here. I keep thinking clear+set look awkward even if it's
unlikely path to trigger (ring should be recycled when reaching here for
any sane user app), but if it's already 2:1 then please go ahead. :)
Thanks,
--
Peter Xu
next prev parent reply other threads:[~2022-09-19 16:17 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-16 4:51 [PATCH v2 0/5] KVM: arm64: Enable ring-based dirty memory tracking Gavin Shan
2022-09-16 4:51 ` [PATCH v2 1/5] KVM: x86: Introduce KVM_REQ_RING_SOFT_FULL Gavin Shan
2022-09-16 18:09 ` Peter Xu
2022-09-18 9:00 ` Marc Zyngier
2022-09-18 23:58 ` Gavin Shan
2022-09-19 9:22 ` Marc Zyngier
2022-09-19 16:17 ` Peter Xu [this message]
2022-09-16 4:51 ` [PATCH v2 2/5] KVM: arm64: Enable ring-based dirty memory tracking Gavin Shan
2022-09-17 15:10 ` kernel test robot
2022-09-19 1:27 ` Gavin Shan
2022-09-16 4:51 ` [PATCH v2 3/5] KVM: selftests: Use host page size to map ring buffer in dirty_log_test Gavin Shan
2022-09-16 4:51 ` [PATCH v2 4/5] KVM: selftests: Clear dirty ring states between two modes " Gavin Shan
2022-09-16 4:51 ` [PATCH v2 5/5] KVM: selftests: Automate choosing dirty ring size " Gavin Shan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YyiV/l7O23aw5aaO@xz-m1.local \
--to=peterx@redhat.com \
--cc=bgardon@google.com \
--cc=catalin.marinas@arm.com \
--cc=corbet@lwn.net \
--cc=dmatlack@google.com \
--cc=drjones@redhat.com \
--cc=gshan@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=kvmarm@lists.cs.columbia.edu \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=maz@kernel.org \
--cc=oliver.upton@linux.dev \
--cc=pbonzini@redhat.com \
--cc=shan.gavin@gmail.com \
--cc=shuah@kernel.org \
--cc=will@kernel.org \
--cc=zhenyzha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox