From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f201.google.com (mail-pl1-f201.google.com [209.85.214.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 07FFB1F9A98 for ; Wed, 18 Dec 2024 18:23:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734546232; cv=none; b=Q211Ee64kJbjFuWU53QepO/7B/kPpU4uf7oRjs88oozUEAwJ7JgKpjWTG/3eFNu1PyfOT58bNob+R6jQlPwixkq/9fDjktHRLA9EJFFeziUJ4my8oBPFCxtPMuOspca0xPciHwO7fxCRiyheI2GatimIJtYuqNX3GZt17AT4ro8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734546232; c=relaxed/simple; bh=EeR9KqIYhEJFkzMfRCbIc/g9z9lvZXqPbiNegt1dWew=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=hQsjMIKiNnR26wxI++c1J4plDb4I8FBQL19bNqHKyzQMsloa5L9se/1UGZpcTwV42HwP0c61x+5L3wpXii7dXdcJ/C6SsHf1HMiHsfURyAHW3UUzl0RncUggy4LKtpPYJHd6iKnm695DXtPT78rUZwgbgPMOtCROtgve/rZgJAY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--seanjc.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=VT3zVTqs; arc=none smtp.client-ip=209.85.214.201 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--seanjc.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="VT3zVTqs" Received: by mail-pl1-f201.google.com with SMTP id d9443c01a7336-216717543b7so63835ad.0 for ; Wed, 18 Dec 2024 10:23:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1734546230; x=1735151030; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=RmkzlEVKsyHe3S3v/tp8qCiCvai6YjJH4HUuQciU4ok=; b=VT3zVTqsp6V+pixCx2+Fwq4ZE8IYt5AqHpI3LaiR1HlYWaI8ROG5zVweTrzDov2vEl p5Dw2NaePB3vydd99a+fyqd0cdty4wnu2r9WBZATW7MgVqgNHg7ErkTcgfklq6iQPmPW Og5JfC3dyf3X0QwCvGXWIGjjCGT2OSuFPnyxxCIYNhonRldsjA908dzBDt3Khu6I6Q/5 bT2WpSqGcn+zRA+vjc/UQE428/c1x3k4PXZeVI07o2EqutlBrSvY9P8y4jEAmcIihWBL b0cKFDQoDfUpqIG2Ys74lyhn4E8wJRrIKdYc1MQcD0+tlLogkLITAtQQSgY/R5jDtiQ4 6mFw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1734546230; x=1735151030; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=RmkzlEVKsyHe3S3v/tp8qCiCvai6YjJH4HUuQciU4ok=; b=BlRDVUpODD/emSovT9aWPPU+nm9c+gUDxZxKLDiFG2XKMDMX8uHyr0wuPz+82wt9R5 TQleo+tcZlL9Qh8BO5Vmsn3VjZLDpv4MZ6Y6MxWxLNdq7nn7/PUwqnBDX7Q4hhxckI7F uTeQt2uShe7eK0VVNJD5935Xrweg7M0Xmvru5v4yCwKziKb7bpgkd19QOS2IJ0RY8zw0 hAeUfG+7oX+EGfPscm/d3sy4+IWn/uMtbiAdsSNZnjIKI3TqrMufP5rU5qRsjbVCXhvJ nh5K+7V4YgcSi5YORnubTky4EWr1pYzZulJ2sxRBTqdPFnX3sg4AUjsUNwv/85vnj/5v zfgQ== X-Forwarded-Encrypted: i=1; AJvYcCXrCmSWSgVKwY/imOF/+4PhDgdSXhK1dtRE8AB8sRZwYucpK9NjtBN0mR75kBOOt6fmPzohS2vX+w+r9StnQxQ=@vger.kernel.org X-Gm-Message-State: AOJu0YycnUfT6nXU0wBlQPzv6mUXOaYKF123xXY3CT9dp2l5LSRRj0L0 J+zAlMjtDbK0VwgwU5KDKSq2/jK+JzfqCB+oD9CFxYc5ynzWnXf4mA/XL3WDw+QsivLTkgsev+A fSw== X-Google-Smtp-Source: AGHT+IHZ/azbCeXLSE2Q4wDj7TyAPz+scx9lnjO+Wu2rIQp2gHgfQHL40ooMY9toxGXzQou8xzhloeGtppg= X-Received: from pgdm11.prod.google.com ([2002:a63:8c0b:0:b0:7fd:3f0e:ce05]) (user=seanjc job=prod-delivery.src-stubby-dispatcher) by 2002:a17:902:ef4e:b0:216:1357:8df8 with SMTP id d9443c01a7336-219d96d21d1mr8914495ad.43.1734546230384; Wed, 18 Dec 2024 10:23:50 -0800 (PST) Date: Wed, 18 Dec 2024 10:23:49 -0800 In-Reply-To: <20241217181458.68690-3-iorlov@amazon.com> Precedence: bulk X-Mailing-List: linux-kselftest@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20241217181458.68690-1-iorlov@amazon.com> <20241217181458.68690-3-iorlov@amazon.com> Message-ID: Subject: Re: [PATCH v3 2/7] KVM: x86: Add emulation status for unhandleable vectoring From: Sean Christopherson To: Ivan Orlov Cc: bp@alien8.de, dave.hansen@linux.intel.com, mingo@redhat.com, pbonzini@redhat.com, shuah@kernel.org, tglx@linutronix.de, hpa@zytor.com, kvm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, x86@kernel.org, dwmw@amazon.co.uk, pdurrant@amazon.co.uk, jalliste@amazon.co.uk Content-Type: text/plain; charset="us-ascii" On Tue, Dec 17, 2024, Ivan Orlov wrote: > Add emulation status for unhandleable vectoring, i.e. when KVM can't > emulate an instruction during vectoring. Such a situation can occur > if guest sets the IDT descriptor base to point to MMIO region, and > triggers an exception after that. > > Exit to userspace with event delivery error when KVM can't emulate > an instruction when vectoring an event. > > Signed-off-by: Ivan Orlov > --- > V1 -> V2: > - This patch wasn't included in V1. > V2 -> V3: > - Make new X86EMUL_ code more generic to allow using it for any type > of unhandleable vectoring > > arch/x86/kvm/kvm_emulate.h | 2 ++ > arch/x86/kvm/x86.c | 5 +++++ > 2 files changed, 7 insertions(+) > > diff --git a/arch/x86/kvm/kvm_emulate.h b/arch/x86/kvm/kvm_emulate.h > index 10495fffb890..5bcf50ffc3de 100644 > --- a/arch/x86/kvm/kvm_emulate.h > +++ b/arch/x86/kvm/kvm_emulate.h > @@ -88,6 +88,8 @@ struct x86_instruction_info { > #define X86EMUL_CMPXCHG_FAILED 4 /* cmpxchg did not see expected value */ > #define X86EMUL_IO_NEEDED 5 /* IO is needed to complete emulation */ > #define X86EMUL_INTERCEPTED 6 /* Intercepted by nested VMCB/VMCS */ > +/* Vectroing can't be emulated */ Typo. I think it's also worth elaborating a bit, e.g. /* Emulation during event vectoring is unsupported */ > +#define X86EMUL_UNHANDLEABLE_VECTORING 7 > > /* x86-specific emulation flags */ > #define X86EMUL_F_WRITE BIT(0) > diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c > index 7ce9cdb66f19..849a6fc364b3 100644 > --- a/arch/x86/kvm/x86.c > +++ b/arch/x86/kvm/x86.c > @@ -9107,6 +9107,11 @@ int x86_emulate_instruction(struct kvm_vcpu *vcpu, gpa_t cr2_or_gpa, > if (r == X86EMUL_RETRY_INSTR || r == X86EMUL_PROPAGATE_FAULT) > return 1; > > + if (r == X86EMUL_UNHANDLEABLE_VECTORING) { > + kvm_prepare_event_vectoring_exit(vcpu, cr2_or_gpa); > + return 0; > + } > + > WARN_ON_ONCE(r != X86EMUL_UNHANDLEABLE); > return handle_emulation_failure(vcpu, emulation_type); > } > -- > 2.43.0 >