From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f202.google.com (mail-pf1-f202.google.com [209.85.210.202]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9EDDA12E7F for ; Fri, 20 Dec 2024 00:42:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.202 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734655378; cv=none; b=JOW0gg8ahyXRipDgjQEI9F7c1NlyDdgrSRv3QkmUhSfVADhXGVsg7T42zbJ+JijUrG5K+eKWNPov07cB6SUlnZedA69z2rh9NUaMIlhLkNn9X6KecdUC7UBABDBpFsY2/9a3GosDk7u4k+MIghqoVPWEzNO0VaLF6dOHF33Sp6Y= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734655378; c=relaxed/simple; bh=25NIKixz8K4axw9MJEzYs4LYM7ccJYCm1Otv6fpECMY=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=JwuJlBpPrBo2SegJAPQytyAFotulbcm7G0Y0woYtgHTkwAwuRGJcUOgShAm7EHqP/0dFoAFGHw5rvHUmohllJ+ml0rX9Fvoc/cpUgRNVLF/dafd9OTGDR2ig8GdHeAKoH1beK4pu567gPWs9Bp+THCCNXJuHUoRtqNoA58/FpJU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--seanjc.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=IbRAchTi; arc=none smtp.client-ip=209.85.210.202 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--seanjc.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="IbRAchTi" Received: by mail-pf1-f202.google.com with SMTP id d2e1a72fcca58-725cab4d72bso1080337b3a.2 for ; Thu, 19 Dec 2024 16:42:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1734655376; x=1735260176; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=PodBoS32b54JsAl9pHLeWDR36CNehvCvEoxh9C8d01U=; b=IbRAchTiCqg4Qp7jr9xp25S2O23vh1FzfxPm2YwsXne8CsSK0sU+jDswB3XSxcORp8 gHRfQbiNkZ+LmvYTlLZ8UkZRCRJhmuK26ZyPvE86/+yHpuU04EN8qr8x3xuscBiVwVQo aa+6U9b8knyBk07qdFdv01fJ/0LFsDojcUJQftrHYfSrLiv0137Y3Sqmm8S9un6N+FVM yNNwYNch4CjTj26wdtj1VzP17hqjZ5KQBrWn8H5j2S7YFtBCrRufZ+TCiAZkmssLxB/j t4jf0tOFQByiVtZUSuqWCtZ0p9Suho7kx9cjHuUWyHrzEVIW7KWB0DXVq3GC7vLOmQ7e 2fjw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1734655376; x=1735260176; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=PodBoS32b54JsAl9pHLeWDR36CNehvCvEoxh9C8d01U=; b=f2iFUzLbFKRcGKsEiDeElYzoLwljxES1eB25kp0n0lX9sHpPfN/1KiB6z4nMMNmYaY qPGijLYmRBPZGqHJFIZzJ2lRYqWicoK5mgQf5oteKwjv3xrf3xnTrKLoKtfxZDVC0mME K6+694kSWyFYffaAW4hddQwQrQQAN/s+KZTf6Gd6MdbNMawK5zu+LpNkzhenuLQ5HtRd zMD0HQOwbnqjhsbkUDwA1qTscWf1Nb/4zz54pb8fMsY7cYnjndIFBtL2XJ1kUjBUEiLq uacJFoqXgQN2F/o9Kvu+RoFGaFBNQM2PTyvvabjgSc48IEZZE6Z2slJGg+LsxBDCImAe Tx5g== X-Forwarded-Encrypted: i=1; AJvYcCX3uEzIgpvqw1TVhqnePivUf3ysEBgfOBPfbB7ZO7dhrhHrW20Zw7D5H/psLvIeNEnES8MrLg+bcePChF0b0zc=@vger.kernel.org X-Gm-Message-State: AOJu0Yx8jYK/wVzYjR7jA6bF1ek3tmImLZPfPZuWNB3InTAQz8TKMhsb cPXTxOSn9rq+Eag6Lo3+x0lmrFoUaWJr/uyQP7QrMCYaPQD/s3m9BLcn/mNKbuWf2RmfEaDn+Ld 0nw== X-Google-Smtp-Source: AGHT+IEt8kAq9sioD+Me+qBGwD4EU4WFuNQ4mfX3J0g1amYpO/cLV/NmsfvUlW22Te2QeDhhN7gjHMX6WaY= X-Received: from pfbbw10.prod.google.com ([2002:a05:6a00:408a:b0:725:e84a:dd51]) (user=seanjc job=prod-delivery.src-stubby-dispatcher) by 2002:a05:6a00:32cb:b0:729:1c0f:b957 with SMTP id d2e1a72fcca58-72abded050amr1203427b3a.25.1734655376034; Thu, 19 Dec 2024 16:42:56 -0800 (PST) Date: Thu, 19 Dec 2024 16:42:54 -0800 In-Reply-To: <20241021062226.108657-5-manali.shukla@amd.com> Precedence: bulk X-Mailing-List: linux-kselftest@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20241021062226.108657-1-manali.shukla@amd.com> <20241021062226.108657-5-manali.shukla@amd.com> Message-ID: Subject: Re: [PATCH v1 4/4] KVM: selftests: Replace previously used vm_get_stat() to macro From: Sean Christopherson To: Manali Shukla Cc: kvm@vger.kernel.org, linux-kselftest@vger.kernel.org, pbonzini@redhat.com, shuah@kernel.org, nikunj@amd.com Content-Type: text/plain; charset="us-ascii" On Mon, Oct 21, 2024, Manali Shukla wrote: > Compile tested both the selftests. To be very blunt, not actually testing changes of this nature isn't acceptable. The HugeTLB dependency of dirty_log_page_splitting_test makes it annoying to run, as does the root user dependency of nx_huge_pages_test.sh, but I wouldn't say that running them is hard. It's a-ok to not fully test code when you don't have the necessary hardware, configuration, etc., but generally speaking the expectation is that you test the code you post. > static void get_page_stats(struct kvm_vm *vm, struct kvm_page_stats *stats, const char *stage) > { > - stats->pages_4k = vm_get_stat(vm, "pages_4k"); > - stats->pages_2m = vm_get_stat(vm, "pages_2m"); > - stats->pages_1g = vm_get_stat(vm, "pages_1g"); > + stats->pages_4k = vm_get_stat(vm, pages_4k); > + stats->pages_2m = vm_get_stat(vm, pages_2m); > + stats->pages_1g = vm_get_stat(vm, pages_1g); Converting vm_get_stats() to a macro, or rather, changing its parameter to do token pasting, absolutely must update all users at the same time. With only the previous patch applied, the affected tests fail because they try to get stats for the string "\"\"".