From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f46.google.com (mail-wr1-f46.google.com [209.85.221.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 716C618FDC8 for ; Mon, 20 Jan 2025 16:07:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.46 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737389226; cv=none; b=NUkGg0liauPXpKsYACj3vCLsC/VP91YnyjvzxqthNAffrWkjOKzfmw+gMTuU74OPNsFY3pAvE4CzduAYzP4dXxgCufoCpuGC5/CxkP2zBKQpudo8Pn7mA2HRzXTfs2BRV9/TQE89Bu9+kl2xwinHnwjufAkXCeOlp6Fb/O6YZ4w= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737389226; c=relaxed/simple; bh=xJGsasntfSsdEyCTjSTe+dS44QgKBn6VDNudjx7WRPk=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=KuOUsy1dnQPe1H40ZrFOqTkZIywKwcy3S8fLInwbuR8Fs/CzciOkTwqY+FyJMm7OnyVjKqOLzHXASkW/A0hGBqU2yBB++FgUtBKAb5cdYprv6IJm6PO72qRxEnHAmRLR165GTIYeatNYOCHgTOeWn9BbsRAYH3xb/EuqwfZYcPw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b=C1R8ISwS; arc=none smtp.client-ip=209.85.221.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b="C1R8ISwS" Received: by mail-wr1-f46.google.com with SMTP id ffacd0b85a97d-388cae9eb9fso2618287f8f.3 for ; Mon, 20 Jan 2025 08:07:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1737389221; x=1737994021; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=w2kqVj/vNWaOIWjGL7Wo52uGPlsoab4Shov7lcOaDwM=; b=C1R8ISwSBREaHKeq42QeJo3ZyNzXyGy9GljDtZ1MTiPH+aRC1PQMU6Pf+7K0Ebiv+d jA3xan3LTWdgriimx+hDWQM+VkZOaB6gbyuw+aaWKU1oqH0OSjXEYlG2G8ACL2Bg02gt qhPF788+1rnc3wCcUX4JjK2TWMzpESmUQs3pcWTLoP0hUv3CDcj+ApNFCtqdJt52k07s 1CoNF6bSXNcSXLG4MTe2IbogVU7oz03B4EcF+a+kCxU792Z3sSqmzn+IlDrgjY6bKdKA x9bFPv1h7nCedZKRqc2mXEvPZAqiYrULyyen+/LDy1v9pKP0ltZYAzzOed+O1Bh+slAP fd0Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1737389221; x=1737994021; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=w2kqVj/vNWaOIWjGL7Wo52uGPlsoab4Shov7lcOaDwM=; b=PMxWDksYBRGCQiMKqxCvCaUjDp4hCke4e2eae2AaZe1zOBq84Ux/mBkjhUN1egk5Ey XsIuGG3K7E+p8ILcwwPyK8W2VZzUVZQJItxht/3uVBFTo7ivBIyzJBvPF9LONWWwVqV5 H30qoXCPiESboOjiNhPlMwzDamEGKRCyR9vGV21LAnWYEjfCCx1z2je+OJYCBCd2Zs80 EPri4SYhy2a9ERDZbOqzg+bmBKJJRGwFxwbO2ZEMmW+S8vIxjI7ovj0tRVV293x24TiJ d9PZqpLUdxhwoeo7qoxnv3MDvxHijOjAE7Vy8uADgxJWRdSWvFe6aZAv/EVHN7+yfeMk mnUg== X-Forwarded-Encrypted: i=1; AJvYcCWn6sa5m7NbXzbYmxva8ETtKtlLgDWoDd9UbXtU65qVXAjV4P5Ob0Pi+HUGoIbGmX8OGzA5sYOb2vVw1aD0FVc=@vger.kernel.org X-Gm-Message-State: AOJu0YwYqk/MmgeWhPdQdtrQNkG8/ZsyJqDLPyP++sHtAC3GUsOxvHBR QgEkmCnEwFrHbLM7u/zb0h/jNXSYWliB8i0BVykmUstuDURkk4Sy2jtTg1b18rE= X-Gm-Gg: ASbGncvx8BbywN5mosvEwAef49qT32s0bbOl5KjMo6Nm8eSOkQGztjYeNflXUNLxRIJ 83f31lnGBH9CrA+rvc7aN5Uz5l3Mgx4uUOymvbQsq/dsYE3RtVPu/2VovaOR4nAOzd12Fyxe9Rw fwVOCgddLVjd8wHlRxcspXUr7xHRs/nr7vF1bW1rhLnPx3iEmn2rgpt69kNx2rWU1rADvq4sPQH MOHGA5twvf8pq4Wqdfh/M9fEvUmiKjjSsd/HXZ2hp0LF1C0FGuGl/BnOcx/llE3TitYing= X-Google-Smtp-Source: AGHT+IHblmvdT66NUAONbYDv1+zr0khDyHKPPgNGnZvOkmFzzDFs2TXnIxu6R3PeoRXgYqp5XmXoeg== X-Received: by 2002:a05:6000:1548:b0:385:f19f:5a8f with SMTP id ffacd0b85a97d-38bf5655594mr10417912f8f.4.1737389220704; Mon, 20 Jan 2025 08:07:00 -0800 (PST) Received: from pathway.suse.cz ([176.114.240.50]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-437c74c4751sm202802545e9.19.2025.01.20.08.06.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Jan 2025 08:07:00 -0800 (PST) Date: Mon, 20 Jan 2025 17:06:58 +0100 From: Petr Mladek To: Madhavan Srinivasan Cc: jikos@kernel.org, mbenes@suse.cz, joe.lawrence@redhat.com, shuah@kernel.org, mpe@ellerman.id.au, npiggin@gmail.com, christophe.leroy@csgroup.eu, naveen@kernel.org, live-patching@vger.kernel.org, linux-kselftest@vger.kernel.org, linuxppc-dev@lists.ozlabs.org Subject: Re: [PATCH v2] selftests: livepatch: handle PRINTK_CALLER in check_result() Message-ID: References: <20250119163238.749847-1-maddy@linux.ibm.com> Precedence: bulk X-Mailing-List: linux-kselftest@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250119163238.749847-1-maddy@linux.ibm.com> On Sun 2025-01-19 22:02:38, Madhavan Srinivasan wrote: > Some arch configs (like ppc64) enable CONFIG_PRINTK_CALLER, > which adds the caller id as part of the dmesg. With recent > util-linux's update 467a5b3192f16 ('dmesg: add caller_id support') > the standard "dmesg" has been enhanced to print PRINTK_CALLER fields. > > Due to this, even though the expected vs observed are same, > end testcase results are failed. > > -% insmod test_modules/test_klp_livepatch.ko > -livepatch: enabling patch 'test_klp_livepatch' > -livepatch: 'test_klp_livepatch': initializing patching transition > -livepatch: 'test_klp_livepatch': starting patching transition > -livepatch: 'test_klp_livepatch': completing patching transition > -livepatch: 'test_klp_livepatch': patching complete > -% echo 0 > /sys/kernel/livepatch/test_klp_livepatch/enabled > -livepatch: 'test_klp_livepatch': initializing unpatching transition > -livepatch: 'test_klp_livepatch': starting unpatching transition > -livepatch: 'test_klp_livepatch': completing unpatching transition > -livepatch: 'test_klp_livepatch': unpatching complete > -% rmmod test_klp_livepatch > +[ T3659] % insmod test_modules/test_klp_livepatch.ko > +[ T3682] livepatch: enabling patch 'test_klp_livepatch' > +[ T3682] livepatch: 'test_klp_livepatch': initializing patching transition > +[ T3682] livepatch: 'test_klp_livepatch': starting patching transition > +[ T826] livepatch: 'test_klp_livepatch': completing patching transition > +[ T826] livepatch: 'test_klp_livepatch': patching complete > +[ T3659] % echo 0 > /sys/kernel/livepatch/test_klp_livepatch/enabled > +[ T3659] livepatch: 'test_klp_livepatch': initializing unpatching transition > +[ T3659] livepatch: 'test_klp_livepatch': starting unpatching transition > +[ T789] livepatch: 'test_klp_livepatch': completing unpatching transition > +[ T789] livepatch: 'test_klp_livepatch': unpatching complete > +[ T3659] % rmmod test_klp_livepatch > > ERROR: livepatch kselftest(s) failed > not ok 1 selftests: livepatch: test-livepatch.sh # exit=1 > > Currently the check_result() handles the "[time]" removal from > the dmesg. Enhance the check to also handle removal of "[Thread Id]" > or "[CPU Id]". > > Signed-off-by: Madhavan Srinivasan Looks and works well: Reviewed-by: Petr Mladek Tested-by: Petr Mladek Best Regards, Petr PS: The merge window for 6.14 has started yesterday. Every change should spend at least few days in linux-next and I have already sent a pull request so it is kind of late for 6.14. If there is a demand, I could still queue it for 6.14 in the 2nd half of the merge window or for rc2. There is only small group of people interested into the livepatch selftests anyway.