RE: [PATCH 02/14] iommufd: Add iommufd_group

Tian, Kevin
2023-03-03T02:13:36Z

> From: Jason Gunthorpe <jgg@nvidia.com>
> Sent: Thursday, March 2, 2023 8:52 PM
>
>
> > > @@ -98,7 +195,7 @@ struct iommufd_device
> *iommufd_device_bind(struct
> > > iommufd_ctx *ictx,
> > > /* The calling driver is a user until iommufd_device_unbind() */
> > > refcount_inc(&idev->obj.users);
> > > /* group refcount moves into iommufd_device */
> > > - idev->group = group;
> > > + idev->igroup = igroup;
> >
> > the comment about group refcount is stale now.
>
> You mean it should say 'igroup refcount' ?
>

The original comment refers to the refcnt of iommu group.

Now that refcnt is held by iommufd_group and no movement per se.

I'd just remove this comment.