From: Jiri Pirko <jiri@resnulli.us>
To: Po-Hsu Lin <po-hsu.lin@canonical.com>
Cc: linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org,
netdev@vger.kernel.org, idosch@mellanox.com,
danieller@mellanox.com, petrm@mellanox.com, shuah@kernel.org,
pabeni@redhat.com, kuba@kernel.org, edumazet@google.com,
davem@davemloft.net
Subject: Re: [PATCHv2] selftests: net: devlink_port_split.py: skip test if no suitable device available
Date: Wed, 8 Mar 2023 10:31:30 +0100 [thread overview]
Message-ID: <ZAhV8nKuLVAQHQGl@nanopsycho> (raw)
In-Reply-To: <20230307150030.527726-1-po-hsu.lin@canonical.com>
Tue, Mar 07, 2023 at 04:00:30PM CET, po-hsu.lin@canonical.com wrote:
>The `devlink -j port show` command output may not contain the "flavour"
>key, an example from s390x LPAR with Ubuntu 22.10 (5.19.0-37-generic),
>iproute2-5.15.0:
> {"port":{"pci/0001:00:00.0/1":{"type":"eth","netdev":"ens301"},
> "pci/0001:00:00.0/2":{"type":"eth","netdev":"ens301d1"},
> "pci/0002:00:00.0/1":{"type":"eth","netdev":"ens317"},
> "pci/0002:00:00.0/2":{"type":"eth","netdev":"ens317d1"}}}
As Jakub wrote, this is odd. Could you debug if kernel sends the flavour
attr and if not why? Also, could you try with most recent kernel?
next prev parent reply other threads:[~2023-03-08 9:32 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-07 15:00 [PATCHv2] selftests: net: devlink_port_split.py: skip test if no suitable device available Po-Hsu Lin
2023-03-08 1:02 ` Jakub Kicinski
2023-03-08 10:02 ` Po-Hsu Lin
2023-03-08 9:31 ` Jiri Pirko [this message]
2023-03-08 10:21 ` Po-Hsu Lin
2023-03-08 11:41 ` Jiri Pirko
2023-03-08 14:37 ` Po-Hsu Lin
2023-03-08 18:24 ` Jiri Pirko
2023-03-09 15:44 ` Po-Hsu Lin
2023-03-10 8:32 ` Jiri Pirko
2023-03-11 0:05 ` Jakub Kicinski
2023-03-15 9:11 ` Po-Hsu Lin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZAhV8nKuLVAQHQGl@nanopsycho \
--to=jiri@resnulli.us \
--cc=danieller@mellanox.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=idosch@mellanox.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=petrm@mellanox.com \
--cc=po-hsu.lin@canonical.com \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox