From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 11D4DC678D5 for ; Wed, 8 Mar 2023 22:44:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229798AbjCHWoc (ORCPT ); Wed, 8 Mar 2023 17:44:32 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42378 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229800AbjCHWob (ORCPT ); Wed, 8 Mar 2023 17:44:31 -0500 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CB3806505B for ; Wed, 8 Mar 2023 14:43:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1678315423; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=jUpec8k3TuIoHkhdWuDgw2GYbAPkkhYheZa+lxQbkK0=; b=cmaQEjZIrCRnjXrCHu0deOC73CBs7yt24Wy6ffxgB/4ZHscLP7E265dnZAuUpERw3V1Tie SV/CMYT4ECovlXrcshPsp5Rv5Q2S+o4BTuENGZQNTZdS6d3UZRTm5gK7NApdhAQPi67wBC JJRUiL9enMssq4uMVKSlTnfObBoHkrg= Received: from mail-qt1-f198.google.com (mail-qt1-f198.google.com [209.85.160.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-91-3R_gxJBDM-GzZnqSBM2lAQ-1; Wed, 08 Mar 2023 17:43:42 -0500 X-MC-Unique: 3R_gxJBDM-GzZnqSBM2lAQ-1 Received: by mail-qt1-f198.google.com with SMTP id w16-20020ac843d0000000b003bfe50a4105so42397qtn.10 for ; Wed, 08 Mar 2023 14:43:42 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678315422; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=jUpec8k3TuIoHkhdWuDgw2GYbAPkkhYheZa+lxQbkK0=; b=g9ySXZRHdequdNfhFQZ/XxK58zvxUDhYejVCmbJOfYtPLd9Nyg4W9Hjz2jw6JoxyD+ UmEbqHVCPTn7XgFPOXqahNPfslLmoy96gzY1TdY0iLlhlL/2WkbPdEhi8ttgynOYhYdl QTbIszN2Rg23ttooD9WYBF3Ox/dVXsbL6kSxCL7zXGMQu5LXU1Lqar0DuMlwNjiWsjiX eKoh98X0xgDbjSoEmlDmx16NdrZPqruWg34WCNWUly3ltZ+XDrLdn61UPYhZb7egXeZQ DASIr9MVA3RERXJCRoT2IKo8HiKpWifmpHcDAteT/9P4acbC0tJDxypYYPMIg80JVuBV AVWg== X-Gm-Message-State: AO0yUKVBNY3s9uHJ+Zh99b3sDBscwWLvmoyFTbOs5eo9enJyUaN8eAxY S6RkA50CHTCmWSbmaC3L7u1z4BuNvOi8PUjlprS4lC4bROA2xshFzb1WMO3uvOg1jzBE9UeCGxw jVmw/q177lQ2IKjOnTIhK/J12nwk2 X-Received: by 2002:a05:622a:4c7:b0:3bf:be4b:8094 with SMTP id q7-20020a05622a04c700b003bfbe4b8094mr39961479qtx.0.1678315422278; Wed, 08 Mar 2023 14:43:42 -0800 (PST) X-Google-Smtp-Source: AK7set/svpcFN7oyLd26+MN7LVXbPhQYslhKV53Vi4XzGLt4t3d/JLaXvYRZ51X7BFbuHcnLETSjqQ== X-Received: by 2002:a05:622a:4c7:b0:3bf:be4b:8094 with SMTP id q7-20020a05622a04c700b003bfbe4b8094mr39961450qtx.0.1678315422037; Wed, 08 Mar 2023 14:43:42 -0800 (PST) Received: from x1n (bras-base-aurron9127w-grc-56-70-30-145-63.dsl.bell.ca. [70.30.145.63]) by smtp.gmail.com with ESMTPSA id r25-20020ac87959000000b003bfc1f49ad1sm12255401qtt.87.2023.03.08.14.43.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 Mar 2023 14:43:41 -0800 (PST) Date: Wed, 8 Mar 2023 17:43:39 -0500 From: Peter Xu To: Axel Rasmussen Cc: Alexander Viro , Andrew Morton , Hugh Dickins , Jan Kara , "Liam R. Howlett" , Matthew Wilcox , Mike Kravetz , Mike Rapoport , Muchun Song , Nadav Amit , Shuah Khan , James Houghton , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-kselftest@vger.kernel.org Subject: Re: [PATCH v4 3/4] mm: userfaultfd: combine 'mode' and 'wp_copy' arguments Message-ID: References: <20230308221932.1548827-1-axelrasmussen@google.com> <20230308221932.1548827-4-axelrasmussen@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20230308221932.1548827-4-axelrasmussen@google.com> Precedence: bulk List-ID: X-Mailing-List: linux-kselftest@vger.kernel.org All nitpicks below. On Wed, Mar 08, 2023 at 02:19:31PM -0800, Axel Rasmussen wrote: > +static inline bool uffd_flags_has_mode(uffd_flags_t flags, enum mfill_atomic_mode expected) > +{ > + return (flags & MFILL_ATOMIC_MODE_MASK) == ((__force uffd_flags_t) expected); > +} I would still call it uffd_flags_get_mode() or uffd_flags_mode(), "has" sounds a bit like there can be >1 modes set but it's not. > + > +static inline uffd_flags_t uffd_flags_set_mode(uffd_flags_t flags, enum mfill_atomic_mode mode) > +{ > + return flags | ((__force uffd_flags_t) mode); > +} IIUC this __force mostly won't work in any way because it protects e.g. illegal math ops upon it (to only allow bitops, iiuc) but here it's an OR so it's always legal.. So I'd just drop it and also clear the mode mask to be very clear it sets the mode right, rather than any chance of messing up when set twice: flags &= ~MFILL_ATOMIC_MODE_MASK; return flags | mode; But feel free to ignore this if there's no other reason to repost, I don't think it matters a huge deal. Acked-by: Peter Xu Thanks, -- Peter Xu