From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4AD6BEB64DC for ; Thu, 22 Jun 2023 22:15:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229564AbjFVWPv (ORCPT ); Thu, 22 Jun 2023 18:15:51 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48750 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230286AbjFVWPu (ORCPT ); Thu, 22 Jun 2023 18:15:50 -0400 Received: from mail-oi1-x230.google.com (mail-oi1-x230.google.com [IPv6:2607:f8b0:4864:20::230]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 076592116 for ; Thu, 22 Jun 2023 15:15:49 -0700 (PDT) Received: by mail-oi1-x230.google.com with SMTP id 5614622812f47-3a1a0e5c0ddso323644b6e.1 for ; Thu, 22 Jun 2023 15:15:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fromorbit-com.20221208.gappssmtp.com; s=20221208; t=1687472148; x=1690064148; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=RWTgYq2UUxEsCsczZywS54H3UJIh7PEQ08XF3T1QNQI=; b=erEg5tOQrXPIIkPMrTVT0g485cXgkF/mSZwczNIMFvys3/3M8s5touTnozJgkJnrv8 MFgmH40Daa20QkYuk/ODWSbN3LRXmOTp58f7zONk5K1txgIR2E8530LaoJ51BKnZY5aO q2mU71Au/pRMDG+NvsVvPFmQc6ZfVXk4ZJnNrQHF6MhxbN3POquh8W6sbg6BpsfU+l9Z TkwUKpPMpEYhD1uL94U3aeq6C4rVRimj2eXjJmERe1oophqJqKOGbPxQE61zl4rUBY/F iOzC66FM7hcAoKz+QXRHotEMNHJjsYwHuYiVdOFUNE5F6uu2fIgvAz22mSWoEyV6S/OC H5vw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687472148; x=1690064148; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=RWTgYq2UUxEsCsczZywS54H3UJIh7PEQ08XF3T1QNQI=; b=kWmirbOuwue2PrfAZRnxs/Qsxm45UtXsDDnIFSKLde0TSwT8vzAMJDcEhz373Oj0n2 Mnziepu1SS9A9FVlMNXZ8oz9vE/4efovlaXfd2t8KMp8kTXtH2secpaDgHFQkO1vjTUk YspJ7gpuK8cN4kzPv6uQLXkR5K1wpNpmde6Gq9OStwyC0mANxMmVkSeLhrr9FLmUcGxJ pjmCohyuvVX2RVq9PCVeDbQDjvBstwzMPzxCBUFbqOpBw+yWc+ZlU5A3Pz/gxXLNe7IL aIf3usp/LWbNk7lpUdA9Zz+bqEdRTb4IdqN1Lk0Ys9YqU0/rwtUbV91PDaMw45zOkjPW dfAg== X-Gm-Message-State: AC+VfDylnLTg5En9Ozeg0lJYQG4gY25gPnKc5QxVWgK5KIp8EunqHpaa WSr5e5/PGgtoHkbCVHmnqzKj4g== X-Google-Smtp-Source: ACHHUZ5xFMVs4yYQ56AKSUP4WsX6unDFAVwqpLuAsR4Evt1ihNZo7GTkH/lU8pygoBB2omszfgADtw== X-Received: by 2002:a05:6808:1b0f:b0:39a:aafd:dda7 with SMTP id bx15-20020a0568081b0f00b0039aaafddda7mr22999807oib.35.1687472148243; Thu, 22 Jun 2023 15:15:48 -0700 (PDT) Received: from dread.disaster.area (pa49-180-13-202.pa.nsw.optusnet.com.au. [49.180.13.202]) by smtp.gmail.com with ESMTPSA id d24-20020a17090ac25800b0025b83c6227asm217949pjx.3.2023.06.22.15.15.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 22 Jun 2023 15:15:47 -0700 (PDT) Received: from dave by dread.disaster.area with local (Exim 4.96) (envelope-from ) id 1qCSaf-00F0Us-05; Fri, 23 Jun 2023 08:15:45 +1000 Date: Fri, 23 Jun 2023 08:15:45 +1000 From: Dave Chinner To: stsp Cc: Chuck Lever III , Jeff Layton , "linux-kernel@vger.kernel.org" , Al Viro , Christian Brauner , "linux-fsdevel@vger.kernel.org" , Shuah Khan , "linux-kselftest@vger.kernel.org" , "linux-api@vger.kernel.org" Subject: Re: [PATCH 2/2] selftests: add OFD lock tests Message-ID: References: <20230621152214.2720319-1-stsp2@yandex.ru> <20230621152214.2720319-3-stsp2@yandex.ru> <4db7c65bee0739fe7983059296cfc95f20647fa3.camel@kernel.org> <7bbb29d2-4cae-48bd-1b97-9f4dbf6ffb19@yandex.ru> <8F45F47C-86C0-472E-B701-001A4FF90DBC@oracle.com> <26a798ae-b93b-2f68-71ed-35950240927d@yandex.ru> <187C3E49-A977-492E-99CB-97F032B24E5F@oracle.com> <4582a51d-2b29-f430-2f8f-ed1239d70f70@yandex.ru> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <4582a51d-2b29-f430-2f8f-ed1239d70f70@yandex.ru> Precedence: bulk List-ID: X-Mailing-List: linux-kselftest@vger.kernel.org On Thu, Jun 22, 2023 at 10:31:06PM +0500, stsp wrote: > > 22.06.2023 22:12, Chuck Lever III пишет: > > I don't have a strong preference. A good choice is to > > push the test before the kernel changes are merged. > It will fail though w/o kernel changes. > So what exactly is the policy? filesystem unit test functionality needs to be pushed into fstests and/or ltp. The preference is the former, because just about every filesystem developer and distro QA team is running this as part of their every-day testing workflow. fstests is written to probe whether the kernel supports a given feature or not before testing it. It will _not_run() a test that doesn't have the required kernel/fs/device support, and this is not considered a test failure. Yes, it means you have to also write the userspace feature probing code, but that should be trivial to do because userspace already has to be able to safely discover that this extension exists, right? -Dave. -- Dave Chinner david@fromorbit.com