From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id CBA04EC873A for ; Thu, 7 Sep 2023 16:01:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234126AbjIGQBL (ORCPT ); Thu, 7 Sep 2023 12:01:11 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39136 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241329AbjIGP7O (ORCPT ); Thu, 7 Sep 2023 11:59:14 -0400 Received: from pandora.armlinux.org.uk (unknown [IPv6:2001:4d48:ad52:32c8:5054:ff:fe00:142]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CD48A267E4; Thu, 7 Sep 2023 08:48:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=OoBwAxDpan9uBfWRYsikSiGI5qln4oQ9IXlfWDXOufw=; b=y80+uZ0EYmbQk6lLT3Lep7TBKi 4vJcAnE3xZIpYzFOHrhBHlX2fWWN20T90ZPYtBr2a8ROFrBGZcNIuPUYf2i50fnnJuOLdfbdx/X/J x/6topeBqYe4CGDpu7YBI/2i+RMskTOOqun2DGlm8fflMvp9QP7l0XR9mX6mjAz/uNZMwWZMnOt/+ D+Qq4tV2JtPjfRbeK8aIRKq1WL6O1/SiPGOkCIe+2OVkXkJdxAsaKhVxmZmo0p/fzg9+0iv9IqXmx FbxvwVCH7i7BtLxFWq3cCs/VX8KBg8+0lDmBaH4mOil5RMbdJaMLQiAZgZUnx0c1POtThLUmxr/vq jlbD/QVg==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:49130) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1qeAih-0001fa-18; Thu, 07 Sep 2023 09:50:35 +0100 Received: from linux by shell.armlinux.org.uk with local (Exim 4.94.2) (envelope-from ) id 1qeAih-0005hW-B2; Thu, 07 Sep 2023 09:50:35 +0100 Date: Thu, 7 Sep 2023 09:50:35 +0100 From: "Russell King (Oracle)" To: Puranjay Mohan Cc: Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko , Martin KaFai Lau , Song Liu , Yonghong Song , John Fastabend , KP Singh , Stanislav Fomichev , Hao Luo , Jiri Olsa , Shubham Bansal , Mykola Lysenko , Shuah Khan , bpf@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH bpf-next v2 6/8] arm32, bpf: add support for 64 bit division instruction Message-ID: References: <20230906183320.1959008-1-puranjay12@gmail.com> <20230906183320.1959008-7-puranjay12@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230906183320.1959008-7-puranjay12@gmail.com> Sender: Russell King (Oracle) Precedence: bulk List-ID: X-Mailing-List: linux-kselftest@vger.kernel.org On Wed, Sep 06, 2023 at 06:33:18PM +0000, Puranjay Mohan wrote: > + /* Recover {R3, R2} and {R1, R0} from stack if they are not Rd */ > + if (rd[1] != ARM_R0 && rd[1] != ARM_R2) { > + emit(ARM_POP(BIT(ARM_R0) | BIT(ARM_R1)), ctx); > + emit(ARM_POP(BIT(ARM_R2) | BIT(ARM_R3)), ctx); > + } else if (rd[1] != ARM_R0) { > + emit(ARM_POP(BIT(ARM_R0) | BIT(ARM_R1)), ctx); > + emit(ARM_ADD_I(ARM_SP, ARM_SP, 8), ctx); > + } else if (rd[1] != ARM_R2) { > + emit(ARM_ADD_I(ARM_SP, ARM_SP, 8), ctx); > + emit(ARM_POP(BIT(ARM_R2) | BIT(ARM_R3)), ctx); > + } else { > + emit(ARM_ADD_I(ARM_SP, ARM_SP, 16), ctx); > + } As mentioned in the continuing discussion of the previous patch series, all these cases aren't reachable. Thanks. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!