Re: [PATCH v6 2/6] iommufd: Add IOMMU_HWPT_INVALIDATE

Jason Gunthorpe
2023-12-11T13:21:41Z

On Mon, Dec 11, 2023 at 03:53:40PM +0800, Yi Liu wrote:

> > > From that thread Jason mentioned to make the invalidation format
> > > part of domain allocation. If that is the direction to go then there
> > > won't be multiple invalidation formats per hwpt. The user should
> > > create multiple hwpt's per invalidation format (though mixing
> > > formats in one virtual platform is very unlikely)?
> >
> > I think we could do either, but I have a vauge cleanness preference
> > that the enums are just different? That would follow a pretty typical
> > pattern for a structure tag to reflect the content of the structure.
>
> Is this still following the direction to make the invalidation format
> part of domain allocation?

I think you should make it seperate

Jason