From: Benjamin Poirier <bpoirier@nvidia.com>
To: Paolo Abeni <pabeni@redhat.com>
Cc: netdev@vger.kernel.org, Jay Vosburgh <j.vosburgh@gmail.com>,
Andy Gospodarek <andy@greyhouse.net>,
Shuah Khan <shuah@kernel.org>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Petr Machata <petrm@nvidia.com>,
Nikolay Aleksandrov <razor@blackwall.org>,
Hangbin Liu <liuhangbin@gmail.com>,
Ido Schimmel <idosch@nvidia.com>,
Vladimir Oltean <vladimir.oltean@nxp.com>,
Jonathan Toppins <jon.toppins+linux@gmail.com>,
Joachim Wiberg <troglobit@gmail.com>,
linux-kselftest@vger.kernel.org
Subject: Re: [PATCH net 2/2] selftests: forwarding: Remove executable bits from lib.sh
Date: Fri, 19 Jan 2024 16:56:28 -0500 [thread overview]
Message-ID: <ZarwDNeEgeJ529sW@d3> (raw)
In-Reply-To: <ad0a8b8b04a6c767942cf0d89e8048c349175995.camel@redhat.com>
On 2024-01-16 09:32 +0100, Paolo Abeni wrote:
> On Wed, 2024-01-10 at 09:14 -0500, Benjamin Poirier wrote:
> > The lib.sh script is meant to be sourced from other scripts, not executed
> > directly. Therefore, remove the executable bits from lib.sh's permissions.
>
> LGTM, but there is any special reason to not fix the permissions of
> other *lib.sh files in the same directory? Could be a follow-up.
I just looked into it and as of dbc153fd3c14 other *lib.sh files under
tools/testing/selftests/net/forwarding/ do not have any executable bits.
Did I miss something?
tools/testing/selftests/net/setup_loopback.sh has an unneccessary +x,
I'll send a patch for that one.
next prev parent reply other threads:[~2024-01-19 21:56 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-10 14:14 [PATCH net 0/2] selftests: net: Small fixes Benjamin Poirier
2024-01-10 14:14 ` [PATCH net 1/2] selftests: bonding: Change script interpreter Benjamin Poirier
2024-01-10 14:14 ` [PATCH net 2/2] selftests: forwarding: Remove executable bits from lib.sh Benjamin Poirier
2024-01-16 8:32 ` Paolo Abeni
2024-01-19 21:56 ` Benjamin Poirier [this message]
2024-01-11 11:25 ` [PATCH net 0/2] selftests: net: Small fixes Przemek Kitszel
2024-01-11 19:42 ` patchwork-bot+netdevbpf
2024-01-12 1:00 ` patchwork-bot+netdevbpf
2024-01-16 8:40 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZarwDNeEgeJ529sW@d3 \
--to=bpoirier@nvidia.com \
--cc=andy@greyhouse.net \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=idosch@nvidia.com \
--cc=j.vosburgh@gmail.com \
--cc=jon.toppins+linux@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=liuhangbin@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=petrm@nvidia.com \
--cc=razor@blackwall.org \
--cc=shuah@kernel.org \
--cc=troglobit@gmail.com \
--cc=vladimir.oltean@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).