From: Peter Xu <peterx@redhat.com>
To: Shaoqin Huang <shahuang@redhat.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>,
Sean Christopherson <seanjc@google.com>,
Shuah Khan <shuah@kernel.org>,
kvm@vger.kernel.org, linux-kselftest@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] KVM: selftests: Fix the dirty_log_test semaphore imbalance
Date: Mon, 5 Feb 2024 18:05:02 +0800 [thread overview]
Message-ID: <ZcCyzrUhXSlhKyqC@x1n> (raw)
In-Reply-To: <20240202064332.9403-1-shahuang@redhat.com>
Shaoqin, Sean,
Apologies for a late comment. I'm trying to remember what I wrote..
On Fri, Feb 02, 2024 at 01:43:32AM -0500, Shaoqin Huang wrote:
> Why sem_vcpu_cont and sem_vcpu_stop can be non-zero value? It's because
> the dirty_ring_before_vcpu_join() execute the sem_post(&sem_vcpu_cont)
> at the end of each dirty-ring test. It can cause two cases:
As a possible alternative, would it work if we simply reset all the sems
for each run? Then we don't care about the leftovers. E.g. sem_destroy()
at the end of run_test(), then always init to 0 at entry.
--
Peter Xu
next prev parent reply other threads:[~2024-02-05 10:05 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-02 6:43 [PATCH v3] KVM: selftests: Fix the dirty_log_test semaphore imbalance Shaoqin Huang
2024-02-02 17:46 ` Sean Christopherson
2024-02-02 21:14 ` Sean Christopherson
2024-02-05 10:05 ` Peter Xu [this message]
2024-02-05 10:18 ` Peter Xu
2024-02-05 15:48 ` Sean Christopherson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZcCyzrUhXSlhKyqC@x1n \
--to=peterx@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=seanjc@google.com \
--cc=shahuang@redhat.com \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox