From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f176.google.com (mail-pf1-f176.google.com [209.85.210.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 636BF35280 for ; Tue, 2 Jul 2024 05:46:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.176 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719899174; cv=none; b=W3f3cJSGOCpb79C+o8RZe2OJX3IxnchMglGtqaigo53LuqKcFoZM1QQsP4E3Obx3xTHQ4dokknIAfcVo7exdzMU3Ai5Hct88OHcQKgun6waSE0U9+lcipRryewNMWIkCIFUmEZqd9uQrGHJD4HO/WjuNxHSU0CM39ueYsYb3Uu8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719899174; c=relaxed/simple; bh=AdkaUjRTJIhO/K8YUDZQ1Q0hdKG/eUYO18zWbxAkJ+k=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=IpkQmUa5iYtGM5bHvy5vtaJuVFjdP/ZrsmLNeW+wfXufnTu2/0NwHab4Yv4nDPjfo/cgkbsUHYeANlvT9+OC7LfCVLzaUjh3B77EACZH1b8xRaJWKrC3nyQVDgG78mWGQu+2CLKekaGUJ5b3z1TmjGGDQXAKLVzt1UHGImqKKZY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=rivosinc.com; spf=pass smtp.mailfrom=rivosinc.com; dkim=pass (2048-bit key) header.d=rivosinc-com.20230601.gappssmtp.com header.i=@rivosinc-com.20230601.gappssmtp.com header.b=xU+Qz5vt; arc=none smtp.client-ip=209.85.210.176 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=rivosinc.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=rivosinc.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=rivosinc-com.20230601.gappssmtp.com header.i=@rivosinc-com.20230601.gappssmtp.com header.b="xU+Qz5vt" Received: by mail-pf1-f176.google.com with SMTP id d2e1a72fcca58-70679845d69so2412468b3a.1 for ; Mon, 01 Jul 2024 22:46:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rivosinc-com.20230601.gappssmtp.com; s=20230601; t=1719899173; x=1720503973; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=BGGBEWgqwliEqnZATHjMM1K2Xkz4OG63sXpZDZIsbfo=; b=xU+Qz5vtMWlGv7Gpl1n5kg3KOGQIqSgzjPs7s2nu71MB+EpE9biNDMVboQiGHCcpyf 7cR47w3w2+9SjvSB/MBcX1JC62f0LrS/vHHcaqlNUF1ZoVOZSolmCMcQlFu/rmzj2giO PwXFtHM6BITw4FDAy7Z8UQ1jzlhmsM8FwsTKFhFvnppjICROWWSHjAVp7/McPhAJ22sT uBWqUH4WVrs+UlavQrViqht1TjsWuQd74/OOmtd4zpxem9KlGDCm18GUH/On6PYF8KbH 0dfZZwv6GCgVwmhy/mcAL5snTQdjZZTYfHzN8iz7AkTOuCKO0s8q/8YQlkXAvFV8fAn/ OWfQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719899173; x=1720503973; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=BGGBEWgqwliEqnZATHjMM1K2Xkz4OG63sXpZDZIsbfo=; b=vZAbRYQpMdDCdK157Ctunc7zLEf5EkywSiOCYqWwZKQ9nMULDb4aQQ+HdO+fG2IYb6 uw5iX9abyLwzWsDMIwrkMOeFkZY0aT35sKLfxA+5itB2tg3LTj246rcXuvWd8EHu/7cv 4/GTfGN41G94T7jO164P/H++caAOeLR2Fheu7rjBI4QR8P/z/n0hm+x0WOzcUNUYhsdG Z4GAScqmrDeAWUOWEUL8OF5N1U8dll1diK+aKGzB4yQwDmp1mPRuh1JPNmmvtdezdGtH s3xbs1p6ThRqejBL0El1izdb2mgw1r4+HQC1IWT3lAbBwxDJoeBX8wLyWGpC6cKWHmbk r9PA== X-Forwarded-Encrypted: i=1; AJvYcCWeYaQX8oyoKoCd4psTrDPdUC0yN+a6DZDDLiUlne2oP+BViFW9y5xMCzw43H+zTqAWLV+e4Fd6+ZxLM3nEUEUrDOrD2iB/wOzp53hs0Ce2 X-Gm-Message-State: AOJu0YyjXIKFteFpx9VLlmmNNMcizUxja34LVR2e0gq/Lo4nLIn7KOPM oz8Bf2K45XqVtLGZBhnny1Bo9Czw+QA3avMVL5cYsf5wqxyQvQNDgR4gBFuVHEE= X-Google-Smtp-Source: AGHT+IG2WieA6d2VXCXPEULk6bM4rk8RGnz2VXlb5+XlqbXE2HDHRrkVhtC3A7gynucOeClBzA/BEQ== X-Received: by 2002:a05:6a00:3e1d:b0:705:9a28:aa04 with SMTP id d2e1a72fcca58-70aaaefd5ddmr6625232b3a.23.1719899172664; Mon, 01 Jul 2024 22:46:12 -0700 (PDT) Received: from ghost ([2601:647:5700:6860:a569:328b:99ad:ce17]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-70803ecf95bsm7787118b3a.140.2024.07.01.22.46.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 01 Jul 2024 22:46:12 -0700 (PDT) Date: Mon, 1 Jul 2024 22:46:08 -0700 From: Charlie Jenkins To: Samuel Holland Cc: linux-riscv@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-sunxi@lists.linux.dev, linux-doc@vger.kernel.org, linux-kselftest@vger.kernel.org, Heiko Stuebner , Conor Dooley , Rob Herring , Krzysztof Kozlowski , Paul Walmsley , Palmer Dabbelt , Albert Ou , Jisheng Zhang , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Jonathan Corbet , Shuah Khan , Guo Ren , Evan Green , Andy Chiu , Jessica Clarke Subject: Re: [PATCH v3 07/13] riscv: csr: Add CSR encodings for VCSR_VXRM/VCSR_VXSAT Message-ID: References: <20240619-xtheadvector-v3-0-bff39eb9668e@rivosinc.com> <20240619-xtheadvector-v3-7-bff39eb9668e@rivosinc.com> <54232f3e-4fea-4996-a90b-6de51e1c51e0@sifive.com> Precedence: bulk X-Mailing-List: linux-kselftest@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <54232f3e-4fea-4996-a90b-6de51e1c51e0@sifive.com> On Mon, Jul 01, 2024 at 10:49:23AM -0500, Samuel Holland wrote: > Hi Charlie, > > On 2024-06-19 6:57 PM, Charlie Jenkins wrote: > > The VXRM vector csr for xtheadvector has an encoding of 0xa and VXSAT > > has an encoding of 0x9. > > > > Co-developed-by: Heiko Stuebner > > Signed-off-by: Heiko Stuebner > > Signed-off-by: Charlie Jenkins > > --- > > arch/riscv/include/asm/csr.h | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/arch/riscv/include/asm/csr.h b/arch/riscv/include/asm/csr.h > > index 18e178d83401..9086639a3dde 100644 > > --- a/arch/riscv/include/asm/csr.h > > +++ b/arch/riscv/include/asm/csr.h > > @@ -220,6 +220,8 @@ > > #define VCSR_VXRM_MASK 3 > > #define VCSR_VXRM_SHIFT 1 > > #define VCSR_VXSAT_MASK 1 > > +#define VCSR_VXSAT 0x9 > > +#define VCSR_VXRM 0xa > > These are normal CSR indexes, so the prefix should be just "CSR_". Ok, I can change them. - Charlie > > Regards, > Samuel > > > > > /* symbolic CSR names: */ > > #define CSR_CYCLE 0xc00 > > >