Linux Kernel Selftest development
 help / color / mirror / Atom feed
From: Hangbin Liu <liuhangbin@gmail.com>
To: Abhash Jha <abhashkumarjha123@gmail.com>
Cc: linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org,
	kuba@kernel.org, shuah@kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH] selftests/net/pmtu.sh: Fix typo in error message
Date: Thu, 15 Aug 2024 15:35:45 +0800	[thread overview]
Message-ID: <Zr2v0Q-wJr_LTAzs@Laptop-X1> (raw)
In-Reply-To: <20240814173121.33590-1-abhashkumarjha123@gmail.com>

Hi Abhash,

You need add target repo for the patch. e.g. [PATCH net] selftests...

On Wed, Aug 14, 2024 at 11:01:21PM +0530, Abhash Jha wrote:
> The word 'expected' was spelled as 'exepcted'.
> Fixed the typo in this patch.
> 

Here you need to add the fixes tag. e.g.
Fixes: 136a1b434bbb ("selftests: net: test vxlan pmtu exceptions with tcp")

> Signed-off-by: Abhash Jha <abhashkumarjha123@gmail.com>
> ---
>  tools/testing/selftests/net/pmtu.sh | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/testing/selftests/net/pmtu.sh b/tools/testing/selftests/net/pmtu.sh
> index cfc849580..62eceb385 100755
> --- a/tools/testing/selftests/net/pmtu.sh
> +++ b/tools/testing/selftests/net/pmtu.sh
> @@ -1347,7 +1347,7 @@ test_pmtu_ipvX_over_bridged_vxlanY_or_geneveY_exception() {
>  		size=$(du -sb $tmpoutfile)
>  		size=${size%%/tmp/*}
>  
> -		[ $size -ne 1048576 ] && err "File size $size mismatches exepcted value in locally bridged vxlan test" && return 1
> +		[ $size -ne 1048576 ] && err "File size $size mismatches expected value in locally bridged vxlan test" && return 1
>  	done
>  
>  	rm -f "$tmpoutfile"
> -- 
> 2.43.0
> 

  reply	other threads:[~2024-08-15  7:35 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-08-14 17:31 [PATCH] selftests/net/pmtu.sh: Fix typo in error message Abhash Jha
2024-08-15  7:35 ` Hangbin Liu [this message]
2024-08-15 12:53 ` Simon Horman
2024-08-15 17:07   ` Abhash jha
2024-08-15 17:45     ` Simon Horman
2024-08-16  0:38       ` Jakub Kicinski
2024-08-16  3:55         ` Hangbin Liu
2024-08-16  2:01 ` patchwork-bot+netdevbpf
  -- strict thread matches above, loose matches on Subject: below --
2024-08-14 17:14 Abhash Jha
2024-08-14 17:18 ` Jakub Kicinski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Zr2v0Q-wJr_LTAzs@Laptop-X1 \
    --to=liuhangbin@gmail.com \
    --cc=abhashkumarjha123@gmail.com \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=shuah@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox