From: Dave Martin <Dave.Martin@arm.com>
To: Andre Przywara <andre.przywara@arm.com>
Cc: Mark Brown <broonie@kernel.org>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will@kernel.org>, Shuah Khan <shuah@kernel.org>,
linux-arm-kernel@lists.infradead.org,
linux-kselftest@vger.kernel.org
Subject: Re: [PATCH] kselftest/arm64: signal: fix/refactor SVE vector length enumeration
Date: Wed, 14 Aug 2024 14:27:54 +0100 [thread overview]
Message-ID: <Zryw2o0lAzKX0ZDj@e133380.arm.com> (raw)
In-Reply-To: <20240813135546.6c91fc8b@donnerap.manchester.arm.com>
On Tue, Aug 13, 2024 at 01:55:46PM +0100, Andre Przywara wrote:
> On Tue, 13 Aug 2024 12:00:06 +0100
> Mark Brown <broonie@kernel.org> wrote:
>
> Hi broonie,
>
> > On Mon, Aug 12, 2024 at 03:09:24PM +0100, Andre Przywara wrote:
> >
> > > + /* Did we find the lowest supported VL? */
> > > + if (use_sme && vq < sve_vq_from_vl(vl))
> > > + break;
> >
> > We don't need the use_sme check here, SVE is just architecturally
> > guaranteed to never trip the && case. Unless you add a warning for
> > broken implementations I'd just skip it.
>
> Ah, thanks, I wasn't sure about that, and wanted to mimic the existing
> code as close as possible. Will surely just drop it.
>
> Thanks,
> Andre
Maybe at least worth a comment?
I was looking at this code the other week, and this puzzled me until I
went and looked back at the architecture.
Cheers
---Dave
>
prev parent reply other threads:[~2024-08-14 13:28 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-12 14:09 [PATCH] kselftest/arm64: signal: fix/refactor SVE vector length enumeration Andre Przywara
2024-08-13 11:00 ` Mark Brown
2024-08-13 12:55 ` Andre Przywara
2024-08-14 13:27 ` Dave Martin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zryw2o0lAzKX0ZDj@e133380.arm.com \
--to=dave.martin@arm.com \
--cc=andre.przywara@arm.com \
--cc=broonie@kernel.org \
--cc=catalin.marinas@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=shuah@kernel.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox