From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from fhigh8-smtp.messagingengine.com (fhigh8-smtp.messagingengine.com [103.168.172.159]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C847919409C; Tue, 20 Aug 2024 14:08:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=103.168.172.159 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1724162921; cv=none; b=sDmz28w8L8w4Fu4Ro1bkJziA+AX1bU2Ka9qVMHmkHzlqz4AYDOsS3AAMyHKTvk6paAzKt6hixNf7w+5vJXr4jFQnnniWdiKz50rYNGzivqRyLVw6N/JmqSMaSYSJYJrcj5PCSJafP9zHm9OTXsIJfc77oDr/EhwqSwtR93yUYwE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1724162921; c=relaxed/simple; bh=GWNelTh3ZbbX0X7L0QDhwF2X1aKVlbBiANE3TaBt0DY=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Ev8xEFoPzX5LCc/OoSrFyZFeNf+jhxsWfQJy4lpgxgJmuMdw1QW1N4v1iwAn1CZWKTbOlF8lgAbdQO440/wc6A37k2B67G37ctgsfpf9fU9PFSQLLQAGC0W7EVHSdTJdbIl4YeckpwI0CX1a71lnsHMpZjhcZJeJXj5Tw+XrojQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=idosch.org; spf=none smtp.mailfrom=idosch.org; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b=kZANOZN3; arc=none smtp.client-ip=103.168.172.159 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=idosch.org Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=idosch.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="kZANOZN3" Received: from phl-compute-03.internal (phl-compute-03.nyi.internal [10.202.2.43]) by mailfhigh.nyi.internal (Postfix) with ESMTP id E6E071151A91; Tue, 20 Aug 2024 10:08:37 -0400 (EDT) Received: from phl-mailfrontend-01 ([10.202.2.162]) by phl-compute-03.internal (MEProxy); Tue, 20 Aug 2024 10:08:37 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:subject:subject:to :to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm1; t=1724162917; x=1724249317; bh=kEfYQeLPTow8jHAH+gKTn8OFS8ak MGlN/WqVFVkSklE=; b=kZANOZN35uNBToTAebxk6RQbQS0cIfsgQP34Fxh/IAz1 3wR16yLrj9A1q6A3tXxDJfN7QCVL6zZ+FQTf7TGXBEPRvH1gKcDO/QuzwUgn6tnU MzY+8rw7vKokzr3ixx3CCrZJwko538JREeWzy+eeSSMEhWjjsPGMnKhWRDYevFp0 j54jxPFEgSf0scbiQFbhmCts+9a2Ln6fXtZQDQ+lX27X5z31evxPzoeQTxWeFIer QIjmbKsbPAXHRIA2jmbonbuXu97XhjaXBPki+eyteYl70ceEV5nx2ZfOvAvhqVLW CB7Kf+x0FbEfv186xzPEvck3zHusvAf6t+RiRF1RIg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeeftddrudduiedgjeduucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdggtfgfnhhsuhgsshgtrhhisggvpdfu rfetoffkrfgpnffqhgenuceurghilhhouhhtmecufedttdenucenucfjughrpeffhffvve fukfhfgggtuggjsehttdertddttddvnecuhfhrohhmpefkughoucfutghhihhmmhgvlhcu oehiughoshgthhesihguohhstghhrdhorhhgqeenucggtffrrghtthgvrhhnpedvudefve ekheeugeeftddvveefgfduieefudeifefgleekheegleegjeejgeeghfenucevlhhushht vghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehiughoshgthhesihguoh hstghhrdhorhhgpdhnsggprhgtphhtthhopeejpdhmohguvgepshhmthhpohhuthdprhgt phhtthhopehkuhgsrgeskhgvrhhnvghlrdhorhhgpdhrtghpthhtohepuggrvhgvmhesug grvhgvmhhlohhfthdrnhgvthdprhgtphhtthhopehnvghtuggvvhesvhhgvghrrdhkvghr nhgvlhdrohhrghdprhgtphhtthhopegvughumhgriigvthesghhoohhglhgvrdgtohhmpd hrtghpthhtohepphgrsggvnhhisehrvgguhhgrthdrtghomhdprhgtphhtthhopehshhhu rghhsehkvghrnhgvlhdrohhrghdprhgtphhtthhopehlihhnuhigqdhkshgvlhhfthgvsh htsehvghgvrhdrkhgvrhhnvghlrdhorhhg X-ME-Proxy: Feedback-ID: i494840e7:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 20 Aug 2024 10:08:36 -0400 (EDT) Date: Tue, 20 Aug 2024 17:08:33 +0300 From: Ido Schimmel To: Jakub Kicinski Cc: davem@davemloft.net, netdev@vger.kernel.org, edumazet@google.com, pabeni@redhat.com, shuah@kernel.org, linux-kselftest@vger.kernel.org Subject: Re: [PATCH net-next v2] selftests: net: add helper for checking if nettest is available Message-ID: References: <20240820004217.1087392-1-kuba@kernel.org> Precedence: bulk X-Mailing-List: linux-kselftest@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240820004217.1087392-1-kuba@kernel.org> On Mon, Aug 19, 2024 at 05:42:17PM -0700, Jakub Kicinski wrote: > A few tests check if nettest exists in the $PATH before adding > $PWD to $PATH and re-checking. They don't discard stderr on > the first check (and nettest is built as part of selftests, > so it's pretty normal for it to not be available in system $PATH). > This leads to output noise: > > which: no nettest in (/home/virtme/tools/fs/bin:/home/virtme/tools/fs/sbin:/home/virtme/tools/fs/usr/bin:/home/virtme/tools/fs/usr/sbin:/bin:/sbin:/usr/bin:/usr/sbin:/usr/local/bin) > > Add a common helper for the check which does silence stderr. > > There is another small functional change hiding here, because pmtu.sh > and fib_rule_tests.sh used to return from the test case rather than > completely exit. Building nettest is not hard, there should be no need > to maintain the ability to selectively skip cases in its absence. > > Signed-off-by: Jakub Kicinski Like Hangbin I am also not sure what "profile=1" is about, but looks fine otherwise, so: Reviewed-by: Ido Schimmel Thanks!