From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2F416EEC9; Fri, 30 Aug 2024 15:30:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1725031813; cv=none; b=gnBessskoJZH0mhqzDOK9IcIP36mwVZ5zLQwdbMqPB7eD9cyW/GTz3WOVK/2vREPX7xOGHV+G6GxU/dSsmMWRLzx7Osw6OYNxn//0b/QOxuFSdUP0PcSTe6n9ICE4wHmIzl+dEuZr/uXFKOzB70thpslcJ8riRCr26lFjUSs5yk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1725031813; c=relaxed/simple; bh=V2VJ12EQT4i6n4aeoiaDxyllMlqthEmdNScFeTWz9Gc=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=DidCtSRXUgZCD8vExuRJcAsHq06qlPcytioR/apsCMtDr6/ZVQrZJJ6f76wV89gBzUn627Zs92skUw94IdcjmClV/1Q0hL7ByK1qX5fprZ56Vq7VGTtDPNPRjko3ZsEj2O/BzjV3a3NIxVoglRAn15UOQP3uJqjWeXx87emSMA8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=zx2c4.com header.i=@zx2c4.com header.b=LbxW5qED; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=zx2c4.com header.i=@zx2c4.com header.b="LbxW5qED" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 39FF2C4CEC2; Fri, 30 Aug 2024 15:30:12 +0000 (UTC) Authentication-Results: smtp.kernel.org; dkim=pass (1024-bit key) header.d=zx2c4.com header.i=@zx2c4.com header.b="LbxW5qED" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=zx2c4.com; s=20210105; t=1725031809; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=TS8nVZqiFVKrs+/FUWrxZIU1v/CNzMC33eCO9K4Uobg=; b=LbxW5qED90WneHoVKo5ut0ooOGXlLEj23y8j28oyQWipIBHXkNhAIM49N7cmXW0Hkisq5N TFD4fpf81DjgHrnNfCYxWzYevM8hxURnHSdCM8PP04dXHbuwmfKmkr04uddwZ0x0Z2WHfO 94jHWbtd+dSV66NG2XRR8RUnhz6W0X8= Received: by mail.zx2c4.com (ZX2C4 Mail Server) with ESMTPSA id 044db95b (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Fri, 30 Aug 2024 15:30:09 +0000 (UTC) Date: Fri, 30 Aug 2024 17:30:07 +0200 From: "Jason A. Donenfeld" To: Mark Brown Cc: Shuah Khan , linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] selftest/vDSO: Fix cross build for the random tests Message-ID: References: <20240830-vdso-chacha-build-v1-1-78f93d2a142f@kernel.org> Precedence: bulk X-Mailing-List: linux-kselftest@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20240830-vdso-chacha-build-v1-1-78f93d2a142f@kernel.org> On Fri, Aug 30, 2024 at 03:06:35PM +0100, Mark Brown wrote: > Unlike the check for the standalone x86 test the check for building the > vDSO getrandom and chacaha tests looks at the architecture for the host > rather than the architecture for the target when deciding if they should > be built. Since the chacha test includes some assembler code this means > that cross building with x86 as either the target or host is broken. Use > a check for ARCH instead. > > Fixes: 4920a2590e91 ("selftests/vDSO: add tests for vgetrandom") > Signed-off-by: Mark Brown Thanks for the patch. Seems reasonable; I'll queue it up. > --- > The x86_64 build is still broken for me because nothing installs > tools/arch/x86_64/vdso/vgetrandom-chacha.S (I beleive it's supposed to > be copied from ./arch/x86/entry/vdso/vgetrandom-chacha.S but I don't see > how?) but this at least fixes all the other architectures. There should be a symlink installed for that. Are you using this tree? https://git.kernel.org/pub/scm/linux/kernel/git/crng/random.git That's where all these fixups are going for 6.12. (And yea, there are a lot.)