Linux Kernel Selftest development
 help / color / mirror / Atom feed
From: Tony Ambardar <tony.ambardar@gmail.com>
To: Alexei Starovoitov <alexei.starovoitov@gmail.com>
Cc: Andrii Nakryiko <andrii.nakryiko@gmail.com>,
	Alexei Starovoitov <ast@kernel.org>, bpf <bpf@vger.kernel.org>,
	"open list:KERNEL SELFTEST FRAMEWORK"
	<linux-kselftest@vger.kernel.org>,
	Andrii Nakryiko <andrii@kernel.org>,
	Eduard Zingerman <eddyz87@gmail.com>,
	Daniel Borkmann <daniel@iogearbox.net>,
	Martin KaFai Lau <martin.lau@linux.dev>,
	Song Liu <song@kernel.org>,
	Yonghong Song <yonghong.song@linux.dev>,
	John Fastabend <john.fastabend@gmail.com>,
	KP Singh <kpsingh@kernel.org>,
	Stanislav Fomichev <sdf@fomichev.me>, Hao Luo <haoluo@google.com>,
	Jiri Olsa <jolsa@kernel.org>, Mykola Lysenko <mykolal@fb.com>,
	Shuah Khan <shuah@kernel.org>,
	Ilya Leoshkevich <iii@linux.ibm.com>,
	Quentin Monnet <qmo@kernel.org>
Subject: Re: [PATCH bpf-next v4 7/8] libbpf: Support creating light skeleton of either endianness
Date: Sat, 31 Aug 2024 23:02:17 -0700	[thread overview]
Message-ID: <ZtQDaWdoxTodv9BB@kodidev-ubuntu> (raw)
In-Reply-To: <CAADnVQLXYL66nCYpRrMmeR0c-ANtUW-6d5SoEE76cjPb3rVBTg@mail.gmail.com>

On Fri, Aug 30, 2024 at 06:24:47PM -0700, Alexei Starovoitov wrote:
> On Fri, Aug 30, 2024 at 2:31 PM Andrii Nakryiko
> <andrii.nakryiko@gmail.com> wrote:
> >
> >
> >
> > for the rest, Alexei, can you please review and give your ack?
> 
> It looks fine.
> All of the additional pr_debug()s look a bit excessive.
> Will take another look at respin.

Thanks for taking a look. My experience is the added pr_debug() were
essential to troubleshooting problems with the loader blobs, and only
provide indexes to embedded data. I'd hate for someone else to debug
without these. I think several of them could be consolidated however,
so let me have a try.

There's another area where I'd appreciate your help. The loader code
includes some inline debug statements, but I wasn't ever able to make
these work or see them in trace logs. Could you share an example of how
to enable these (e.g. for test_progs tests)?

Thanks,
Tony

  reply	other threads:[~2024-09-01  6:02 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-08-30  7:29 [PATCH bpf-next v4 0/8] libbpf, selftests/bpf: Support cross-endian usage Tony Ambardar
2024-08-30  7:29 ` [PATCH bpf-next v4 1/8] libbpf: Improve log message formatting Tony Ambardar
2024-08-30  7:29 ` [PATCH bpf-next v4 2/8] libbpf: Fix header comment typos for BTF.ext Tony Ambardar
2024-08-30  7:29 ` [PATCH bpf-next v4 3/8] libbpf: Fix output .symtab byte-order during linking Tony Ambardar
2024-08-30 22:15   ` Eduard Zingerman
2024-09-01  5:59     ` Tony Ambardar
2024-08-30  7:29 ` [PATCH bpf-next v4 4/8] libbpf: Support BTF.ext loading and output in either endianness Tony Ambardar
2024-08-30 21:14   ` Andrii Nakryiko
2024-09-02  8:19     ` Tony Ambardar
2024-09-04 19:55       ` Andrii Nakryiko
2024-08-31  0:15   ` Eduard Zingerman
2024-09-16  8:20     ` Tony Ambardar
2024-08-30  7:29 ` [PATCH bpf-next v4 5/8] libbpf: Support opening bpf objects of " Tony Ambardar
2024-08-30 21:25   ` Andrii Nakryiko
2024-08-31  1:26     ` Eduard Zingerman
2024-09-01  6:05       ` Tony Ambardar
2024-09-01  6:03     ` Tony Ambardar
2024-08-31  1:16   ` Eduard Zingerman
2024-09-01  6:04     ` Tony Ambardar
2024-08-30  7:29 ` [PATCH bpf-next v4 6/8] libbpf: Support linking " Tony Ambardar
2024-08-30 21:25   ` Andrii Nakryiko
2024-09-01  6:02     ` Tony Ambardar
2024-08-30  7:29 ` [PATCH bpf-next v4 7/8] libbpf: Support creating light skeleton " Tony Ambardar
2024-08-30 21:30   ` Andrii Nakryiko
2024-08-31  1:24     ` Alexei Starovoitov
2024-09-01  6:02       ` Tony Ambardar [this message]
2024-09-01  6:00     ` Tony Ambardar
2024-08-30  7:29 ` [PATCH bpf-next v4 8/8] selftests/bpf: Support cross-endian building Tony Ambardar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZtQDaWdoxTodv9BB@kodidev-ubuntu \
    --to=tony.ambardar@gmail.com \
    --cc=alexei.starovoitov@gmail.com \
    --cc=andrii.nakryiko@gmail.com \
    --cc=andrii@kernel.org \
    --cc=ast@kernel.org \
    --cc=bpf@vger.kernel.org \
    --cc=daniel@iogearbox.net \
    --cc=eddyz87@gmail.com \
    --cc=haoluo@google.com \
    --cc=iii@linux.ibm.com \
    --cc=john.fastabend@gmail.com \
    --cc=jolsa@kernel.org \
    --cc=kpsingh@kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=martin.lau@linux.dev \
    --cc=mykolal@fb.com \
    --cc=qmo@kernel.org \
    --cc=sdf@fomichev.me \
    --cc=shuah@kernel.org \
    --cc=song@kernel.org \
    --cc=yonghong.song@linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox