From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f173.google.com (mail-pf1-f173.google.com [209.85.210.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CA0A71FDF93 for ; Mon, 4 Nov 2024 23:50:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.173 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730764233; cv=none; b=PRlyd+S51bPYEXBD5ytFAnJlNq5mgm8pP39o1vlNIYBuqeWtBH1b72Gvwm3jAUcBUOIDKdR0ZENJ5C9lwV0QjZThYjLNM8u0phPslM9Y1LS2Ew8AqIneWA3cV+tZH9ab8Gxe06zF+piHPnjx6f7DXVsV+JduHxI5Rj974U6jcOI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730764233; c=relaxed/simple; bh=XHPVifGKXEqy8LE0q970p31W+sJjEWNZsP8R4d+Uo/0=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=dFQQb2mKD9sDwqBJqMHR/Y/JZGzH2y1zEsCeV9RKeIgpu+xwbvoDgBNDSo93G1oyn3RZPyLGZmTmkDbdK6xeVzDbvwIqipQqiXuYcP3cttpoQMK51RE0jxDwOjk5Kco794cutbq2pM6zWUsdPWsrJ/dcMWxPDsGBOhxhnS39bo8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=fastly.com; spf=pass smtp.mailfrom=fastly.com; dkim=pass (1024-bit key) header.d=fastly.com header.i=@fastly.com header.b=PAupFm0e; arc=none smtp.client-ip=209.85.210.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=fastly.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=fastly.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=fastly.com header.i=@fastly.com header.b="PAupFm0e" Received: by mail-pf1-f173.google.com with SMTP id d2e1a72fcca58-720b2d8bcd3so3874711b3a.2 for ; Mon, 04 Nov 2024 15:50:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fastly.com; s=google; t=1730764231; x=1731369031; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:cc:to:from:date:from:to:cc :subject:date:message-id:reply-to; bh=xDd2iS+HO9f2ODni7moor8fgiPBiv84xu1qF5aO0f1E=; b=PAupFm0eJU7oNszuHR2EeZK4hapGIJPeBS8WlM8xPtypTNhw2aO46E27q2yuXrq6Bk DT7nizFxDqRWYe1NkbBl0n0JIAton2M8UXAPc+DOL/7Dt/3IWsvtk5Ff5ZZvVm0M3MTh aSMAKyfnTALzmerGhwNuWMGXyxqf560gmpK1U= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1730764231; x=1731369031; h=in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=xDd2iS+HO9f2ODni7moor8fgiPBiv84xu1qF5aO0f1E=; b=PZN03dfJMSLkhRXNGVAsroGGFPAdj2UcYRA7OojchcbtJOAYonAZTiOYC1MVzMlWcg t8MNyY0TsMNEf3x4civ2M4TtDPhI/oErEgOyx4jtj0qTWKWtrNWneDDrB7sHmSS3HkX8 /nvfuqKfnTvqte21elK6U1nmHGAMT4jdpptqcunKmcjhmyIevkTkY3wHA6DLwr+dfXdh 7Sc7QseAT8Ak4OKCgqY3wHIsNKB81/urq6fyzdHt5Axp5GsjQHE/vi2+ZEMdPCn+vfFs EQKKjbrJXuWQWBs7nIcgFPatThp4kxEEd4dKprkYoC7zU6rajjQae2SgVJzWfF9HZzWU jTIw== X-Forwarded-Encrypted: i=1; AJvYcCVeuQxABSvWDRSCdZ/W6ruS/qpPQbTmy1CfrzLE1zFCTbTwyDn4//IVrcUirxSLQ9iamkhdA5meGn9qh6Aejcs=@vger.kernel.org X-Gm-Message-State: AOJu0YzcHTgjv0zoQHqd0zd4vFkBi2iyRKnXGQVVCRq8mAgA0KCUPkx7 LvM6YZvCaabAe3IoKm/sLj0LJQe91qcQ1KYVLx8hD7useCbSCrK/cdlmOaJs4zg= X-Google-Smtp-Source: AGHT+IHWzRXiGYvo8KNQLD4r4zmqsgkH7TShcEy59N1FdgKJ1Bm2tsdY9K3y3uV5t2Tk3W5BdjOUug== X-Received: by 2002:a05:6a00:14c9:b0:71e:cf8:d6fa with SMTP id d2e1a72fcca58-72062fdad1bmr45801290b3a.15.1730764231110; Mon, 04 Nov 2024 15:50:31 -0800 (PST) Received: from LQ3V64L9R2 (c-24-6-151-244.hsd1.ca.comcast.net. [24.6.151.244]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-720bc1ef8adsm8276729b3a.84.2024.11.04.15.50.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 04 Nov 2024 15:50:30 -0800 (PST) Date: Mon, 4 Nov 2024 15:50:27 -0800 From: Joe Damato To: Stanislav Fomichev Cc: netdev@vger.kernel.org, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, andrew+netdev@lunn.ch, shuah@kernel.org, horms@kernel.org, almasrymina@google.com, willemb@google.com, petrm@nvidia.com Subject: Re: [PATCH net-next v7 05/12] selftests: ncdevmem: Remove default arguments Message-ID: Mail-Followup-To: Joe Damato , Stanislav Fomichev , netdev@vger.kernel.org, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, andrew+netdev@lunn.ch, shuah@kernel.org, horms@kernel.org, almasrymina@google.com, willemb@google.com, petrm@nvidia.com References: <20241104181430.228682-1-sdf@fomichev.me> <20241104181430.228682-6-sdf@fomichev.me> Precedence: bulk X-Mailing-List: linux-kselftest@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20241104181430.228682-6-sdf@fomichev.me> On Mon, Nov 04, 2024 at 10:14:23AM -0800, Stanislav Fomichev wrote: > To make it clear what's required and what's not. Also, some of the > values don't seem like a good defaults; for example eth1. > > Move the invocation comment to the top, add missing -s to the client > and cleanup the client invocation a bit to make more readable. > > Reviewed-by: Mina Almasry > Signed-off-by: Stanislav Fomichev > --- > tools/testing/selftests/net/ncdevmem.c | 61 ++++++++++++++++---------- > 1 file changed, 39 insertions(+), 22 deletions(-) Reviewed-by: Joe Damato