From: Kuan-Wei Chiu <visitorckw@gmail.com>
To: Dan Carpenter <dan.carpenter@linaro.org>
Cc: Brendan Higgins <brendan.higgins@linux.dev>,
David Gow <davidgow@google.com>, Rae Moar <rmoar@google.com>,
linux-kselftest@vger.kernel.org, kunit-dev@googlegroups.com,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] kunit: skb: add gfp to kernel doc for kunit_zalloc_skb()
Date: Tue, 12 Nov 2024 00:09:19 +0800 [thread overview]
Message-ID: <ZzIsL7P7wDCP2VBR@visitorckw-System-Product-Name> (raw)
In-Reply-To: <b31a16ef-382f-4b8f-b4d5-1c4d93803779@stanley.mountain>
On Mon, Nov 11, 2024 at 01:54:09PM +0300, Dan Carpenter wrote:
> Kuan-Wei Chiu pointed out that the kernel doc for kunit_zalloc_skb()
> needs to include the @gfp information. Add it.
>
> Reported-by: Kuan-Wei Chiu <visitorckw@gmail.com>
> Closes: https://lore.kernel.org/all/Zy+VIXDPuU613fFd@visitorckw-System-Product-Name/
> Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Reviewed-by: Kuan-Wei Chiu <visitorckw@gmail.com>
Regards,
Kuan-Wei
> ---
> include/kunit/skbuff.h | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/include/kunit/skbuff.h b/include/kunit/skbuff.h
> index 345e1e8f0312..07784694357c 100644
> --- a/include/kunit/skbuff.h
> +++ b/include/kunit/skbuff.h
> @@ -20,8 +20,9 @@ static void kunit_action_kfree_skb(void *p)
> * kunit_zalloc_skb() - Allocate and initialize a resource managed skb.
> * @test: The test case to which the skb belongs
> * @len: size to allocate
> + * @gfp: allocation flags
> *
> - * Allocate a new struct sk_buff with GFP_KERNEL, zero fill the give length
> + * Allocate a new struct sk_buff with gfp flags, zero fill the given length
> * and add it as a resource to the kunit test for automatic cleanup.
> *
> * Returns: newly allocated SKB, or %NULL on error
> --
> 2.45.2
>
>
next prev parent reply other threads:[~2024-11-11 16:09 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-11 10:54 [PATCH] kunit: skb: add gfp to kernel doc for kunit_zalloc_skb() Dan Carpenter
2024-11-11 16:09 ` Kuan-Wei Chiu [this message]
2024-11-12 6:20 ` David Gow
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZzIsL7P7wDCP2VBR@visitorckw-System-Product-Name \
--to=visitorckw@gmail.com \
--cc=brendan.higgins@linux.dev \
--cc=dan.carpenter@linaro.org \
--cc=davidgow@google.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=kunit-dev@googlegroups.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=rmoar@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox