From: Catalin Marinas <catalin.marinas@arm.com>
To: Mark Brown <broonie@kernel.org>
Cc: Will Deacon <will@kernel.org>, Shuah Khan <shuah@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org
Subject: Re: [PATCH 2/4] kselftest/arm64: Use a define for SVCR
Date: Mon, 11 Nov 2024 23:34:02 +0000 [thread overview]
Message-ID: <ZzKUaqv_K-MRTti4@arm.com> (raw)
In-Reply-To: <20241107-arm64-fp-ptrace-fpmr-v1-2-3e5e0b6e3be9@kernel.org>
On Thu, Nov 07, 2024 at 01:38:05AM +0000, Mark Brown wrote:
> For some reason when we're accessing SVCR in the FP tests we use the raw
> numerical version of the register name rather than hiding that behind a
> preprocessor macro for readability. Since we already use the generated
> defines for sysreg bitfields in other the KVM selftests let's do the same
> thing here, also replacing the defines for the SVCR bitfields which we
> have.
>
> The build setup for fp-ptrace is a little fun so we have to manually define
> __ASSEMBLY__ in the source code for that.
>
> Signed-off-by: Mark Brown <broonie@kernel.org>
I get an error when trying to build this out of tree:
/home/cmarinas/work/linux/tools/testing/selftests/../../../tools/arch/arm64/include/asm/sysreg.h:132:10: fatal error: asm/sysreg-defs.h: No such file or directory
132 | #include "asm/sysreg-defs.h"
| ^~~~~~~~~~~~~~~~~~~
Probably sysreg-defs.h has not been generated yet. Too late to figure it
out now.
--
Catalin
next prev parent reply other threads:[~2024-11-11 23:34 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-07 1:38 [PATCH 0/4] kselftest/arm64: fp-ptrace enhancements Mark Brown
2024-11-07 1:38 ` [PATCH 1/4] kselftets/arm64: Use flag bits for features in fp-ptrace assembler code Mark Brown
2024-11-07 1:38 ` [PATCH 2/4] kselftest/arm64: Use a define for SVCR Mark Brown
2024-11-11 23:34 ` Catalin Marinas [this message]
2024-11-12 11:27 ` Mark Brown
2024-11-07 1:38 ` [PATCH 3/4] kselftest/arm64: Expand the set of ZA writes fp-ptrace does Mark Brown
2024-11-07 1:38 ` [PATCH 4/4] kselftest/arm64: Add FPMR coverage to fp-ptrace Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZzKUaqv_K-MRTti4@arm.com \
--to=catalin.marinas@arm.com \
--cc=broonie@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=shuah@kernel.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox