linux-kselftest.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 1/1] Fix typo in cpu-on-off-test selftest script:
@ 2025-05-17  1:19 Jihed Chaibi
  2025-05-22 22:43 ` Shuah Khan
  0 siblings, 1 reply; 2+ messages in thread
From: Jihed Chaibi @ 2025-05-17  1:19 UTC (permalink / raw)
  To: skhan, shuah
  Cc: linux-kselftest, linux-kernel, linux-kernel-mentees,
	jihed.chaibi.dev

Fix typo in hotplaggable_offline_cpus function name:

"hotplaggable" is replaced by "hotpluggable"

Signed-off-by: Jihed Chaibi <jihed.chaibi.dev@gmail.com>
---
 tools/testing/selftests/cpu-hotplug/cpu-on-off-test.sh | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/tools/testing/selftests/cpu-hotplug/cpu-on-off-test.sh b/tools/testing/selftests/cpu-hotplug/cpu-on-off-test.sh
index d5dc7e0dc..6232a46ca 100755
--- a/tools/testing/selftests/cpu-hotplug/cpu-on-off-test.sh
+++ b/tools/testing/selftests/cpu-hotplug/cpu-on-off-test.sh
@@ -67,7 +67,7 @@ hotpluggable_cpus()
 	done
 }
 
-hotplaggable_offline_cpus()
+hotpluggable_offline_cpus()
 {
 	hotpluggable_cpus 0
 }
@@ -151,7 +151,7 @@ offline_cpu_expect_fail()
 
 online_all_hot_pluggable_cpus()
 {
-	for cpu in `hotplaggable_offline_cpus`; do
+	for cpu in `hotpluggable_offline_cpus`; do
 		online_cpu_expect_success $cpu
 	done
 }
-- 
2.39.5


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH 1/1] Fix typo in cpu-on-off-test selftest script:
  2025-05-17  1:19 [PATCH 1/1] Fix typo in cpu-on-off-test selftest script: Jihed Chaibi
@ 2025-05-22 22:43 ` Shuah Khan
  0 siblings, 0 replies; 2+ messages in thread
From: Shuah Khan @ 2025-05-22 22:43 UTC (permalink / raw)
  To: Jihed Chaibi, shuah; +Cc: linux-kselftest, linux-kernel, linux-kernel-mentees

On 5/16/25 19:19, Jihed Chaibi wrote:
> Fix typo in hotplaggable_offline_cpus function name:
> 
> "hotplaggable" is replaced by "hotpluggable"
> 
> Signed-off-by: Jihed Chaibi <jihed.chaibi.dev@gmail.com>
> ---

Change looks good to me. Change log should specify the
subsusystem. Check submitting patches document and refer
to a few change logs for this file using git log.

Send v2 with a proper change log.

>   tools/testing/selftests/cpu-hotplug/cpu-on-off-test.sh | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/tools/testing/selftests/cpu-hotplug/cpu-on-off-test.sh b/tools/testing/selftests/cpu-hotplug/cpu-on-off-test.sh
> index d5dc7e0dc..6232a46ca 100755
> --- a/tools/testing/selftests/cpu-hotplug/cpu-on-off-test.sh
> +++ b/tools/testing/selftests/cpu-hotplug/cpu-on-off-test.sh
> @@ -67,7 +67,7 @@ hotpluggable_cpus()
>   	done
>   }
>   
> -hotplaggable_offline_cpus()
> +hotpluggable_offline_cpus()
>   {
>   	hotpluggable_cpus 0
>   }
> @@ -151,7 +151,7 @@ offline_cpu_expect_fail()
>   
>   online_all_hot_pluggable_cpus()
>   {
> -	for cpu in `hotplaggable_offline_cpus`; do
> +	for cpu in `hotpluggable_offline_cpus`; do
>   		online_cpu_expect_success $cpu
>   	done
>   }

thanks,
-- Shuah


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2025-05-22 22:43 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-05-17  1:19 [PATCH 1/1] Fix typo in cpu-on-off-test selftest script: Jihed Chaibi
2025-05-22 22:43 ` Shuah Khan

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).